Skip to content

quantized hardsigmoid, take 2#34959

Closed
vkuzo wants to merge 3 commits intogh/vkuzo/13/basefrom
gh/vkuzo/13/head
Closed

quantized hardsigmoid, take 2#34959
vkuzo wants to merge 3 commits intogh/vkuzo/13/basefrom
gh/vkuzo/13/head

Conversation

@vkuzo
Copy link
Copy Markdown
Contributor

@vkuzo vkuzo commented Mar 18, 2020 •
edited
Loading

Stack from ghstack:

Summary:

Adds quantized implementation of hardsigmoid.

Original PR was #34607 and had to
be reverted for a test breakage, trying again.

Test Plan:

tests
benchmarks

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: D20514212

@vkuzo
quantized hardsigmoid, take 2
257e002 
Summary:

Adds quantized implementation of hardsigmoid.

Original PR was #34607 and had to
be reverted for a test breakage, trying again.

Test Plan:

tests
benchmarks

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
@vkuzo vkuzo requested a review from apaszke as a code owner March 18, 2020 16:44
vkuzo added a commit that referenced this pull request Mar 18, 2020
@vkuzo
quantized hardsigmoid, take 2
09bac97 
Summary:

Adds quantized implementation of hardsigmoid.

Original PR was #34607 and had to
be reverted for a test breakage, trying again.

Test Plan:

tests
benchmarks

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: d58ebb5
Pull Request resolved: #34959
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 18, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 7082381 (more details on the Dr. CI page):

✅ None of the build failures appear to be your fault 💚

  • 2/3 tentatively recognized as flaky ❄️

  • 1/3 broken upstream at merge base 5d92a6c on Mar 19 from 12:27am to 2:53pm (16 commits; 2a1c838 - 7c06b86)

    Please rebase on the viable/strict branch (expand for instructions)

    Since your merge base is older than viable/strict, run these commands:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

    Check out the recency history of this "viable master" tracking branch.

❄️ 2 tentatively flaky failures

2 failures tentatively classified as flaky but have not triggered reruns to confirm:

See CircleCI build caffe2_onnx_py2_gcc5_ubuntu16_04_build (1/2)

Step: "Build" (full log | pattern match details) ❄️

Mar 19 16:42:26 fatal: The remote end hung up unexpectedly 
DOCKER_IMAGE: 308535385114.dkr.ecr.us-east-1.amazonaws.com/caffe2/py2-gcc5-ubuntu16.04:345 
 
real	0m26.189s 
user	0m0.075s 
sys	0m0.042s 
Mar 19 16:42:20 ++ export BUILD_ENVIRONMENT=caffe2-onnx-py2-gcc5-ubuntu16.04-build 
Mar 19 16:42:20 ++ BUILD_ENVIRONMENT=caffe2-onnx-py2-gcc5-ubuntu16.04-build 
Mar 19 16:42:20 ++ git submodule sync 
Mar 19 16:42:20 ++ git submodule update -q --init --recursive 
Mar 19 16:42:26 error: RPC failed; curl 56 GnuTLS recv error (-54): Error in the pull function. 
Mar 19 16:42:26 fatal: The remote end hung up unexpectedly 
Mar 19 16:42:26 fatal: early EOF 
Mar 19 16:42:26 fatal: index-pack failed 
Mar 19 16:42:26 fatal: clone of 'https://github.com/pytorch/cpuinfo.git' into submodule path 'third_party/cpuinfo' failed

See CircleCI build pytorch_macos_10_13_py3_test (2/2)

Step: "Test" (full log | pattern match details) ❄️

Mar 19 12:34:42 AssertionError: 6 not less than or equal to 1e-05 : 
Mar 19 12:34:42 ---------------------------------------------------------------------- 
Mar 19 12:34:42 Traceback (most recent call last): 
Mar 19 12:34:42   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_distributed.py", line 175, in wrapper 
Mar 19 12:34:42     self._join_processes(fn) 
Mar 19 12:34:42   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_distributed.py", line 285, in _join_processes 
Mar 19 12:34:42     self._check_return_codes(elapsed_time) 
Mar 19 12:34:42   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_distributed.py", line 324, in _check_return_codes 
Mar 19 12:34:42     self.assertEqual(p.exitcode, first_process.exitcode) 
Mar 19 12:34:42   File "/Users/distiller/workspace/miniconda3/lib/python3.7/site-packages/torch/testing/_internal/common_utils.py", line 915, in assertEqual 
Mar 19 12:34:42     super(TestCase, self).assertLessEqual(abs(x - y), prec, message) 
Mar 19 12:34:42 AssertionError: 6 not less than or equal to 1e-05 :  
Mar 19 12:34:42  
Mar 19 12:34:42 ---------------------------------------------------------------------- 
Mar 19 12:34:42 Ran 62 tests in 148.054s 
Mar 19 12:34:42  
Mar 19 12:34:42 FAILED (failures=1, skipped=3) 
Mar 19 12:34:42  
Mar 19 12:34:42 Generating XML reports... 
Mar 19 12:34:42 Traceback (most recent call last): 
Mar 19 12:34:42   File "test/run_test.py", line 674, in <module> 
Mar 19 12:34:42     main()

🚧 1 upstream failure:

These were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 9 times.

@vkuzo
Update on "quantized hardsigmoid, take 2"
55f379b 
Summary:

Adds quantized implementation of hardsigmoid.

Original PR was #34607 and had to
be reverted for a test breakage, trying again.

Test Plan:

tests
benchmarks

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20514212](https://our.internmc.facebook.com/intern/diff/D20514212)

[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 19, 2020
@vkuzo
quantized hardsigmoid, take 2
6d39b37 
Summary:

Adds quantized implementation of hardsigmoid.

Original PR was #34607 and had to
be reverted for a test breakage, trying again.

Test Plan:

tests
benchmarks

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 66b9504
Pull Request resolved: #34959
@vkuzo
Update on "quantized hardsigmoid, take 2"
7082381 
Summary:

Adds quantized implementation of hardsigmoid.

Original PR was #34607 and had to
be reverted for a test breakage, trying again.

Test Plan:

tests
benchmarks

Reviewers:

Subscribers:

Tasks:

Tags:

Differential Revision: [D20514212](https://our.internmc.facebook.com/intern/diff/D20514212)

[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 19, 2020
@vkuzo
quantized hardsigmoid, take 2
127855e 
Summary:

Adds quantized implementation of hardsigmoid.

Original PR was #34607 and had to
be reverted for a test breakage, trying again.

Test Plan:

tests
benchmarks

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 6dcd01c
Pull Request resolved: #34959
z-a-f
z-a-f reviewed Mar 19, 2020
View reviewed changes
Comment thread torch/nn/quantized/functional.py
def hardsigmoid(input):
# type: (Tensor) -> Tensor
r"""
Applies the quantized element-wise function :math:`\text{Hardsigmoid}(x) = \frac{ReLU6(x + 3)}{6}`
Copy link
Copy Markdown

@z-a-f z-a-f Mar 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, change the math documentation to the cases -- using ReLU6 in the math description is not very easy to understand. In addition to that we don't want to expose the implementation :)

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Mar 20, 2020

This pull request has been merged in 37b234a.

@vkuzo vkuzo mentioned this pull request Mar 20, 2020
Closed
vkuzo added a commit that referenced this pull request Mar 20, 2020
@vkuzo
fix missing comma in activation benchmarks
9d32d4c 
Summary:

I missed this in #34959
after a rebase, fixing.

Test Plan:

running benchmarks no longer crashes
CI

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
vkuzo added a commit that referenced this pull request Mar 20, 2020
@vkuzo
fix missing comma in activation benchmarks
751383d 
Summary:

I missed this in #34959
after a rebase, fixing.

Test Plan:

running benchmarks no longer crashes
CI

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 4b04e68
Pull Request resolved: #35104
facebook-github-bot pushed a commit that referenced this pull request Mar 20, 2020
@vkuzo @facebook-github-bot
fix missing comma in activation benchmarks (#35104)
bf41a76 
Summary:
Pull Request resolved: #35104

I missed this in #34959
after a rebase, fixing.

Test Plan:
running benchmarks no longer crashes
CI

Imported from OSS

Differential Revision: D20560908

fbshipit-source-id: a5494e23953d3c9007e9874d673896291b5322e0
@facebook-github-bot facebook-github-bot deleted the gh/vkuzo/13/head branch March 23, 2020 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@vkuzo @facebook-github-bot
quantized hardsigmoid, take 2 (pytorch#34959)
6f4edce 
Summary:
Pull Request resolved: pytorch#34959

Adds quantized implementation of hardsigmoid.

Original PR was pytorch#34607 and had to
be reverted for a test breakage, trying again.

Test Plan:
tests
benchmarks

Imported from OSS

Differential Revision: D20514212

fbshipit-source-id: cc7ae3b67757e2dde5c313c05ce60a0f2625d961
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
@vkuzo @facebook-github-bot
fix missing comma in activation benchmarks (pytorch#35104)
3200b56 
Summary:
Pull Request resolved: pytorch#35104

I missed this in pytorch#34959
after a rebase, fixing.

Test Plan:
running benchmarks no longer crashes
CI

Imported from OSS

Differential Revision: D20560908

fbshipit-source-id: a5494e23953d3c9007e9874d673896291b5322e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apaszke apaszke Awaiting requested review from apaszke

2 more reviewers

@z-a-f z-a-f z-a-f left review comments

@raghuramank100 raghuramank100 raghuramank100 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vkuzo @facebook-github-bot @z-a-f @raghuramank100 @mruberry