Skip to content

Don't change global executor state in test_jit.py - rather do that in setUp and tearDown.#34982

Closed
ZolotukhinM wants to merge 3 commits intogh/ZolotukhinM/195/basefrom
gh/ZolotukhinM/195/head
Closed

Don't change global executor state in test_jit.py - rather do that in setUp and tearDown.#34982
ZolotukhinM wants to merge 3 commits intogh/ZolotukhinM/195/basefrom
gh/ZolotukhinM/195/head

Conversation

@ZolotukhinM
Copy link
Copy Markdown

@ZolotukhinM ZolotukhinM commented Mar 18, 2020 •
edited
Loading

Stack from ghstack:

Differential Revision: D20520370

This was referenced Mar 18, 2020
Closed
Closed
Closed
@ZolotukhinM ZolotukhinM requested review from Krovatkin and suo March 18, 2020 20:53
Mikhail Zolotukhin added 2 commits March 18, 2020 14:18
Update on "Don't change global executor state in test_jit.py - rather…
5a98a1a 
… do that in setUp and tearDown."

Differential Revision: [D20520370](https://our.internmc.facebook.com/intern/diff/D20520370)

[ghstack-poisoned]
Update on "Don't change global executor state in test_jit.py - rather…
890c14f 
… do that in setUp and tearDown."

Differential Revision: [D20520370](https://our.internmc.facebook.com/intern/diff/D20520370)

[ghstack-poisoned]
Krovatkin
Krovatkin approved these changes Mar 18, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Comment thread test/test_jit.py


class TestScript(JitTestCase):
def setUp(self):
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin Mar 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i wonder if we could maybe define a subclass of JitTestCase that overrides setUp anad tearDown make TestScript and TestJit extend it?

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 19, 2020 •
edited
Loading

💊 CircleCI build failures summary and remediations

As of commit 890c14f (more details on the Dr. CI page):

  • 6/7 failures introduced in this PR

  • 1/7 broken upstream at merge base a3de359 on Mar 18 from 7:01am to 8:48am (2 commits; b712905 - a1eaaea)

    Please rebase on the viable/strict branch (expand for instructions)

    Since your merge base is older than viable/strict, run these commands:

    git fetch https://github.com/pytorch/pytorch viable/strict
git rebase FETCH_HEAD

    Check out the recency history of this "viable master" tracking branch.

🕵️ 5 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakages:

See CircleCI build pytorch_macos_10_13_py3_test (1/5)

Step: "Test" (full log | pattern match details)

Mar 18 16:18:49 RuntimeError: test_jit failed! 
Mar 18 16:18:48 Ran 2434 tests in 146.850s 
Mar 18 16:18:48  
Mar 18 16:18:48 FAILED (failures=1, errors=2, skipped=72, expected failures=1) 
Mar 18 16:18:48  
Mar 18 16:18:48 Generating XML reports... 
Mar 18 16:18:49 Traceback (most recent call last): 
Mar 18 16:18:49   File "test/run_test.py", line 674, in <module> 
Mar 18 16:18:49     main() 
Mar 18 16:18:49   File "test/run_test.py", line 667, in main 
Mar 18 16:18:49     raise RuntimeError(message) 
Mar 18 16:18:49 RuntimeError: test_jit failed! 
Mar 18 16:18:49 + cleanup 
Mar 18 16:18:49 + retcode=1 
Mar 18 16:18:49 + set +x

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_simple_test (2/5)

Step: "Test" (full log | pattern match details)

Mar 18 23:45:28 RuntimeError: test_jit_simple failed! 
Mar 18 23:45:28 Ran 2437 tests in 97.167s 
Mar 18 23:45:28  
Mar 18 23:45:28 FAILED (failures=1, errors=2, skipped=86, expected failures=1) 
Mar 18 23:45:28  
Mar 18 23:45:28 Generating XML reports... 
Mar 18 23:45:28 Traceback (most recent call last): 
Mar 18 23:45:28   File "test/run_test.py", line 674, in <module> 
Mar 18 23:45:28     main() 
Mar 18 23:45:28   File "test/run_test.py", line 667, in main 
Mar 18 23:45:28     raise RuntimeError(message) 
Mar 18 23:45:28 RuntimeError: test_jit_simple failed! 
Mar 18 23:45:29 + cleanup 
Mar 18 23:45:29 + retcode=1 
Mar 18 23:45:29 + set +x 
Mar 18 23:45:29 =================== sccache compilation log =================== 
Mar 18 23:45:29 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Mar 18 23:45:29 Compile requests                 2 
Mar 18 23:45:29 Compile requests executed        0 
Mar 18 23:45:29 Cache hits                       0 
Mar 18 23:45:29 Cache misses                     0 
Mar 18 23:45:29 Cache timeouts                   0

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_ge_config_legacy_test (3/5)

Step: "Test" (full log | pattern match details)

Mar 18 23:46:15 RuntimeError: test_jit_legacy failed! 
Mar 18 23:46:15 Ran 2437 tests in 161.273s 
Mar 18 23:46:15  
Mar 18 23:46:15 FAILED (failures=1, errors=2, skipped=70, expected failures=1) 
Mar 18 23:46:15  
Mar 18 23:46:15 Generating XML reports... 
Mar 18 23:46:15 Traceback (most recent call last): 
Mar 18 23:46:15   File "test/run_test.py", line 674, in <module> 
Mar 18 23:46:15     main() 
Mar 18 23:46:15   File "test/run_test.py", line 667, in main 
Mar 18 23:46:15     raise RuntimeError(message) 
Mar 18 23:46:15 RuntimeError: test_jit_legacy failed! 
Mar 18 23:46:15 + cleanup 
Mar 18 23:46:15 + retcode=1 
Mar 18 23:46:15 + set +x 
Mar 18 23:46:15 =================== sccache compilation log =================== 
Mar 18 23:46:15 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Mar 18 23:46:15 Compile requests               250 
Mar 18 23:46:15 Compile requests executed        0 
Mar 18 23:46:15 Cache hits                       0 
Mar 18 23:46:15 Cache misses                     0 
Mar 18 23:46:15 Cache timeouts                   0

See CircleCI build pytorch_linux_xenial_cuda10_2_cudnn7_py3_gcc7_test (4/5)

Step: "Test" (full log | pattern match details)

Mar 19 00:24:08 RuntimeError: test_jit failed! 
Mar 19 00:24:08 Ran 2437 tests in 116.012s 
Mar 19 00:24:08  
Mar 19 00:24:08 FAILED (failures=1, errors=2, skipped=34, expected failures=1) 
Mar 19 00:24:08  
Mar 19 00:24:08 Generating XML reports... 
Mar 19 00:24:08 Traceback (most recent call last): 
Mar 19 00:24:08   File "test/run_test.py", line 674, in <module> 
Mar 19 00:24:08     main() 
Mar 19 00:24:08   File "test/run_test.py", line 667, in main 
Mar 19 00:24:08     raise RuntimeError(message) 
Mar 19 00:24:08 RuntimeError: test_jit failed! 
Mar 19 00:24:09 + cleanup 
Mar 19 00:24:09 + retcode=1 
Mar 19 00:24:09 + set +x 
Mar 19 00:24:09 =================== sccache compilation log =================== 
Mar 19 00:24:09 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Mar 19 00:24:09 Compile requests               133 
Mar 19 00:24:09 Compile requests executed       46 
Mar 19 00:24:09 Cache hits                      44 
Mar 19 00:24:09 Cache misses                     1 
Mar 19 00:24:09 Cache timeouts                   0

See CircleCI build pytorch_linux_xenial_py3_6_gcc5_4_test (5/5)

Step: "Test" (full log | pattern match details)

Mar 19 00:36:11 RuntimeError: test_jit failed! 
Mar 19 00:36:11 Ran 2437 tests in 117.976s 
Mar 19 00:36:11  
Mar 19 00:36:11 FAILED (failures=1, errors=2, skipped=67, expected failures=1) 
Mar 19 00:36:11  
Mar 19 00:36:11 Generating XML reports... 
Mar 19 00:36:11 Traceback (most recent call last): 
Mar 19 00:36:11   File "test/run_test.py", line 674, in <module> 
Mar 19 00:36:11     main() 
Mar 19 00:36:11   File "test/run_test.py", line 667, in main 
Mar 19 00:36:11     raise RuntimeError(message) 
Mar 19 00:36:11 RuntimeError: test_jit failed! 
Mar 19 00:36:11 + cleanup 
Mar 19 00:36:11 + retcode=1 
Mar 19 00:36:11 + set +x 
Mar 19 00:36:11 =================== sccache compilation log =================== 
Mar 19 00:36:11 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Mar 19 00:36:11 Compile requests                48 
Mar 19 00:36:11 Compile requests executed       22 
Mar 19 00:36:11 Cache hits                      21 
Mar 19 00:36:11 Cache misses                     0 
Mar 19 00:36:11 Cache timeouts                   0

🚧 1 upstream failure:

These were probably caused by upstream breakages:

This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 2 times.

@facebook-github-bot facebook-github-bot deleted the gh/ZolotukhinM/195/head branch April 19, 2020 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@suo suo Awaiting requested review from suo

1 more reviewer

@Krovatkin Krovatkin Krovatkin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ZolotukhinM @Krovatkin