Skip to content

Fix warnings in test/test_jit_fuser.py#34980

Closed
ZolotukhinM wants to merge 3 commits intogh/ZolotukhinM/193/basefrom
gh/ZolotukhinM/193/head
Closed

Fix warnings in test/test_jit_fuser.py#34980
ZolotukhinM wants to merge 3 commits intogh/ZolotukhinM/193/basefrom
gh/ZolotukhinM/193/head

Conversation

@ZolotukhinM
Copy link
Copy Markdown

@ZolotukhinM ZolotukhinM commented Mar 18, 2020

Stack from ghstack:

We were passing sample inputs to torch.jit.script (as if it was
torch.jit.trace), but this parameter was treated as an optional
optimize parameter. That parameter is deprecated and that caused a
warning.

Differential Revision: D20520369

We were passing sample inputs to `torch.jit.script` (as if it was
`torch.jit.trace`), but this parameter was treated as an optional
`optimize` parameter. That parameter is deprecated and that caused a
warning.

[ghstack-poisoned]
Mikhail Zolotukhin added 2 commits March 18, 2020 14:18
We were passing sample inputs to `torch.jit.script` (as if it was
`torch.jit.trace`), but this parameter was treated as an optional
`optimize` parameter. That parameter is deprecated and that caused a
warning.

Differential Revision: [D20520369](https://our.internmc.facebook.com/intern/diff/D20520369)

[ghstack-poisoned]
We were passing sample inputs to `torch.jit.script` (as if it was
`torch.jit.trace`), but this parameter was treated as an optional
`optimize` parameter. That parameter is deprecated and that caused a
warning.

Differential Revision: [D20520369](https://our.internmc.facebook.com/intern/diff/D20520369)

[ghstack-poisoned]
Copy link
Copy Markdown
Contributor

@Krovatkin Krovatkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 19, 2020

💊 CircleCI build failures summary and remediations

As of commit a525bc3 (more details on the Dr. CI page):


None of the build failures appear to be your fault 💚


  • 1/1 broken upstream at merge base a3de359 on Mar 18 from 7:01am to 8:48am (2 commits; b712905 - a1eaaea)

    Please rebase on the viable/strict branch (expand for instructions)

    Since your merge base is older than viable/strict, run these commands:

    git fetch https://github.com/pytorch/pytorch viable/strict
    git rebase FETCH_HEAD
    

    Check out the recency history of this "viable master" tracking branch.


🚧 1 upstream failure:

These were probably caused by upstream breakages:


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 1 time.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@ZolotukhinM merged this pull request in eef17ed.

@facebook-github-bot facebook-github-bot deleted the gh/ZolotukhinM/193/head branch March 22, 2020 14:17
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#34980

We were passing sample inputs to `torch.jit.script` (as if it was
`torch.jit.trace`), but this parameter was treated as an optional
`optimize` parameter. That parameter is deprecated and that caused a
warning.

Differential Revision: D20520369

Test Plan: Imported from OSS

Pulled By: ZolotukhinM

fbshipit-source-id: 87b40a5e35bfc4a3d7a5d95494632bfe117e40b7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants