Skip to content

[build] Update gloo submodule#34969

Closed
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/update-gloo
Closed

[build] Update gloo submodule#34969
malfet wants to merge 1 commit intopytorch:masterfrom
malfet:malfet/update-gloo

Conversation

@malfet
Copy link
Copy Markdown
Contributor

@malfet malfet commented Mar 18, 2020

Update gloo submodule to 113bde13035594cafdca247be953610b53026553 be compatible with separate compilation introduced by
pytorch/gloo#251

Test Plan: CI

@malfet malfet requested review from seemethere and yns88 March 18, 2020 19:02
@malfet malfet force-pushed the malfet/update-gloo branch from 2f9b01b to b83ad70 Compare March 18, 2020 19:03
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 18, 2020

💊 CircleCI build failures summary and remediations

As of commit 63e3b74 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 2 times.

Copy link
Copy Markdown
Member

@seemethere seemethere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

Update gloo submodule to `113bde13035594cafdca247be953610b53026553` be compatible with separate compilation introduced by
pytorch/gloo#251

Test Plan: CI
@malfet malfet force-pushed the malfet/update-gloo branch from b83ad70 to 63e3b74 Compare March 18, 2020 21:28
Copy link
Copy Markdown
Contributor

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@malfet is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@malfet merged this pull request in d3b6099.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@malfet merged this pull request in d3b6099.

laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Update gloo submodule to `113bde13035594cafdca247be953610b53026553` be compatible with separate compilation introduced by
pytorch/gloo#251
Pull Request resolved: pytorch#34969

Test Plan: CI

Differential Revision: D20527163

Pulled By: malfet

fbshipit-source-id: 300d83d8fe95d57b8d740543efada3c56ac7b493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants