Pass -Xcompiler -fPIC as 2 separate arguments#251
Closed
malfet wants to merge 1 commit intopytorch:masterfrom
Closed
Pass -Xcompiler -fPIC as 2 separate arguments#251malfet wants to merge 1 commit intopytorch:masterfrom
malfet wants to merge 1 commit intopytorch:masterfrom
Conversation
nvcc from CUDA-10.1 fails to parse "-Xcompiler -fPIC" passed as single argument: ``` $ nvcc -V; nvcc "-Xcompiler -fPIC" nvcc: NVIDIA (R) Cuda compiler driver Copyright (c) 2005-2019 NVIDIA Corporation Built on Wed_Apr_24_19:10:27_PDT_2019 Cuda compilation tools, release 10.1, V10.1.168 nvcc fatal : Unknown option 'Xcompiler -fPIC' ``` Test Plan: CI
facebook-github-bot
left a comment
There was a problem hiding this comment.
@malfet has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
seemethere
approved these changes
Mar 17, 2020
malfet
added a commit
to malfet/pytorch
that referenced
this pull request
Mar 18, 2020
Update gloo submodule to `113bde13035594cafdca247be953610b53026553` be compatible with separate compilation introduced by pytorch/gloo#251 Test Plan: CI
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 19, 2020
Summary: Update gloo submodule to `113bde13035594cafdca247be953610b53026553` be compatible with separate compilation introduced by pytorch/gloo#251 Pull Request resolved: #34969 Test Plan: CI Differential Revision: D20527163 Pulled By: malfet fbshipit-source-id: 300d83d8fe95d57b8d740543efada3c56ac7b493
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Update gloo submodule to `113bde13035594cafdca247be953610b53026553` be compatible with separate compilation introduced by pytorch/gloo#251 Pull Request resolved: pytorch#34969 Test Plan: CI Differential Revision: D20527163 Pulled By: malfet fbshipit-source-id: 300d83d8fe95d57b8d740543efada3c56ac7b493
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nvcc from CUDA-10.1 fails to parse "-Xcompiler -fPIC" passed as single argument:
Test Plan: CI