Skip to content

Add cpu_serial_kernel_vec#34553

Closed
xuhdev wants to merge 10 commits intogh/xuhdev/64/basefrom
gh/xuhdev/64/head
Closed

Add cpu_serial_kernel_vec#34553
xuhdev wants to merge 10 commits intogh/xuhdev/64/basefrom
gh/xuhdev/64/head

Conversation

@xuhdev
Copy link
Copy Markdown
Collaborator

@xuhdev xuhdev commented Mar 10, 2020

Stack from ghstack:

This allows vectorized looping in a serial iteration over
TensorIterator.

Differential Revision: D20604238

This allows vectorized looping in a serial iteration over
TensorIterator.

[ghstack-poisoned]
This allows vectorized looping in a serial iteration over
TensorIterator.

[ghstack-poisoned]
@dr-ci
Copy link
Copy Markdown

dr-ci Bot commented Mar 11, 2020

💊 CircleCI build failures summary and remediations

As of commit 361f670 (more details on the Dr. CI page):


💚 💚 Looks good so far! There are no CircleCI failures yet. 💚 💚


This comment was automatically generated by Dr. CI (expand for details).Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 31 times.

@xuhdev xuhdev requested a review from VitalyFedyunin March 11, 2020 02:26
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Mar 11, 2020
This allows vectorized looping in a serial iteration over
TensorIterator.

[ghstack-poisoned]
@xuhdev xuhdev requested a review from ifedan March 12, 2020 21:35
xuhdev added 6 commits March 12, 2020 15:02
This allows vectorized looping in a serial iteration over
TensorIterator.

[ghstack-poisoned]
This allows vectorized looping in a serial iteration over
TensorIterator.

[ghstack-poisoned]
This allows vectorized looping in a serial iteration over
TensorIterator.

[ghstack-poisoned]
This allows vectorized looping in a serial iteration over
TensorIterator.

[ghstack-poisoned]
This allows vectorized looping in a serial iteration over
TensorIterator.

[ghstack-poisoned]
This allows vectorized looping in a serial iteration over
TensorIterator.

[ghstack-poisoned]
@xuhdev xuhdev requested a review from ezyang March 20, 2020 18:22
This allows vectorized looping in a serial iteration over
TensorIterator.

[ghstack-poisoned]
@anjali411
Copy link
Copy Markdown
Contributor

@ezyang can you take a look at this PR?

Copy link
Copy Markdown
Contributor

@ezyang ezyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code duplication is irritating but I suppose this will have to do.

@xuhdev
Copy link
Copy Markdown
Collaborator Author

xuhdev commented Mar 23, 2020

I think so. Other functions in the same file also have significant duplication, while they are not completely the same.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

@ezyang merged this pull request in 50eb1a3.

@facebook-github-bot facebook-github-bot deleted the gh/xuhdev/64/head branch March 28, 2020 14:36
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#34553

This allows vectorized looping in a serial iteration over
TensorIterator.

Test Plan: Imported from OSS

Differential Revision: D20604238

Pulled By: ezyang

fbshipit-source-id: 61c451dac91d47cde7e1a937b271ab78c79e05d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged open source triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants