[JIT] add support for torch.lu to torchscript by eellison · Pull Request #33724 · pytorch/pytorch

eellison · 2020-02-24T21:40:59Z

Stack from ghstack:

[JIT] Add support for list() #33818 [JIT] Add support for list()
[JIT] add support for torch.norm #33783 [JIT] add support for torch.norm
[JIT] add support for torch.cdist #33737 [JIT] add support for torch.cdist
[JIT] add support for lu_unpack #33736 [JIT] add support for lu_unpack
[JIT] add support for torch.lu to torchscript #33724 [JIT] add support for torch.lu to torchscript
[JIT] fix resolving of functions in torch/functional. fix compilation of torch.stft #33504 [JIT] fix resolving of functions in torch/functional. fix compilation of torch.stft

Fix for #33381, partial fix of #30786

Differential Revision: D20077321

[ghstack-poisoned]

dr-ci · 2020-02-24T22:22:00Z

💊 CircleCI build failures summary and remediations

As of commit c403245:

5/9 failures introduced in this PR
4/9 recognized as flaky ❄️
- Re-run these jobs?

Detailed failure analysis

One may explore the probable reasons each build failed interactively on the Dr. CI website.

🕵️ 5 new failures recognized by patterns

The following build failures do not appear to be due to upstream breakage:

pytorch_macos_10_13_py3_test (1/5)

Step: "Test" (full log | pattern match details)

Feb 26 16:19:33 RuntimeError: test_overrides failed!

Feb 26 16:19:33  
Feb 26 16:19:33 ---------------------------------------------------------------------- 
Feb 26 16:19:33 Ran 387 tests in 0.343s 
Feb 26 16:19:33  
Feb 26 16:19:33 FAILED (errors=1) 
Feb 26 16:19:33 Traceback (most recent call last): 
Feb 26 16:19:33   File "test/run_test.py", line 493, in <module> 
Feb 26 16:19:33     main() 
Feb 26 16:19:33   File "test/run_test.py", line 486, in main 
Feb 26 16:19:33     raise RuntimeError(message) 
Feb 26 16:19:33 RuntimeError: test_overrides failed! 
Feb 26 16:19:33 + cleanup 
Feb 26 16:19:33 + retcode=1 
Feb 26 16:19:33 + set +x

pytorch_linux_xenial_py3_6_gcc5_4_test (2/5)

Step: "Test" (full log | pattern match details)

Feb 27 00:25:23 RuntimeError: test_overrides failed!

Feb 27 00:25:23  
Feb 27 00:25:23 ---------------------------------------------------------------------- 
Feb 27 00:25:23 Ran 387 tests in 0.261s 
Feb 27 00:25:23  
Feb 27 00:25:23 FAILED (errors=1) 
Feb 27 00:25:23 Traceback (most recent call last): 
Feb 27 00:25:23   File "test/run_test.py", line 493, in <module> 
Feb 27 00:25:23     main() 
Feb 27 00:25:23   File "test/run_test.py", line 486, in main 
Feb 27 00:25:23     raise RuntimeError(message) 
Feb 27 00:25:23 RuntimeError: test_overrides failed! 
Feb 27 00:25:23 + cleanup 
Feb 27 00:25:23 + retcode=1 
Feb 27 00:25:23 + set +x 
Feb 27 00:25:23 =================== sccache compilation log =================== 
Feb 27 00:25:23 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/tmp/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/tmp/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" } 
Feb 27 00:25:23  
Feb 27 00:25:23 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Feb 27 00:25:23 Compile requests                 65 
Feb 27 00:25:23 Compile requests executed        28 
Feb 27 00:25:23 Cache hits                       21

pytorch_windows_vs2019_py36_cuda10.1_test2 (3/5)

Step: "Test" (full log | pattern match details)

RuntimeError: test_overrides failed!

 
---------------------------------------------------------------------- 
Ran 387 tests in 1.294s 
 
FAILED (errors=1) 
Traceback (most recent call last): 
  File "run_test.py", line 493, in <module> 
    main() 
  File "run_test.py", line 486, in main 
    raise RuntimeError(message) 
RuntimeError: test_overrides failed! 
 
(base) circleci@PACKER-5E4AB9BE C:\Users\circleci\project\test>if ERRORLEVEL 1 exit /b 1  
+ cleanup
+ retcode=1
+ set +x

pytorch_linux_xenial_cuda10_1_cudnn7_py3_nogpu_test (4/5)

Step: "Test" (full log | pattern match details)

Feb 27 00:42:07 RuntimeError: test_overrides failed!

Feb 27 00:42:06  
Feb 27 00:42:06 ---------------------------------------------------------------------- 
Feb 27 00:42:06 Ran 387 tests in 0.228s 
Feb 27 00:42:06  
Feb 27 00:42:06 FAILED (errors=1) 
Feb 27 00:42:07 Traceback (most recent call last): 
Feb 27 00:42:07   File "test/run_test.py", line 493, in <module> 
Feb 27 00:42:07     main() 
Feb 27 00:42:07   File "test/run_test.py", line 486, in main 
Feb 27 00:42:07     raise RuntimeError(message) 
Feb 27 00:42:07 RuntimeError: test_overrides failed! 
Feb 27 00:42:07 + cleanup 
Feb 27 00:42:07 + retcode=1 
Feb 27 00:42:07 + set +x 
Feb 27 00:42:07 =================== sccache compilation log =================== 
Feb 27 00:42:07 ERROR:sccache::server: Compilation failed: Output { status: ExitStatus(ExitStatus(256)), stdout: "", stderr: "/tmp/torch_extensions/test_compilation_error_formatting/main.cpp: In function \'int main()\':\n/tmp/torch_extensions/test_compilation_error_formatting/main.cpp:2:23: error: expected \';\' before \'}\' token\n int main() { return 0 }\n                       ^\n" } 
Feb 27 00:42:07  
Feb 27 00:42:07 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Feb 27 00:42:07 Compile requests                 65 
Feb 27 00:42:07 Compile requests executed        28 
Feb 27 00:42:07 Cache hits                       21

pytorch_linux_xenial_py3_clang5_asan_test (5/5)

Step: "Test" (full log | pattern match details)

Feb 27 01:44:28 RuntimeError: test_overrides failed!

Feb 27 01:44:28  
Feb 27 01:44:28 ---------------------------------------------------------------------- 
Feb 27 01:44:28 Ran 387 tests in 0.282s 
Feb 27 01:44:28  
Feb 27 01:44:28 FAILED (errors=1) 
Feb 27 01:44:28 Traceback (most recent call last): 
Feb 27 01:44:28   File "test/run_test.py", line 493, in <module> 
Feb 27 01:44:28     main() 
Feb 27 01:44:28   File "test/run_test.py", line 486, in main 
Feb 27 01:44:28     raise RuntimeError(message) 
Feb 27 01:44:28 RuntimeError: test_overrides failed! 
Feb 27 01:44:29 + cleanup 
Feb 27 01:44:29 + retcode=1 
Feb 27 01:44:29 + set +x 
Feb 27 01:44:29 =================== sccache compilation log =================== 
Feb 27 01:44:29 =========== If your build fails, please take a look at the log above for possible reasons =========== 
Feb 27 01:44:29 Compile requests                10 
Feb 27 01:44:29 Compile requests executed        0 
Feb 27 01:44:29 Cache hits                       0 
Feb 27 01:44:29 Cache misses                     0 
Feb 27 01:44:29 Cache timeouts                   0

❄️ 4 failures recognized as flaky

The following build failures have been detected as flaky and may not be your fault:

caffe2_onnx_py3_6_clang7_ubuntu16_04_test (1/4)

Step: "Test" (full log | pattern match details) ❄️

Feb 27 00:08:46 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_slice_negative_index Fatal Python error: Segmentation fault

Feb 27 00:08:44 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_is_in_onnx_export PASSED [ 99%] 
Feb 27 00:08:44 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_strip_doc_string PASSED [ 99%] 
Feb 27 00:08:44 test/onnx/test_utility_funs.py::TestUtilityFuns_opset11::test_validate_dynamic_axes_invalid_input_output_name PASSED [ 99%] 
Feb 27 00:08:44 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_concat PASSED [ 99%] 
Feb 27 00:08:44 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_div PASSED [ 99%] 
Feb 27 00:08:44 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_lstm PASSED [ 99%] 
Feb 27 00:08:44 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_mul PASSED [ 99%] 
Feb 27 00:08:44 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_reshape SKIPPED [ 99%] 
Feb 27 00:08:44 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_slice PASSED [ 99%] 
Feb 27 00:08:44 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_slice_index_exceeds_dim PASSED [ 99%] 
Feb 27 00:08:46 test/onnx/test_utility_funs.py::TestUtilityFuns::test_constant_fold_slice_negative_index Fatal Python error: Segmentation fault 
Feb 27 00:08:46  
Feb 27 00:08:46 Current thread 0x00007fc3143bd700 (most recent call first): 
Feb 27 00:08:46   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 43 in repr_instance 
Feb 27 00:08:46   File "/usr/lib/python3.6/reprlib.py", line 65 in repr1 
Feb 27 00:08:46   File "/usr/lib/python3.6/reprlib.py", line 55 in repr 
Feb 27 00:08:46   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 36 in repr 
Feb 27 00:08:46   File "/usr/local/lib/python3.6/dist-packages/_pytest/_io/saferepr.py", line 67 in saferepr 
Feb 27 00:08:46   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 655 in repr_args 
Feb 27 00:08:46   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 736 in repr_traceback_entry 
Feb 27 00:08:46   File "/usr/local/lib/python3.6/dist-packages/_pytest/_code/code.py", line 777 in repr_traceback

pytorch_linux_xenial_cuda10_1_cudnn7_py3_NO_AVX_NO_AVX2_test (2/4)

Step: "Test" (full log | pattern match details) ❄️

Feb 27 00:59:09 ConnectionResetError: [Errno 104] Connection reset by peer

Feb 27 00:59:09   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 455, in accept 
Feb 27 00:59:09     deliver_challenge(c, self._authkey) 
Feb 27 00:59:09   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 722, in deliver_challenge 
Feb 27 00:59:09     response = connection.recv_bytes(256)        # reject large message 
Feb 27 00:59:09   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 216, in recv_bytes 
Feb 27 00:59:09     buf = self._recv_bytes(maxlength) 
Feb 27 00:59:09   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes 
Feb 27 00:59:09     buf = self._recv(4) 
Feb 27 00:59:09   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 379, in _recv 
Feb 27 00:59:09     chunk = read(handle, remaining) 
Feb 27 00:59:09 ConnectionResetError: [Errno 104] Connection reset by peer 
Feb 27 00:59:09 /opt/conda/lib/python3.6/multiprocessing/semaphore_tracker.py:143: UserWarning: semaphore_tracker: There appear to be 14 leaked semaphores to clean up at shutdown 
Feb 27 00:59:09   len(cache)) 
Feb 27 00:59:12 Process ErrorTrackingProcess-126: 
Feb 27 00:59:12 Traceback (most recent call last): 
Feb 27 00:59:12   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 258, in _bootstrap 
Feb 27 00:59:12     self.run() 
Feb 27 00:59:12   File "/var/lib/jenkins/workspace/test/test_dataloader.py", line 333, in run 
Feb 27 00:59:12     super(ErrorTrackingProcess, self).run() 
Feb 27 00:59:12   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 93, in run 
Feb 27 00:59:12     self._target(*self._args, **self._kwargs)

pytorch_linux_xenial_cuda10_1_cudnn7_py3_gcc7_test (3/4)

Step: "Test" (full log | pattern match details) ❄️

Feb 27 00:59:16 ConnectionResetError: [Errno 104] Connection reset by peer

Feb 27 00:59:16   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 493, in Client 
Feb 27 00:59:16     answer_challenge(c, authkey) 
Feb 27 00:59:16   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 732, in answer_challenge 
Feb 27 00:59:16     message = connection.recv_bytes(256)         # reject large message 
Feb 27 00:59:16   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 216, in recv_bytes 
Feb 27 00:59:16     buf = self._recv_bytes(maxlength) 
Feb 27 00:59:16   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes 
Feb 27 00:59:16     buf = self._recv(4) 
Feb 27 00:59:16   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 379, in _recv 
Feb 27 00:59:16     chunk = read(handle, remaining) 
Feb 27 00:59:16 ConnectionResetError: [Errno 104] Connection reset by peer 
Feb 27 00:59:16  
Feb 27 00:59:16 Process ErrorTrackingProcess-120: 
Feb 27 00:59:16 Traceback (most recent call last): 
Feb 27 00:59:16   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 258, in _bootstrap 
Feb 27 00:59:16     self.run() 
Feb 27 00:59:16   File "/var/lib/jenkins/workspace/test/test_dataloader.py", line 333, in run 
Feb 27 00:59:16     super(ErrorTrackingProcess, self).run() 
Feb 27 00:59:16   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 93, in run 
Feb 27 00:59:16     self._target(*self._args, **self._kwargs) 
Feb 27 00:59:16   File "/var/lib/jenkins/workspace/test/test_dataloader.py", line 601, in _test_proper_exit

pytorch_linux_xenial_cuda10_1_cudnn7_py3_NO_AVX2_test (4/4)

Step: "Test" (full log | pattern match details) ❄️

Feb 27 00:59:45 ConnectionResetError: [Errno 104] Connection reset by peer

Feb 27 00:59:45   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 455, in accept 
Feb 27 00:59:45     deliver_challenge(c, self._authkey) 
Feb 27 00:59:45   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 722, in deliver_challenge 
Feb 27 00:59:45     response = connection.recv_bytes(256)        # reject large message 
Feb 27 00:59:45   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 216, in recv_bytes 
Feb 27 00:59:45     buf = self._recv_bytes(maxlength) 
Feb 27 00:59:45   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 407, in _recv_bytes 
Feb 27 00:59:45     buf = self._recv(4) 
Feb 27 00:59:45   File "/opt/conda/lib/python3.6/multiprocessing/connection.py", line 379, in _recv 
Feb 27 00:59:45     chunk = read(handle, remaining) 
Feb 27 00:59:45 ConnectionResetError: [Errno 104] Connection reset by peer 
Feb 27 00:59:45 /opt/conda/lib/python3.6/multiprocessing/semaphore_tracker.py:143: UserWarning: semaphore_tracker: There appear to be 14 leaked semaphores to clean up at shutdown 
Feb 27 00:59:45   len(cache)) 
Feb 27 00:59:49 Process ErrorTrackingProcess-126: 
Feb 27 00:59:49 Traceback (most recent call last): 
Feb 27 00:59:49   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 258, in _bootstrap 
Feb 27 00:59:49     self.run() 
Feb 27 00:59:49   File "/var/lib/jenkins/workspace/test/test_dataloader.py", line 333, in run 
Feb 27 00:59:49     super(ErrorTrackingProcess, self).run() 
Feb 27 00:59:49   File "/opt/conda/lib/python3.6/multiprocessing/process.py", line 93, in run 
Feb 27 00:59:49     self._target(*self._args, **self._kwargs)

This comment was automatically generated by Dr. CI (expand for details).

Follow this link to opt-out of these comments for your Pull Requests.

Please report bugs/suggestions on the GitHub issue tracker.

This comment has been revised 40 times.

vishwakftw · 2020-02-24T22:33:58Z

+            # type: (Tensor) -> Tuple[Tensor, Tensor, Tensor]
+            return torch.lu(x, get_infos=True)
+
+        self.checkScript(lu, (torch.randn(2, 3, 3),))


nit: this should've been lu_infos?

Fix for #33381, partial fix of #30786 Differential Revision: [D20077321](https://our.internmc.facebook.com/intern/diff/D20077321) [ghstack-poisoned]

ghstack-source-id: a4a0ecd Pull Request resolved: #33724

vishwakftw

Looks good to me, thanks!

Fix for #33381, partial fix of #30786 Differential Revision: [D20077321](https://our.internmc.facebook.com/intern/diff/D20077321) [ghstack-poisoned]

ghstack-source-id: 80a1679 Pull Request resolved: #33724

Fix for #33381, partial fix of #30786 Differential Revision: [D20077321](https://our.internmc.facebook.com/intern/diff/D20077321) [ghstack-poisoned]

facebook-github-bot · 2020-02-27T03:23:53Z

@eellison merged this pull request in 4543cf4.

Summary: Pull Request resolved: #33724 Fix for #33381, partial fix of #30786 Test Plan: Imported from OSS Differential Revision: D20077321 Pulled By: eellison fbshipit-source-id: a1e6a0370712b36c9f66979098ac2f9d500ca5f6

Summary: Pull Request resolved: pytorch#33724 Fix for pytorch#33381, partial fix of pytorch#30786 Test Plan: Imported from OSS Differential Revision: D20077321 Pulled By: eellison fbshipit-source-id: a1e6a0370712b36c9f66979098ac2f9d500ca5f6

add support for torch.lu to torchscript

48ce022

[ghstack-poisoned]

eellison requested a review from apaszke as a code owner February 24, 2020 21:40

eellison mentioned this pull request Feb 24, 2020

[JIT] fix resolving of functions in torch/functional. fix compilation of torch.stft #33504

Closed

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Feb 24, 2020

eellison changed the title ~~add support for torch.lu to torchscript~~ [JIT] add support for torch.lu to torchscript Feb 24, 2020

eellison requested review from driazati and vishwakftw February 24, 2020 21:43

vishwakftw reviewed Feb 24, 2020

View reviewed changes

Update on "[JIT] add support for torch.lu to torchscript"

83bbcb9

Fix for #33381, partial fix of #30786 Differential Revision: [D20077321](https://our.internmc.facebook.com/intern/diff/D20077321) [ghstack-poisoned]

eellison pushed a commit that referenced this pull request Feb 24, 2020

add support for torch.lu to torchscript

d2e4974

ghstack-source-id: a4a0ecd Pull Request resolved: #33724

vishwakftw approved these changes Feb 24, 2020

View reviewed changes

Update on "[JIT] add support for torch.lu to torchscript"

c36ed79

Fix for #33381, partial fix of #30786 Differential Revision: [D20077321](https://our.internmc.facebook.com/intern/diff/D20077321) [ghstack-poisoned]

eellison pushed a commit that referenced this pull request Feb 25, 2020

add support for torch.lu to torchscript

bf9d65c

ghstack-source-id: 80a1679 Pull Request resolved: #33724

This was referenced Feb 25, 2020

[JIT] add support for lu_unpack #33736

Closed

[JIT] add support for torch.cdist #33737

Closed

[JIT] add support for torch.norm #33783

Closed

Update on "[JIT] add support for torch.lu to torchscript"

8acbe8a

Fix for #33381, partial fix of #30786 Differential Revision: [D20077321](https://our.internmc.facebook.com/intern/diff/D20077321) [ghstack-poisoned]

eellison mentioned this pull request Feb 26, 2020

[JIT] Add support for list() #33818

Closed

eellison added 3 commits February 26, 2020 10:34

Update on "[JIT] add support for torch.lu to torchscript"

6fb41f9

Fix for #33381, partial fix of #30786 Differential Revision: [D20077321](https://our.internmc.facebook.com/intern/diff/D20077321) [ghstack-poisoned]

Update on "[JIT] add support for torch.lu to torchscript"

777604f

Fix for #33381, partial fix of #30786 Differential Revision: [D20077321](https://our.internmc.facebook.com/intern/diff/D20077321) [ghstack-poisoned]

Update on "[JIT] add support for torch.lu to torchscript"

c403245

Fix for #33381, partial fix of #30786 Differential Revision: [D20077321](https://our.internmc.facebook.com/intern/diff/D20077321) [ghstack-poisoned]

facebook-github-bot closed this in 4543cf4 Feb 27, 2020

facebook-github-bot added the merged label Feb 27, 2020

facebook-github-bot deleted the gh/eellison/55/head branch March 1, 2020 15:17

mruberry added the Merged label Oct 28, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JIT] add support for torch.lu to torchscript#33724

[JIT] add support for torch.lu to torchscript#33724
eellison wants to merge 7 commits intogh/eellison/55/basefrom
gh/eellison/55/head

eellison commented Feb 24, 2020 •

edited

Loading

Uh oh!

dr-ci Bot commented Feb 24, 2020 •

edited

Loading

Uh oh!

vishwakftw Feb 24, 2020

Uh oh!

vishwakftw left a comment

Uh oh!

facebook-github-bot commented Feb 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

eellison commented Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dr-ci Bot commented Feb 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💊 CircleCI build failures summary and remediations

Detailed failure analysis

🕵️ 5 new failures recognized by patterns

pytorch_macos_10_13_py3_test (1/5)

pytorch_linux_xenial_py3_6_gcc5_4_test (2/5)

pytorch_windows_vs2019_py36_cuda10.1_test2 (3/5)

pytorch_linux_xenial_cuda10_1_cudnn7_py3_nogpu_test (4/5)

pytorch_linux_xenial_py3_clang5_asan_test (5/5)

❄️ 4 failures recognized as flaky

caffe2_onnx_py3_6_clang7_ubuntu16_04_test (1/4)

pytorch_linux_xenial_cuda10_1_cudnn7_py3_NO_AVX_NO_AVX2_test (2/4)

pytorch_linux_xenial_cuda10_1_cudnn7_py3_gcc7_test (3/4)

pytorch_linux_xenial_cuda10_1_cudnn7_py3_NO_AVX2_test (4/4)

Uh oh!

vishwakftw Feb 24, 2020

Choose a reason for hiding this comment

Uh oh!

vishwakftw left a comment

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Feb 27, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eellison commented Feb 24, 2020 •

edited

Loading

dr-ci Bot commented Feb 24, 2020 •

edited

Loading