Add channels last support to cuda.comm.scatter and gather by VitalyFedyunin · Pull Request #28077 · pytorch/pytorch

VitalyFedyunin · 2019-10-16T14:08:29Z

Stack from ghstack:

[WIP] Experiments #29461 [WIP] Experiments
[WIP] Switch default of clone, to, *_like ops #29460 [WIP] Switch default of clone, to, *_like ops
[WIP] Prepare copy op to switch memory format preservation defaults #29459 [WIP] Prepare copy op to switch memory format preservation defaults
Adding function to convert Module to channels last #28991 Adding function to convert Module to channels last
Add torch.memory_format support to the TorchScript #28544 Add torch.memory_format support to the TorchScript
Add memory format support to the resize_ op. #28292 Add memory format support to the resize_ op.
TensroIterator preserve format for binary, ternary operators. #28291 TensroIterator preserve format for binary, ternary operators.
Add channels last support to cuda.comm.scatter and gather #28077 Add channels last support to cuda.comm.scatter and gather
Kill operator== of TensorOptions as confusing one #28076 Kill operator== of TensorOptions as confusing one
Add memory format support to resize_as_ operator #27979 Add memory format support to resize_as_ operator

Differential Revision: D17980305

[ghstack-poisoned]

ghstack-source-id: 97a15ed Pull Request resolved: #28077

…mm.scatter and gather" [ghstack-poisoned]

… and gather" [ghstack-poisoned]

ghstack-source-id: 235ddbc Pull Request resolved: #28077

… and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

ghstack-source-id: 0fedefd Pull Request resolved: #28077

Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

… and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

…ter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

…to cuda.comm.scatter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

…"Add channels last support to cuda.comm.scatter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

….scatter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

…pport to cuda.comm.scatter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

…nd gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

…catter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

… gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

…ter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

…her" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

…ather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

…mm.scatter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

… gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

…r and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

facebook-github-bot · 2019-11-18T14:03:38Z

@VitalyFedyunin merged this pull request in b80c4f6.

ghstack-source-id: dd4bc90 Pull Request resolved: pytorch/pytorch#28077

Add channels last support to cuda.comm.scatter and gather

b893df9

[ghstack-poisoned]

VitalyFedyunin added a commit that referenced this pull request Oct 16, 2019

Add channels last support to cuda.comm.scatter and gather

4a74f65

ghstack-source-id: 97a15ed Pull Request resolved: #28077

Fixing casting ops and tests on "Add channels last support to cuda.co…

3d34fbc

…mm.scatter and gather" [ghstack-poisoned]

Rebasing to master on "Add channels last support to cuda.comm.scatter…

88b6530

… and gather" [ghstack-poisoned]

VitalyFedyunin added a commit that referenced this pull request Oct 17, 2019

Add channels last support to cuda.comm.scatter and gather

8cb3f98

ghstack-source-id: 235ddbc Pull Request resolved: #28077

Rebasing to master on "Add channels last support to cuda.comm.scatter…

dd010ad

… and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

VitalyFedyunin added a commit that referenced this pull request Oct 17, 2019

Add channels last support to cuda.comm.scatter and gather

c33133c

ghstack-source-id: 0fedefd Pull Request resolved: #28077

This was referenced Oct 18, 2019

TensroIterator preserve format for binary, ternary operators. #28291

Closed

Add memory format support to the resize_ op. #28292

Closed

VitalyFedyunin added 6 commits October 18, 2019 10:21

Update on "Add channels last support to cuda.comm.scatter and gather"

20111ef

Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

Fix rand_like test on "Add channels last support to cuda.comm.scatter…

3889df1

… and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

Fix resize_as_ linter on "Add channels last support to cuda.comm.scat…

5dee5be

…ter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

Fix onnx on "Add channels last support to cuda.comm.scatter and gather"

2a7cbf1

Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

Rebase on "Add channels last support to cuda.comm.scatter and gather"

611907d

Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

randn_like not simple mapable any more on "Add channels last support …

c5e6fb4

…to cuda.comm.scatter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

VitalyFedyunin mentioned this pull request Oct 23, 2019

Add torch.memory_format support to the TorchScript #28544

Closed

randn_like mappable again and supported in jit with memory format on …

e42b9a8

…"Add channels last support to cuda.comm.scatter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

fix bc test for empty_like on "Add channels last support to cuda.comm…

addad76

….scatter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

VitalyFedyunin mentioned this pull request Oct 24, 2019

WIP_FIXING_FUSER #28591

Closed

fix bc test for empty_like now with gradient on "Add channels last su…

62e8b2c

…pport to cuda.comm.scatter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

VitalyFedyunin mentioned this pull request Oct 24, 2019

Channels Last (NHWC) support plan. #28619

Open

18 tasks

rebase to master on "Add channels last support to cuda.comm.scatter a…

f8ded0c

…nd gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

VitalyFedyunin mentioned this pull request Oct 31, 2019

Adding function to convert Module to channels last #28991

Closed

VitalyFedyunin added 2 commits November 4, 2019 12:00

add TensroIterator tests on "Add channels last support to cuda.comm.s…

15bd159

…catter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

Add some tests on "Add channels last support to cuda.comm.scatter and…

65f5db9

… gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

This was referenced Nov 8, 2019

[WIP] Prepare copy op to switch memory format preservation defaults #29459

Closed

[WIP] Switch default of clone, to, *_like ops #29460

Closed

[WIP] Experiments #29461

Closed

VitalyFedyunin requested review from gchanan and ifedan November 8, 2019 18:20

VitalyFedyunin added 2 commits November 8, 2019 10:23

Addressed PR feedback on "Add channels last support to cuda.comm.scat…

1c1cfa3

…ter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

Linter fix on "Add channels last support to cuda.comm.scatter and gat…

b2bcfc1

…her" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

VitalyFedyunin requested a review from ezyang November 11, 2019 17:20

Fix Autograd on "Add channels last support to cuda.comm.scatter and g…

aed8549

…ather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

VitalyFedyunin requested a review from ngimel November 11, 2019 23:04

gchanan approved these changes Nov 11, 2019

View reviewed changes

VitalyFedyunin added 5 commits November 11, 2019 16:38

Fix resize_as_ with new test on "Add channels last support to cuda.co…

2ced5bb

…mm.scatter and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

Fix resize_as_ on "Add channels last support to cuda.comm.scatter and…

fdcf253

… gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

Add resize_as_ docs on "Add channels last support to cuda.comm.scatte…

4f619dc

…r and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

fix resize_as_ docs on "Add channels last support to cuda.comm.scatte…

1d381d7

…r and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

fix resize_as_ docs on "Add channels last support to cuda.comm.scatte…

58e06c2

…r and gather" Differential Revision: [D17980305](https://our.internmc.facebook.com/intern/diff/D17980305) [ghstack-poisoned]

facebook-github-bot closed this in b80c4f6 Nov 18, 2019

facebook-github-bot added the merged label Nov 18, 2019

facebook-github-bot deleted the gh/VitalyFedyunin/16/head branch November 21, 2019 15:16

mruberry added the Merged label Oct 28, 2020

karansachdev-1012 pushed a commit to karansachdev-1012/pytorch that referenced this pull request Feb 17, 2026

Add channels last support to cuda.comm.scatter and gather

b50b76f

ghstack-source-id: dd4bc90 Pull Request resolved: pytorch/pytorch#28077

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add channels last support to cuda.comm.scatter and gather#28077

Add channels last support to cuda.comm.scatter and gather#28077
VitalyFedyunin wants to merge 24 commits intogh/VitalyFedyunin/16/basefrom
gh/VitalyFedyunin/16/head

VitalyFedyunin commented Oct 16, 2019 •

edited

Loading

Uh oh!

facebook-github-bot commented Nov 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

VitalyFedyunin commented Oct 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Nov 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VitalyFedyunin commented Oct 16, 2019 •

edited

Loading