Kill `operator==` of TensorOptions as confusing one by VitalyFedyunin · Pull Request #28076 · pytorch/pytorch

VitalyFedyunin · 2019-10-16T14:08:21Z

Stack from ghstack:

[WIP] Experiments #29461 [WIP] Experiments
[WIP] Switch default of clone, to, *_like ops #29460 [WIP] Switch default of clone, to, *_like ops
[WIP] Prepare copy op to switch memory format preservation defaults #29459 [WIP] Prepare copy op to switch memory format preservation defaults
Adding function to convert Module to channels last #28991 Adding function to convert Module to channels last
Add torch.memory_format support to the TorchScript #28544 Add torch.memory_format support to the TorchScript
Add memory format support to the resize_ op. #28292 Add memory format support to the resize_ op.
TensroIterator preserve format for binary, ternary operators. #28291 TensroIterator preserve format for binary, ternary operators.
Add channels last support to cuda.comm.scatter and gather #28077 Add channels last support to cuda.comm.scatter and gather
Kill operator== of TensorOptions as confusing one #28076 Kill operator== of TensorOptions as confusing one
Add memory format support to resize_as_ operator #27979 Add memory format support to resize_as_ operator

Differential Revision: D17980306

[ghstack-poisoned]

…s confusing one" [ghstack-poisoned]

…g one" [ghstack-poisoned]

…g one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

…g one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

…sing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

…rOptions as confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

…"Kill `operator==` of TensorOptions as confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

…confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

… TensorOptions as confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

…one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

…nfusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

…sing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

…s confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

…ng one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

facebook-github-bot · 2019-11-18T14:03:36Z

@VitalyFedyunin merged this pull request in 026a2a4.

Summary: Pull Request resolved: pytorch/pytorch#28076 Test Plan: Imported from OSS Differential Revision: D17980306 Pulled By: VitalyFedyunin fbshipit-source-id: 2f206d5069ce0bd828d4e96f2e98cf2baa1dfec7

ghstack-source-id: d8847c9 Pull Request resolved: pytorch/pytorch#28076

Kill operator== of TensorOptions as confusing one

1f2ee45

[ghstack-poisoned]

VitalyFedyunin added 3 commits October 17, 2019 07:59

Fixing casting ops and tests on "Kill operator== of TensorOptions a…

b8ae9d5

…s confusing one" [ghstack-poisoned]

Rebasing to master on "Kill operator== of TensorOptions as confusin…

dfa3f62

…g one" [ghstack-poisoned]

Rebasing to master on "Kill operator== of TensorOptions as confusin…

b111263

…g one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

This was referenced Oct 18, 2019

TensroIterator preserve format for binary, ternary operators. #28291

Closed

Add memory format support to the resize_ op. #28292

Closed

VitalyFedyunin added 6 commits October 18, 2019 10:21

Update on "Kill operator== of TensorOptions as confusing one"

3728609

Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Fix rand_like test on "Kill operator== of TensorOptions as confusin…

5bbf095

…g one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Fix resize_as_ linter on "Kill operator== of TensorOptions as confu…

d0d57a2

…sing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Fix onnx on "Kill operator== of TensorOptions as confusing one"

aba97c9

Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Rebase on "Kill operator== of TensorOptions as confusing one"

26c8cfd

Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

randn_like not simple mapable any more on "Kill operator== of Tenso…

5240801

…rOptions as confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

VitalyFedyunin mentioned this pull request Oct 23, 2019

Add torch.memory_format support to the TorchScript #28544

Closed

VitalyFedyunin added 2 commits October 23, 2019 15:47

randn_like mappable again and supported in jit with memory format on …

f83cdb4

…"Kill `operator==` of TensorOptions as confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

fix bc test for empty_like on "Kill operator== of TensorOptions as …

83d3946

…confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

VitalyFedyunin mentioned this pull request Oct 24, 2019

WIP_FIXING_FUSER #28591

Closed

VitalyFedyunin added 2 commits October 24, 2019 12:32

fix bc test for empty_like now with gradient on "Kill operator== of…

5f0dfaf

… TensorOptions as confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

rebase to master on "Kill operator== of TensorOptions as confusing …

7369eda

…one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

VitalyFedyunin mentioned this pull request Oct 31, 2019

Adding function to convert Module to channels last #28991

Closed

VitalyFedyunin added 2 commits November 4, 2019 12:00

add TensroIterator tests on "Kill operator== of TensorOptions as co…

cd58e18

…nfusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Add some tests on "Kill operator== of TensorOptions as confusing one"

adb4465

Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

This was referenced Nov 8, 2019

[WIP] Prepare copy op to switch memory format preservation defaults #29459

Closed

[WIP] Switch default of clone, to, *_like ops #29460

Closed

[WIP] Experiments #29461

Closed

VitalyFedyunin requested a review from ezyang November 8, 2019 18:20

Addressed PR feedback on "Kill operator== of TensorOptions as confu…

a835dda

…sing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

ezyang approved these changes Nov 10, 2019

View reviewed changes

VitalyFedyunin added 6 commits November 11, 2019 14:15

Fix Autograd on "Kill operator== of TensorOptions as confusing one"

d977e31

Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Fix resize_as_ with new test on "Kill operator== of TensorOptions a…

cc5faa9

…s confusing one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Fix resize_as_ on "Kill operator== of TensorOptions as confusing one"

410bc79

Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

Add resize_as_ docs on "Kill operator== of TensorOptions as confusi…

b8d615e

…ng one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

fix resize_as_ docs on "Kill operator== of TensorOptions as confusi…

2f85620

…ng one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

fix resize_as_ docs on "Kill operator== of TensorOptions as confusi…

0f5b0de

…ng one" Differential Revision: [D17980306](https://our.internmc.facebook.com/intern/diff/D17980306) [ghstack-poisoned]

facebook-github-bot closed this in 026a2a4 Nov 18, 2019

facebook-github-bot added the merged label Nov 18, 2019

facebook-github-bot deleted the gh/VitalyFedyunin/15/head branch November 21, 2019 15:16

mruberry added the Merged label Oct 28, 2020

karansachdev-1012 pushed a commit to karansachdev-1012/pytorch that referenced this pull request Feb 17, 2026

Kill operator== of TensorOptions as confusing one

25343a5

ghstack-source-id: d8847c9 Pull Request resolved: pytorch/pytorch#28076

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Kill `operator==` of TensorOptions as confusing one#28076

Kill `operator==` of TensorOptions as confusing one#28076
VitalyFedyunin wants to merge 23 commits intogh/VitalyFedyunin/15/basefrom
gh/VitalyFedyunin/15/head

VitalyFedyunin commented Oct 16, 2019 •

edited

Loading

Uh oh!

facebook-github-bot commented Nov 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

VitalyFedyunin commented Oct 16, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

facebook-github-bot commented Nov 18, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

VitalyFedyunin commented Oct 16, 2019 •

edited

Loading