Skip to content

Better named tensor error messages.#26974

Closed
zou3519 wants to merge 2 commits intogh/zou3519/194/basefrom
gh/zou3519/194/head
Closed

Better named tensor error messages.#26974
zou3519 wants to merge 2 commits intogh/zou3519/194/basefrom
gh/zou3519/194/head

Conversation

@zou3519
Copy link
Copy Markdown
Contributor

@zou3519 zou3519 commented Sep 27, 2019

Stack from ghstack:

Suggest Tensor.rename to rename tensors and/or drop names on named
tensors.

Test Plan:

  • [namedtensor ci]

Differential Revision: D17628950

Suggest `Tensor.rename` to rename tensors and/or drop names on named
tensors.

Test Plan:
- [namedtensor ci]
@zou3519 zou3519 requested a review from apaszke as a code owner September 27, 2019 15:59
@pytorchbot pytorchbot added oncall: jit Add this issue/PR to JIT oncall triage queue module: internals Related to internal abstractions in c10 and ATen module: pybind Related to our Python bindings / interactions with other Python libraries labels Sep 27, 2019
@zou3519 zou3519 requested review from nairbv and removed request for apaszke September 27, 2019 15:59
@zou3519 zou3519 added this to the 1.3 milestone Sep 27, 2019
Suggest `Tensor.rename` to rename tensors and/or drop names on named
tensors.

Test Plan:
- [namedtensor ci]

Differential Revision: [D17628950](https://our.internmc.facebook.com/intern/diff/D17628950)
zou3519 added a commit that referenced this pull request Sep 27, 2019
Suggest `Tensor.rename` to rename tensors and/or drop names on named
tensors.

Test Plan:
- [namedtensor ci]

ghstack-source-id: 0f0e902
Pull Request resolved: #26974
@facebook-github-bot
Copy link
Copy Markdown
Contributor

@zou3519 merged this pull request in 2904053.

zdevito pushed a commit to zdevito/ATen that referenced this pull request Sep 27, 2019
Summary:
Pull Request resolved: pytorch/pytorch#26974

Suggest `Tensor.rename` to rename tensors and/or drop names on named
tensors.

Test Plan: - [namedtensor ci]

Differential Revision: D17628950

Pulled By: zou3519

fbshipit-source-id: b701f46c46093046691eace698be8282d049d37a
@facebook-github-bot facebook-github-bot deleted the gh/zou3519/194/head branch October 28, 2019 22:24
pdlive215 pushed a commit to pdlive215/pytorch that referenced this pull request Nov 27, 2019
Summary:
Pull Request resolved: pytorch#26974

Suggest `Tensor.rename` to rename tensors and/or drop names on named
tensors.

Test Plan: - [namedtensor ci]

Differential Revision: D17628950

Pulled By: zou3519

fbshipit-source-id: b701f46c46093046691eace698be8282d049d37a
laurentdupin pushed a commit to laurentdupin/pytorch that referenced this pull request Apr 24, 2026
Summary:
Pull Request resolved: pytorch#26974

Suggest `Tensor.rename` to rename tensors and/or drop names on named
tensors.

Test Plan: - [namedtensor ci]

Differential Revision: D17628950

Pulled By: zou3519

fbshipit-source-id: b701f46c46093046691eace698be8282d049d37a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Merged module: internals Related to internal abstractions in c10 and ATen module: pybind Related to our Python bindings / interactions with other Python libraries oncall: jit Add this issue/PR to JIT oncall triage queue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants