Named tensor support for: index_fill_, index_fill, squeeze, median(Tensor)#26914
Closed
zou3519 wants to merge 5 commits intogh/zou3519/192/basefrom
Closed
Named tensor support for: index_fill_, index_fill, squeeze, median(Tensor)#26914zou3519 wants to merge 5 commits intogh/zou3519/192/basefrom
zou3519 wants to merge 5 commits intogh/zou3519/192/basefrom
Conversation
…nsor) Also added dimname overloads for index_fill_ and squeeze. Test Plan: - [namedtensor ci]
nairbv
reviewed
Sep 26, 2019
| } | ||
|
|
||
| #ifdef BUILD_NAMEDTENSOR | ||
| optional<std::vector<Dimname>> inferSqueezeNames(const Tensor& tensor) { |
Collaborator
There was a problem hiding this comment.
should this be in NamedTensorUtils.cpp?
nairbv
approved these changes
Sep 26, 2019
…, median(Tensor)" Also added dimname overloads for index_fill_ and squeeze. Test Plan: - [namedtensor ci] Differential Revision: [D17609136](https://our.internmc.facebook.com/intern/diff/D17609136)
…, median(Tensor)" Also added dimname overloads for index_fill_ and squeeze. Test Plan: - [namedtensor ci] Differential Revision: [D17609136](https://our.internmc.facebook.com/intern/diff/D17609136)
…, median(Tensor)" Also added dimname overloads for index_fill_ and squeeze. Test Plan: - [namedtensor ci] Differential Revision: [D17609136](https://our.internmc.facebook.com/intern/diff/D17609136)
…, median(Tensor)" Also added dimname overloads for index_fill_ and squeeze. Test Plan: - [namedtensor ci] Differential Revision: [D17609136](https://our.internmc.facebook.com/intern/diff/D17609136)
This was referenced Sep 27, 2019
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 27, 2019
…nsor) (#26914) Summary: Pull Request resolved: pytorch/pytorch#26914 Also added dimname overloads for index_fill_ and squeeze. Test Plan: - [namedtensor ci] Differential Revision: D17609136 Pulled By: zou3519 fbshipit-source-id: 29c7ad52ffe24e0b3ad679111fee7a78eca7acdf
pdlive215
pushed a commit
to pdlive215/pytorch
that referenced
this pull request
Nov 27, 2019
…nsor) (pytorch#26914) Summary: Pull Request resolved: pytorch#26914 Also added dimname overloads for index_fill_ and squeeze. Test Plan: - [namedtensor ci] Differential Revision: D17609136 Pulled By: zou3519 fbshipit-source-id: 29c7ad52ffe24e0b3ad679111fee7a78eca7acdf
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
…nsor) (pytorch#26914) Summary: Pull Request resolved: pytorch#26914 Also added dimname overloads for index_fill_ and squeeze. Test Plan: - [namedtensor ci] Differential Revision: D17609136 Pulled By: zou3519 fbshipit-source-id: 29c7ad52ffe24e0b3ad679111fee7a78eca7acdf
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Also added dimname overloads for index_fill_ and squeeze.
Test Plan:
Differential Revision: D17609136