Remove GCC4 from CI#26522
Closed
smessmer wants to merge 14 commits intogh/smessmer/54/basefrom
Closed
Conversation
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
This was referenced Sep 20, 2019
Closed
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
Closed
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
This was referenced Sep 22, 2019
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
ezyang
approved these changes
Sep 25, 2019
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. Differential Revision: [D17494507](https://our.internmc.facebook.com/intern/diff/D17494507/) [ghstack-poisoned]
Merged
Contributor
|
This pull request has been merged in 5321f45. |
thiagocrepaldi
pushed a commit
to thiagocrepaldi/pytorch
that referenced
this pull request
Feb 4, 2020
Summary: Pull Request resolved: pytorch#26522 Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. ghstack-source-id: 91851144 Test Plan: unit tests Differential Revision: D17494507 fbshipit-source-id: 7c0beb5e532ad9caa5cb02c1af26341c1017ff57
laurentdupin
pushed a commit
to laurentdupin/pytorch
that referenced
this pull request
Apr 24, 2026
Summary: Pull Request resolved: pytorch#26522 Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore. This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids. ghstack-source-id: 91851144 Test Plan: unit tests Differential Revision: D17494507 fbshipit-source-id: 7c0beb5e532ad9caa5cb02c1af26341c1017ff57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Our binaries are already built using GCC5, so there is no reason to test for GCC4 anymore.
This is an important prerequisite for switching to C++14, but even without the C++14 switch, this enables a gcc feature that I need for constexpr type ids.
Differential Revision: D17494507