[wip] Switch to C++14#27864
Merged
smessmer merged 16 commits intogh/smessmer/72/basefrom Nov 25, 2019
Merged
Conversation
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
Closed
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Oct 14, 2019
Pull Request resolved: #27864 ghstack-source-id: 91872594 Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/)
soumith
approved these changes
Oct 14, 2019
Collaborator
soumith
left a comment
There was a problem hiding this comment.
conditional on CI passing.
@peterjc123 anything to know about C++14 and Windows incompatibility, now is the time to speak :)
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Oct 14, 2019
Pull Request resolved: #27864 ghstack-source-id: 91896396 Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/)
Collaborator
bddppq
reviewed
Oct 16, 2019
| list(APPEND HIP_CXX_FLAGS -Wno-duplicate-decl-specifier) | ||
| list(APPEND HIP_CXX_FLAGS -DCAFFE2_USE_MIOPEN) | ||
| list(APPEND HIP_CXX_FLAGS -DTHRUST_DEVICE_SYSTEM=THRUST_DEVICE_SYSTEM_HIP) | ||
| list(APPEND HIP_CXX_FLAGS -std=gnu++14) |
Contributor
There was a problem hiding this comment.
-std=gnu++14 -> -std=c++14, hcc doesn't support gnu extensions.
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Oct 17, 2019
Pull Request resolved: #27864 ghstack-source-id: 92081119 Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/)
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
Closed
smessmer
added a commit
that referenced
this pull request
Oct 17, 2019
Pull Request resolved: #27864 ghstack-source-id: 92086808 Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/)
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Oct 17, 2019
Pull Request resolved: #27864 ghstack-source-id: 92099795 Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/)
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
This was referenced Oct 22, 2019
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
This was referenced Oct 25, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/) [ghstack-poisoned]
smessmer
added a commit
that referenced
this pull request
Nov 25, 2019
Pull Request resolved: #27864 ghstack-source-id: 94519851 Differential Revision: [D17908478](https://our.internmc.facebook.com/intern/diff/D17908478/)
Contributor
Author
|
This is not merged yet, there was an error in the export. Re-created this PR in #30406. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
Differential Revision: D17908478