[TEST] Skip testing triangular_solve_batched on non-default CUDA stream#26115
[TEST] Skip testing triangular_solve_batched on non-default CUDA stream#26115vishwakftw wants to merge 1 commit intopytorch:masterfrom
Conversation
|
@zou3519, it seems like non-default CUDA stream testing caused this to fail. |
|
Sure, let's get this merged and file an issue for triangular_solve not working on non-default stream. Thank you for investigating! edit: sorry, do you think that the "testing on non-default stream" is broken, or that triangular solve gives in correct behavior doesn't support non-default stream? |
|
|
||
| @unittest.skipIf(not TEST_MAGMA, "no MAGMA library detected") | ||
| @unittest.skip("Spuriously failing") | ||
| @skipCUDANonDefaultStreamIf(True) |
There was a problem hiding this comment.
If we're going to skip this we should put a message as to why (i.e., tringular_solve doesn't work with non default stream, or there is something wrong with the non-default stream testing) and link to an issue.
There was a problem hiding this comment.
I believe triangular_solve doesn't work with non-default stream. This is an issue that takes this generally: #21821.
There was a problem hiding this comment.
test_triangular_solve is also skipped in an analogous manner.
|
@vishwakftw just checking, do you want this merged (so that we can prevent regressions) or are you still using this as a testing ground? |
|
This can be merged, but I think that @mruberry’s PR on test refactor may have superseded this. |
|
You can merge as is. |
|
Cool, I'll merge this as is. Thanks for the discussion! |
facebook-github-bot
left a comment
There was a problem hiding this comment.
@zou3519 is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
…orch#26115) Summary: This is for testing purposes. Pull Request resolved: pytorch#26115 Differential Revision: D17433122 Pulled By: zou3519 fbshipit-source-id: bf41327e6141e9ae589fcf18254c2a8cdd868dd7
This is for testing purposes.