-
Notifications
You must be signed in to change notification settings - Fork 27.7k
Stream safety of MAGMA functions #21821
Copy link
Copy link
Closed
Labels
high prioritymodule: internalsRelated to internal abstractions in c10 and ATenRelated to internal abstractions in c10 and ATentriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
Metadata
Metadata
Assignees
Labels
high prioritymodule: internalsRelated to internal abstractions in c10 and ATenRelated to internal abstractions in c10 and ATentriagedThis issue has been looked at a team member, and triaged and prioritized into an appropriate moduleThis issue has been looked at a team member, and triaged and prioritized into an appropriate module
#21785 showed that
at::svd()is not stream-safe.at::svd()usesmagma_dgesdd().According to http://icl.cs.utk.edu/magma/forum/viewtopic.php?f=2&t=1080, the old way of making MAGMA functions stream-safe is:
The new way is using a
magma_queue_t, but not all functions have it. In particularmagma_dgesdd()doesn't appear to have this parameter.I'm not sure if either of these methods can be integrated into
pytorch. Meanwhile, the functions should probably raise an error if a non-default stream is detected.