Align AliasInfo's operator<< with FunctionSchema#23206
Closed
houseroad wants to merge 7 commits intogh/houseroad/9/basefrom
Closed
Align AliasInfo's operator<< with FunctionSchema#23206houseroad wants to merge 7 commits intogh/houseroad/9/basefrom
houseroad wants to merge 7 commits intogh/houseroad/9/basefrom
Conversation
old (a) new (a! -> b) Differential Revision: [D16433909](https://our.internmc.facebook.com/intern/diff/D16433909/)
This was referenced Jul 23, 2019
old (a) new (a! -> b) Differential Revision: [D16433909](https://our.internmc.facebook.com/intern/diff/D16433909/)
old (a) new (a! -> b) Differential Revision: [D16433909](https://our.internmc.facebook.com/intern/diff/D16433909/)
old (a) new (a! -> b) Differential Revision: [D16433909](https://our.internmc.facebook.com/intern/diff/D16433909/)
dzhulgakov
reviewed
Jul 24, 2019
| } | ||
| out << ")"; | ||
|
|
||
| if (!aliasInfo.containedTypes().empty()) { |
Collaborator
There was a problem hiding this comment.
not sure whether removing it makes debugging harder or not. We can also put a separate method to print to string, but @suo is best to decide
old (a) new (a! -> b) Differential Revision: [D16433909](https://our.internmc.facebook.com/intern/diff/D16433909/)
old (a) new (a! -> b) Differential Revision: [D16433909](https://our.internmc.facebook.com/intern/diff/D16433909/)
dzhulgakov
approved these changes
Jul 26, 2019
Collaborator
dzhulgakov
left a comment
There was a problem hiding this comment.
I'm stamping it just to unblock
old (a) new (a! -> b) Differential Revision: [D16433909](https://our.internmc.facebook.com/intern/diff/D16433909/)
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Sep 6, 2019
Summary: old (a) new (a! -> b) Pull Request resolved: pytorch/pytorch#23206 ghstack-source-id: 89570435 Test Plan: cont build and the round trip tests in the last diff Reviewed By: zrphercule Differential Revision: D16433909 fbshipit-source-id: b5b018e839935cccbb1fb446070afd1cb9379bb1
Contributor
|
This pull request has been merged in a294e15. |
xxtEchjovs44
pushed a commit
to xxtEchjovs44/pytorch
that referenced
this pull request
Jan 29, 2020
old (a) new (a! -> b) Pull Request resolved: pytorch/pytorch#23206 ghstack-source-id: 89570435 Differential Revision: [D16433909](https://our.internmc.facebook.com/intern/diff/D16433909/)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
old (a)
new (a! -> b)
Differential Revision: D16433909