expose parse_schema and __eq__ function to python and add round trip tests#23208
Closed
houseroad wants to merge 10 commits intogh/houseroad/11/basefrom
Closed
expose parse_schema and __eq__ function to python and add round trip tests#23208houseroad wants to merge 10 commits intogh/houseroad/11/basefrom
houseroad wants to merge 10 commits intogh/houseroad/11/basefrom
Conversation
…tests expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
This was referenced Jul 23, 2019
houseroad
added a commit
that referenced
this pull request
Jul 23, 2019
…tests expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/) ghstack-source-id: 86986325 Pull Request resolved: #23208
…round trip tests" expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
houseroad
added a commit
that referenced
this pull request
Jul 23, 2019
…tests expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Pull Request resolved: #23208 ghstack-source-id: 86986662 Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
…round trip tests" expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
…round trip tests" expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
houseroad
added a commit
that referenced
this pull request
Jul 23, 2019
…tests expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Pull Request resolved: #23208 ghstack-source-id: 87030728 Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
dzhulgakov
reviewed
Jul 24, 2019
test/test_function_schema.py
Outdated
| from common_utils import TestCase | ||
|
|
||
|
|
||
| class TestSparse(TestCase): |
| @@ -0,0 +1,18 @@ | |||
| from __future__ import absolute_import, division, print_function, unicode_literals | |||
Collaborator
There was a problem hiding this comment.
if you're creating a new file - we should put it into TARGETS and some run_test.py files I think. Otherwise it won't be run in CI. Or just dump it into test_jit.py :)
Member
Author
There was a problem hiding this comment.
I have put it into TARGETS, forgot to add it to run_test.py. Good catch!
…round trip tests" expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
houseroad
added a commit
that referenced
this pull request
Jul 24, 2019
…tests expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Pull Request resolved: #23208 ghstack-source-id: 87125576 Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
dzhulgakov
approved these changes
Jul 25, 2019
Collaborator
dzhulgakov
left a comment
There was a problem hiding this comment.
Looks like you need to fix the doctest here (please do before landing):
pytorch/test/test_docs_coverage.py
Line 46 in 8c927b2
…round trip tests" expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
…round trip tests" expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
…round trip tests" expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
…round trip tests" expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
…round trip tests" expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
houseroad
added a commit
that referenced
this pull request
Sep 6, 2019
…tests expose necessary functions to python, and add round-way tests for function schema str() and parsing functions. We iterate over all the registered function schemas and get the string, then parse the string. We compare the schema generated from parsing with the original one, and make sure they are equal. Pull Request resolved: #23208 ghstack-source-id: 89638026 Differential Revision: [D16435471](https://our.internmc.facebook.com/intern/diff/D16435471/)
Contributor
|
This pull request has been merged in 75cac0f. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
expose necessary functions to python, and add round-way tests for
function schema str() and parsing functions.
We iterate over all the registered function schemas and get the string,
then parse the string. We compare the schema generated from parsing with
the original one, and make sure they are equal.
Differential Revision: D16435471