Mark protobuf include path as system include#23012
Closed
bddppq wants to merge 1 commit intopytorch:masterfrom
Closed
Mark protobuf include path as system include#23012bddppq wants to merge 1 commit intopytorch:masterfrom
bddppq wants to merge 1 commit intopytorch:masterfrom
Conversation
b640f4b to
90d53a8
Compare
To suppress compiler warnings from protobuf headers [ci all]
90d53a8 to
22c2c0e
Compare
Collaborator
|
I think it might be better to try to upgrade protobuf first, but the codebase does not seem to work with the latest protobuf. See #22595 |
Contributor
Author
Contributor
Author
|
conda CI have passed |
pjh5
approved these changes
Jul 18, 2019
Contributor
Author
|
@xuhdev Any concerns on me landing this PR before the protobuf upgrade? |
Contributor
|
@bddppq It doesn't look like this breaks anything, so I have no concerns. This looks like a good change regardless of the protobuf version. I'd land now. |
Collaborator
|
I have no real concerns at this point of time. |
Contributor
facebook-github-bot
left a comment
There was a problem hiding this comment.
@bddppq is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Jul 18, 2019
Summary: To suppress (many) compiler warnings from protobuf headers Pull Request resolved: pytorch/pytorch#23012 Differential Revision: D16364573 Pulled By: bddppq fbshipit-source-id: adbc4921e29389131d43e7bcc1e6fcba19450c76
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To suppress (many) compiler warnings from protobuf headers