Skip to content

[WIP] Update protobuf submodule.#22595

Closed
xuhdev wants to merge 1 commit intopytorch:masterfrom
xuhdev:update-probuf
Closed

[WIP] Update protobuf submodule.#22595
xuhdev wants to merge 1 commit intopytorch:masterfrom
xuhdev:update-probuf

Conversation

@xuhdev
Copy link
Collaborator

@xuhdev xuhdev commented Jul 8, 2019

A build issue on Raspberry Pi (arm) that affects PyTorch was fixed only
recently:

Close #22564

@xuhdev xuhdev requested a review from bddppq July 8, 2019 20:30
@li-roy li-roy added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 10, 2019
@xuhdev xuhdev changed the title Update protobuf submodule. [WIP] Update protobuf submodule. Jul 10, 2019
@pytorchbot pytorchbot added the module: build Build system issues label Jul 10, 2019
@pjh5
Copy link
Contributor

pjh5 commented Jul 18, 2019

It looks like just one test is failing. Maybe we just need to fix the test. @jerryzh168 do you know who knows more about this test?

This is the protobuf that's installed on those btw https://github.com/pytorch/pytorch/blob/master/docker/caffe2/jenkins/common/install_base.sh#L6 . Though ubuntu 16 just installs from apt-get https://github.com/pytorch/pytorch/blob/master/docker/caffe2/jenkins/common/install_base.sh#L58

@xuhdev
Copy link
Collaborator Author

xuhdev commented Jul 24, 2019

@pytorchbot rebase this please

2 similar comments
@xuhdev
Copy link
Collaborator Author

xuhdev commented Jul 30, 2019

@pytorchbot rebase this please

@xuhdev
Copy link
Collaborator Author

xuhdev commented Aug 8, 2019

@pytorchbot rebase this please

@pytorchbot pytorchbot added module: ci Related to continuous integration module: cpp Related to C++ API module: cpu CPU specific problem (e.g., perf, algorithm) module: cuda Related to torch.cuda, and CUDA support in general module: internals Related to internal abstractions in c10 and ATen module: nn Related to torch.nn module: operators labels Aug 8, 2019
@xuhdev xuhdev force-pushed the update-probuf branch 2 times, most recently from 1cbeff9 to 6fb65e6 Compare August 8, 2019 20:45
@xuhdev xuhdev removed module: build Build system issues module: ci Related to continuous integration module: cpp Related to C++ API module: cpu CPU specific problem (e.g., perf, algorithm) module: cuda Related to torch.cuda, and CUDA support in general module: internals Related to internal abstractions in c10 and ATen module: nn Related to torch.nn module: operators labels Aug 8, 2019
@xuhdev
Copy link
Collaborator Author

xuhdev commented Aug 8, 2019

@pytorchbot rebase this please

A build issue on Raspberry Pi that affects PyTorch was fixed only
recently:

- protocolbuffers/protobuf@55ed1d4
- protocolbuffers/protobuf@56e7bdf

Close pytorch#22564
@facebook-github-bot
Copy link
Contributor

Hi @xuhdev!

Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but we do not have a signature on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@pytorchbot
Copy link
Collaborator

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
Stale pull requests will automatically be closed 30 days after being marked Stale

@pytorchbot pytorchbot added Stale and removed Stale labels Apr 12, 2022
@github-actions
Copy link
Contributor

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Jun 11, 2022
@github-actions github-actions bot closed this Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla signed module: third_party open source Stale triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot build Caffe2 while installing Pytorch on Raspbian (buster)

6 participants