Closed
Conversation
Differential Revision: D15476434 Differential Version: 83701491
Closed
Differential Revision: D15476434 Differential Version: 83720045
Differential Revision: D15476434 Differential Version: 83738373
Closed
Contributor
Author
|
This is a re-export of #20870 which seems to have run into some technical git issues |
Contributor
|
This pull request has been merged in 5fcd37b. |
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
May 31, 2019
Summary: Pull Request resolved: pytorch/pytorch#21164 Write a List type to be used in operator kernels. This abstracts away from the concrete list type used (e.g. std::vector vs SmallVector) and allows us to change these implementation details without breaking the kernel API. Also, this class allows for handling List<bool>, which would not work with ArrayRef because vector<bool> is a bitset and can't be converted to ArrayRef<bool>. Reviewed By: ezyang Differential Revision: D15476434 fbshipit-source-id: 5855ae36b45b70437f996c81580f34a4c91ed18c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #21177 Use c10::List 💛
:black_circle: #21164 List 💚
Write a List type to be used in operator kernels. This abstracts away from the concrete list type used (e.g. std::vector vs SmallVector)
and allows us to change these implementation details without breaking the kernel API.
Also, this class allows for handling List, which would not work with ArrayRef because vector is a bitset and can't be converted to ArrayRef.
Differential Revision: D15476434