Closed
Conversation
Differential Revision: D15476434 Differential Version: 82905567
Closed
Differential Revision: D15476434 Differential Version: 82944492
dzhulgakov
approved these changes
May 24, 2019
Collaborator
dzhulgakov
left a comment
There was a problem hiding this comment.
Looks legit (and the C++ boilerplate is looong, hope you copied it from somewhere :) )
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #20871 Use c10::List 💛
:black_circle: #20870 List 💛
:white_circle: #20669 Dict is a reference type 💚
Write a List type to be used in operator kernels. This abstracts away from the concrete list type used (e.g. std::vector vs SmallVector)
and allows us to change these implementation details without breaking the kernel API.
Also, this class allows for handling List, which would not work with ArrayRef because vector is a bitset and can't be converted to ArrayRef.
Differential Revision: D15476434