Consolidate pre-grad pass timing tests into parametrized test#177731
Open
frgossen wants to merge 5 commits intogh/frgossen/15/basefrom
Open
Consolidate pre-grad pass timing tests into parametrized test#177731frgossen wants to merge 5 commits intogh/frgossen/15/basefrom
frgossen wants to merge 5 commits intogh/frgossen/15/basefrom
Conversation
Replace separate test_pre_grad_passes_late_timing, test_pre_grad_passes_early_timing, test_pre_grad_passes_default_timing_with_uuid, and test_pre_grad_passes_default_timing_without_uuid with a single parametrized test_pre_grad_passes_timing that covers all timing/pass combinations. Authored with Claude. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177731
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit aee3673 with merge base e3cc9e6 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Mar 18, 2026
This was referenced Mar 18, 2026
frgossen
added a commit
that referenced
this pull request
Mar 18, 2026
Replace separate test_pre_grad_passes_late_timing, test_pre_grad_passes_early_timing, test_pre_grad_passes_default_timing_with_uuid, and test_pre_grad_passes_default_timing_without_uuid with a single parametrized test_pre_grad_passes_timing that covers all timing/pass combinations. Authored with Claude. ghstack-source-id: e0024d6 Pull Request resolved: #177731
…est" Replace separate test_pre_grad_passes_late_timing, test_pre_grad_passes_early_timing, test_pre_grad_passes_default_timing_with_uuid, and test_pre_grad_passes_default_timing_without_uuid with a single parametrized test_pre_grad_passes_timing that covers all timing/pass combinations. Authored with Claude. [ghstack-poisoned]
frgossen
added a commit
that referenced
this pull request
Mar 18, 2026
Replace separate test_pre_grad_passes_late_timing, test_pre_grad_passes_early_timing, test_pre_grad_passes_default_timing_with_uuid, and test_pre_grad_passes_default_timing_without_uuid with a single parametrized test_pre_grad_passes_timing that covers all timing/pass combinations. Authored with Claude. ghstack-source-id: 4d8c280 Pull Request resolved: #177731
This was referenced Mar 18, 2026
aorenste
reviewed
Mar 18, 2026
Contributor
aorenste
left a comment
There was a problem hiding this comment.
What does this look like from a test running perspective? I'm concerned about the ability to run one of these subtests locally in isolation - does pytest just use a simple string to identify each subtest (like "test_pre_grad_passes_timing_early_custom_pre_grad_pass_remove_ident_muls_wo_uuid_1_2")?
zou3519
approved these changes
Mar 18, 2026
…est" Replace separate test_pre_grad_passes_late_timing, test_pre_grad_passes_early_timing, test_pre_grad_passes_default_timing_with_uuid, and test_pre_grad_passes_default_timing_without_uuid with a single parametrized test_pre_grad_passes_timing that covers all timing/pass combinations. Authored with Claude. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
…est" Replace separate test_pre_grad_passes_late_timing, test_pre_grad_passes_early_timing, test_pre_grad_passes_default_timing_with_uuid, and test_pre_grad_passes_default_timing_without_uuid with a single parametrized test_pre_grad_passes_timing that covers all timing/pass combinations. Authored with Claude. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
Contributor
Author
Yes, you can run them all individually, e.g: |
…est" Replace separate test_pre_grad_passes_late_timing, test_pre_grad_passes_early_timing, test_pre_grad_passes_default_timing_with_uuid, and test_pre_grad_passes_default_timing_without_uuid with a single parametrized test_pre_grad_passes_timing that covers all timing/pass combinations. Authored with Claude. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx kadeng chauhang amjames Lucaskabela jataylo [ghstack-poisoned]
Collaborator
|
Starting merge as part of PR stack under #177733 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Replace separate test_pre_grad_passes_late_timing,
test_pre_grad_passes_early_timing, test_pre_grad_passes_default_timing_with_uuid,
and test_pre_grad_passes_default_timing_without_uuid with a single parametrized
test_pre_grad_passes_timing that covers all timing/pass combinations.
Authored with Claude.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo