Default pre_grad_pass_timing to "late" in fbcode#177690
Default pre_grad_pass_timing to "late" in fbcode#177690frgossen wants to merge 3 commits intogh/frgossen/14/basefrom
Conversation
This ensures pre-grad passes run after cache lookups in Meta-internal builds, avoiding unnecessary pass execution on cache hits. Authored with Claude. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177690
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New Failures, 2 Unrelated FailuresAs of commit 6fb7ee5 with merge base e3cc9e6 ( NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
This ensures pre-grad passes run after cache lookups in Meta-internal builds, avoiding unnecessary pass execution on cache hits. Authored with Claude. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo [ghstack-poisoned]
aorenste
left a comment
There was a problem hiding this comment.
You should either do this from the fbcode side or import into fbcode so we can make sure no internal tests fail before landing.
| pre_grad_pass_timing: Literal["early", "late", "default"] = ( | ||
| "late" if is_fbcode() else "default" | ||
| ) |
There was a problem hiding this comment.
pretty sure I saw this in another PR too :P
There was a problem hiding this comment.
There was a problem hiding this comment.
Sorry about the confusion. Factored this out of the other PR again so that I can test it separately before merging.
This ensures pre-grad passes run after cache lookups in Meta-internal builds, avoiding unnecessary pass execution on cache hits. Authored with Claude. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy kadeng muchulee8 amjames chauhang aakhundov coconutruben jataylo [ghstack-poisoned]
Stack from ghstack (oldest at bottom):
This ensures pre-grad passes run after cache lookups in Meta-internal
builds, avoiding unnecessary pass execution on cache hits.
Authored with Claude.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo