[DTensor] Update dtensor_dispatch_inplace instruction count benchmark#177074
Open
wconstab wants to merge 1 commit intogh/wconstab/563/basefrom
Open
[DTensor] Update dtensor_dispatch_inplace instruction count benchmark#177074wconstab wants to merge 1 commit intogh/wconstab/563/basefrom
wconstab wants to merge 1 commit intogh/wconstab/563/basefrom
Conversation
The expected count for dtensor_dispatch_inplace (add_) regressed from 56530 to 58710 (~3.9%) after #175795 registered single-dim strategies for categorized pointwise ops. The regression is on the cached dispatch path and comes from two sources: an extra dict lookup in the C++ get_runtime_schema_info_for_op (~890 instructions), and a Python heap layout difference in the cached OutputSharding object (~2860 instructions). Both are minor and not particularly worth fixing. While the regression is within the 10% CI noise margin, it's better to reset the counts so we still have our full 10% margin for the future. Authored with Claude. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/177074
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 3 Unrelated FailuresAs of commit 8cf854e with merge base 3f60bc4 ( NEW FAILURE - The following job has failed:
FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wconstab
added a commit
that referenced
this pull request
Mar 10, 2026
The expected count for dtensor_dispatch_inplace (add_) regressed from 56530 to 58710 (~3.9%) after #175795 registered single-dim strategies for categorized pointwise ops. The regression is on the cached dispatch path and comes from two sources: an extra dict lookup in the C++ get_runtime_schema_info_for_op (~890 instructions), and a Python heap layout difference in the cached OutputSharding object (~2860 instructions). Both are minor and not particularly worth fixing. While the regression is within the 10% CI noise margin, it's better to reset the counts so we still have our full 10% margin for the future. Authored with Claude. ghstack-source-id: 1e59629 Pull Request resolved: #177074
Contributor
Author
|
@pytorchbot merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The expected count for dtensor_dispatch_inplace (add_) regressed from
56530 to 58710 (~3.9%) after #175795 registered single-dim strategies
for categorized pointwise ops. The regression is on the cached dispatch
path and comes from two sources: an extra dict lookup in the C++
get_runtime_schema_info_for_op (~890 instructions), and a Python heap
layout difference in the cached OutputSharding object (~2860
instructions). Both are minor and not particularly worth fixing. While
the regression is within the 10% CI noise margin, it's better to reset
the counts so we still have our full 10% margin for the future.
Authored with Claude.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo