[DTensor] Register single-dim strategies for categorized pointwise ops#175795
[DTensor] Register single-dim strategies for categorized pointwise ops#175795anshul-si wants to merge 44 commits intogh/anshul-si/95/basefrom
Conversation
Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/175795
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 5ac45c0 with merge base 4b5eef4 ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. ghstack-source-id: 02e7fb8 Pull Request resolved: #175795
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. ghstack-source-id: 4b66558 Pull Request resolved: #175795
…ointwise ops" Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. [ghstack-poisoned]
Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. ghstack-source-id: 375e46d Pull Request resolved: #175795
|
FYI this adds 7% regression |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchmergebot cancel |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot --help |
PyTorchBot HelpMergeRevertRebaseLabelDr CILintcherry-pick |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
The testcase includes the warm-up step, which is slowed down by the look up time for this strategy. However, subsequent results will be cached, so there shouldn't be an issue here. Will also has #175999 which will make the look up more efficient. |
The expected count for dtensor_dispatch_inplace (add_) regressed from 56530 to 58710 (~3.9%) after #175795 registered single-dim strategies for categorized pointwise ops. The regression is on the cached dispatch path and comes from two sources: an extra dict lookup in the C++ get_runtime_schema_info_for_op (~890 instructions), and a Python heap layout difference in the cached OutputSharding object (~2860 instructions). Both are minor and not particularly worth fixing. While the regression is within the 10% CI noise margin, it's better to reset the counts so we still have our full 10% margin for the future. Authored with Claude. [ghstack-poisoned]
The expected count for dtensor_dispatch_inplace (add_) regressed from 56530 to 58710 (~3.9%) after #175795 registered single-dim strategies for categorized pointwise ops. The regression is on the cached dispatch path and comes from two sources: an extra dict lookup in the C++ get_runtime_schema_info_for_op (~890 instructions), and a Python heap layout difference in the cached OutputSharding object (~2860 instructions). Both are minor and not particularly worth fixing. While the regression is within the 10% CI noise margin, it's better to reset the counts so we still have our full 10% margin for the future. Authored with Claude. ghstack-source-id: 1e59629 Pull Request resolved: #177074
Switch categorized pointwise ops (.default/._ variants) from register_op_strategy to register_single_dim_strategy, using the infrastructure (category lists, rule constants, factory functions) introduced in the previous PR. The old register_op_strategy registrations are kept alongside as fallback for .out variants that will be migrated in a follow-up PR. Authored with Claude. ghstack-source-id: 2b59bac Pull Request resolved: pytorch/pytorch#175795
Stack from ghstack (oldest at bottom):
Switch categorized pointwise ops (.default/._ variants) from
register_op_strategy to register_single_dim_strategy, using the
infrastructure (category lists, rule constants, factory functions)
introduced in the previous PR.
The old register_op_strategy registrations are kept alongside as
fallback for .out variants that will be migrated in a follow-up PR.
Authored with Claude.