[dynamo] Fix dunder attr access on WrapperUserFunctionVariable (lru_cache, wraps) by guilhermeleobas · Pull Request #176934 · pytorch/pytorch

guilhermeleobas · 2026-03-09T21:27:22Z

Stack from ghstack (oldest at bottom):

-> [dynamo] Fix dunder attr access on WrapperUserFunctionVariable (lru_cache, wraps) #176934

WrapperUserFunctionVariable now inherits from BaseUserFunctionVariable
instead of VariableTracker, gaining the shared var_getattr implementation
that handles __name__, __qualname__, __doc__, __module__, __code__,
__dict__, __annotations__, and __type_params__.

This fixes functools.wraps applied to lru_cache-wrapped functions at trace
time — previously, accessing __name__, __dict__, etc. on the wrapper object
would graph-break.

Co-authored Claude Sonnet 4.6

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo

[ghstack-poisoned]

pytorch-bot · 2026-03-09T21:27:26Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176934

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 83 Pending

As of commit 9bc8c84 with merge base 3fab23b ():
💚 Looks good so far! There are no failures yet. 💚

UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…ache, wraps) `WrapperUserFunctionVariable` now inherits from `BaseUserFunctionVariable` instead of `VariableTracker`, gaining the shared `var_getattr` implementation that handles `__name__`, `__qualname__`, `__doc__`, `__module__`, `__code__`, `__dict__`, `__annotations__`, and `__type_params__`. This fixes `functools.wraps` applied to `lru_cache`-wrapped functions at trace time — previously, accessing `__name__`, `__dict__`, etc. on the wrapper object graph-break. Co-authored Claude Sonnet 4.6 ghstack-source-id: 9b69323 Pull-Request: #176934

pytorch-bot · 2026-03-09T21:27:29Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

…ache, wraps) `WrapperUserFunctionVariable` now inherits from `BaseUserFunctionVariable` instead of `VariableTracker`, gaining the shared `var_getattr` implementation that handles `__name__`, `__qualname__`, `__doc__`, `__module__`, `__code__`, `__dict__`, `__annotations__`, and `__type_params__`. This fixes `functools.wraps` applied to `lru_cache`-wrapped functions at trace time — previously, accessing `__name__`, `__dict__`, etc. on the wrapper object would graph-break. Co-authored Claude Sonnet 4.6 ghstack-source-id: 9b69323 Pull-Request: #176934

Lucaskabela

Few minor comments

Lucaskabela · 2026-03-10T16:20:02Z

torch/_dynamo/variables/functions.py

+    def var_getattr(self, tx: "InstructionTranslator", name: str):
+        fn_dict = self.get_dict_vt(tx)
+
+        # missing: __globals__, __closure__, __kwdefautls__, __defaults__


Is this a TODO we plan on adding later? If so can we make this clear?

Or if these are not supported here inentionally we should call that out

It's intentional.

torch/_dynamo/variables/functions.py

Lucaskabela · 2026-03-10T16:20:29Z

torch/_dynamo/variables/functions.py

    def var_getattr(self, tx: "InstructionTranslator", name: str) -> VariableTracker:
-        if name == "__dict__":
-            return self.get_dict_vt(tx)
+        if name in ("__dict__",):


Why a single check for in?

Forgot to undo this change before committing. I'll undo

[ghstack-poisoned]

…ache, wraps) `WrapperUserFunctionVariable` now inherits from `BaseUserFunctionVariable` instead of `VariableTracker`, gaining the shared `var_getattr` implementation that handles `__name__`, `__qualname__`, `__doc__`, `__module__`, `__code__`, `__dict__`, `__annotations__`, and `__type_params__`. This fixes `functools.wraps` applied to `lru_cache`-wrapped functions at trace time — previously, accessing `__name__`, `__dict__`, etc. on the wrapper object would graph-break. Co-authored Claude Sonnet 4.6 ghstack-source-id: 88b4ba0 Pull-Request: #176934

Lucaskabela

Thanks for fixing - LGTM

guilhermeleobas · 2026-03-11T18:23:40Z

@pytorchbot merge

pytorchmergebot · 2026-03-11T18:30:25Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-03-11T18:30:52Z

Merge failed

Reason: 1 jobs have failed, first few of them are: inductor / inductor-cpu-build / build

Details for Dev Infra team

Raised by workflow job

guilhermeleobas · 2026-03-11T18:37:44Z

@pytorchbot merge -i

pytorchmergebot · 2026-03-11T18:40:05Z

Merge started

Your change will be merged while ignoring the following 3 checks: inductor / inductor-cpu-build / build, inductor / unit-test / inductor-test / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu), inductor / unit-test / inductor-test / test (inductor_cpp_wrapper, 2, 2, linux.g5.4xlarge.nvidia.gpu)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-03-13T16:09:09Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

yangw-dev · 2026-03-16T20:49:33Z

@pytorchbot revert -m "This is being reverted due to an internal build dependency issue.
The code changes themselves are correct and the tests pass. However, when importing this change internally, it triggers a dependency blocklist violation, please find a meta folks to help fix this internally,see D96281773" -c ghfirst

pytorch-bot · 2026-03-16T20:49:37Z

❌ 🤖 pytorchbot command failed:

Got EOF while in a quoted string```
Try `@pytorchbot --help` for more info.

yangw-dev · 2026-03-16T20:50:02Z

@pytorchbot revert -m "This is being reverted due to an internal build dependency issue.The code changes themselves are correct and the tests pass. However, when importing this change internally, it triggers a dependency blocklist violation, please find a meta folks to help fix this internally,see D96281773" -c ghfirst

pytorchmergebot · 2026-03-16T20:51:49Z

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot · 2026-03-16T20:51:58Z

@guilhermeleobas your PR has been successfully reverted.

…e (lru_cache, wraps) (#176934)" This reverts commit 609e0ed. Reverted #176934 on behalf of https://github.com/yangw-dev due to This is being reverted due to an internal build dependency issue.The code changes themselves are correct and the tests pass. However, when importing this change internally, it triggers a dependency blocklist violation, please find a meta folks to help fix this internally,see D96281773 ([comment](#176934 (comment)))

yangw-dev · 2026-03-16T21:33:49Z

i apologize, this should not be reverted. the diff train is a bit messed now today. remerge this, nothing need author to do

yangw-dev · 2026-03-16T21:34:17Z

@pytorchbot merge -i

pytorchmergebot · 2026-03-16T21:36:25Z

Merge started

Your change will be merged while ignoring the following 1 checks: inductor / inductor-cpu-build / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

yangw-dev · 2026-03-16T21:57:06Z

@pytorchbot merge -f 'accidentally revert this pr, due to misinfo from internal diff train'

pytorchmergebot · 2026-03-16T21:57:25Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

pytorchmergebot · 2026-03-16T21:59:07Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

guilhermeleobas · 2026-03-17T01:30:33Z

@yangw-dev Do I need to do anything?

…ache, wraps) (pytorch#176934) `WrapperUserFunctionVariable` now inherits from `BaseUserFunctionVariable` instead of `VariableTracker`, gaining the shared `var_getattr` implementation that handles `__name__`, `__qualname__`, `__doc__`, `__module__`, `__code__`, `__dict__`, `__annotations__`, and `__type_params__`. This fixes `functools.wraps` applied to `lru_cache`-wrapped functions at trace time — previously, accessing `__name__`, `__dict__`, etc. on the wrapper object would graph-break. Co-authored Claude Sonnet 4.6 Pull Request resolved: pytorch#176934 Approved by: https://github.com/Lucaskabela, https://github.com/williamwen42

…ache, wraps) (pytorch#176934) `WrapperUserFunctionVariable` now inherits from `BaseUserFunctionVariable` instead of `VariableTracker`, gaining the shared `var_getattr` implementation that handles `__name__`, `__qualname__`, `__doc__`, `__module__`, `__code__`, `__dict__`, `__annotations__`, and `__type_params__`. This fixes `functools.wraps` applied to `lru_cache`-wrapped functions at trace time — previously, accessing `__name__`, `__dict__`, etc. on the wrapper object would graph-break. Co-authored Claude Sonnet 4.6 Pull Request resolved: pytorch#176934 Approved by: https://github.com/Lucaskabela, https://github.com/williamwen42 ghstack dependencies: pytorch#176623

…e (lru_cache, wraps) (pytorch#176934)" This reverts commit b09edda. Reverted pytorch#176934 on behalf of https://github.com/malfet due to Broke dynamo_wrapped tests, see https://hud.pytorch.org/hud/pytorch/pytorch/e274afff409c9c595b25206160e7c1dd4c6bbf6a/1?per_page=50&name_filter=dynamo_wrapped&mergeEphemeralLF=true ([comment](pytorch#176934 (comment)))

…ache, wraps) (pytorch#176934) `WrapperUserFunctionVariable` now inherits from `BaseUserFunctionVariable` instead of `VariableTracker`, gaining the shared `var_getattr` implementation that handles `__name__`, `__qualname__`, `__doc__`, `__module__`, `__code__`, `__dict__`, `__annotations__`, and `__type_params__`. This fixes `functools.wraps` applied to `lru_cache`-wrapped functions at trace time — previously, accessing `__name__`, `__dict__`, etc. on the wrapper object would graph-break. Co-authored Claude Sonnet 4.6 Pull Request resolved: pytorch#176934 Approved by: https://github.com/Lucaskabela, https://github.com/williamwen42

…e (lru_cache, wraps) (pytorch#176934)" This reverts commit 609e0ed. Reverted pytorch#176934 on behalf of https://github.com/yangw-dev due to This is being reverted due to an internal build dependency issue.The code changes themselves are correct and the tests pass. However, when importing this change internally, it triggers a dependency blocklist violation, please find a meta folks to help fix this internally,see D96281773 ([comment](pytorch#176934 (comment)))

…ache, wraps) (pytorch#176934) `WrapperUserFunctionVariable` now inherits from `BaseUserFunctionVariable` instead of `VariableTracker`, gaining the shared `var_getattr` implementation that handles `__name__`, `__qualname__`, `__doc__`, `__module__`, `__code__`, `__dict__`, `__annotations__`, and `__type_params__`. This fixes `functools.wraps` applied to `lru_cache`-wrapped functions at trace time — previously, accessing `__name__`, `__dict__`, etc. on the wrapper object would graph-break. Co-authored Claude Sonnet 4.6 Pull Request resolved: pytorch#176934 Approved by: https://github.com/Lucaskabela, https://github.com/williamwen42

…e (lru_cache, wraps) (pytorch#176934)" This reverts commit 609e0ed. Reverted pytorch#176934 on behalf of https://github.com/yangw-dev due to This is being reverted due to an internal build dependency issue.The code changes themselves are correct and the tests pass. However, when importing this change internally, it triggers a dependency blocklist violation, please find a meta folks to help fix this internally,see D96281773 ([comment](pytorch#176934 (comment)))

…ache, wraps) (pytorch#176934) `WrapperUserFunctionVariable` now inherits from `BaseUserFunctionVariable` instead of `VariableTracker`, gaining the shared `var_getattr` implementation that handles `__name__`, `__qualname__`, `__doc__`, `__module__`, `__code__`, `__dict__`, `__annotations__`, and `__type_params__`. This fixes `functools.wraps` applied to `lru_cache`-wrapped functions at trace time — previously, accessing `__name__`, `__dict__`, etc. on the wrapper object would graph-break. Co-authored Claude Sonnet 4.6 Pull Request resolved: pytorch#176934 Approved by: https://github.com/Lucaskabela, https://github.com/williamwen42

Update

6d4aaa4

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: dynamo labels Mar 9, 2026

guilhermeleobas added the ciflow/inductor-micro-benchmark label Mar 9, 2026

guilhermeleobas mentioned this pull request Mar 9, 2026

something regressed torchbench graph breaks #176777

Closed

pytorchbot added the open source label Mar 9, 2026

guilhermeleobas marked this pull request as ready for review March 9, 2026 23:39

guilhermeleobas requested a review from zou3519 March 9, 2026 23:39

guilhermeleobas added the topic: not user facing topic category label Mar 10, 2026

pytorch-bot bot added the ciflow/torchtitan Run TorchTitan integration tests label Mar 10, 2026

zou3519 requested a review from williamwen42 March 10, 2026 14:05

Lucaskabela requested changes Mar 10, 2026

View reviewed changes

Update

5c9503e

[ghstack-poisoned]

williamwen42 approved these changes Mar 11, 2026

View reviewed changes

guilhermeleobas requested a review from Lucaskabela March 11, 2026 03:21

Lucaskabela approved these changes Mar 11, 2026

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 11, 2026

pytorchmergebot added the merging label Mar 11, 2026

pytorchmergebot removed the merging label Mar 11, 2026

pytorchmergebot added the merging label Mar 11, 2026

pytorchmergebot closed this in 609e0ed Mar 13, 2026

pytorchmergebot removed the merging label Mar 13, 2026

pytorchmergebot reopened this Mar 16, 2026

pytorchmergebot added the merging label Mar 16, 2026

pytorchmergebot closed this in 065c885 Mar 16, 2026

pytorchmergebot removed the merging label Mar 16, 2026

Conversation

guilhermeleobas commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176934

⏳ No Failures, 83 Pending

Uh oh!

pytorch-bot bot commented Mar 9, 2026

This PR needs a release notes: label

Uh oh!

Lucaskabela left a comment

Choose a reason for hiding this comment

Uh oh!

Lucaskabela Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Lucaskabela Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas Mar 10, 2026

Choose a reason for hiding this comment

Uh oh!

Lucaskabela left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas commented Mar 11, 2026

Uh oh!

pytorchmergebot commented Mar 11, 2026

Merge started

Uh oh!

pytorchmergebot commented Mar 11, 2026

Merge failed

Uh oh!

guilhermeleobas commented Mar 11, 2026

Uh oh!

pytorchmergebot commented Mar 11, 2026

Merge started

Uh oh!

pytorchmergebot commented Mar 13, 2026

Merge started

Uh oh!

yangw-dev commented Mar 16, 2026

Uh oh!

pytorch-bot bot commented Mar 16, 2026

Uh oh!

yangw-dev commented Mar 16, 2026

Uh oh!

pytorchmergebot commented Mar 16, 2026

Uh oh!

pytorchmergebot commented Mar 16, 2026

Uh oh!

yangw-dev commented Mar 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yangw-dev commented Mar 16, 2026

Uh oh!

pytorchmergebot commented Mar 16, 2026

Merge started

Uh oh!

yangw-dev commented Mar 16, 2026

Uh oh!

pytorchmergebot commented Mar 16, 2026

Uh oh!

pytorchmergebot commented Mar 16, 2026

Merge started

Uh oh!

guilhermeleobas commented Mar 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

guilhermeleobas commented Mar 9, 2026 •

edited

Loading

pytorch-bot bot commented Mar 9, 2026 •

edited

Loading

This PR needs a `release notes:` label

Lucaskabela left a comment •

edited

Loading

yangw-dev commented Mar 16, 2026 •

edited

Loading