Fix `self.__dict__.get()` and property.fget in torch.compile by guilhermeleobas · Pull Request #176623 · pytorch/pytorch

guilhermeleobas · 2026-03-05T18:42:07Z

Stack from ghstack (oldest at bottom):

(to be filled)

Claude authored parts of this PR.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @kadeng @chauhang @amjames @Lucaskabela @jataylo

[ghstack-poisoned]

pytorch-bot · 2026-03-05T18:42:10Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176623

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 0cb6b4a with merge base 65762ca ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

inductor / unit-test / inductor-test / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
test/inductor/test_triton_kernels.py::TestUserKernelEpilogueFusion::test_fusion_sigmoid_epilogue
inductor / unit-test / inductor-test / test (inductor_cpp_wrapper, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (similar failure)
test/inductor/test_triton_kernels.py::TestUserKernelEpilogueFusion::test_fusion_relu_epilogue
linux-aarch64 / linux-jammy-aarch64-py3.10 / test (openreg, 1, 1, lf.linux.arm64.m7g.4xlarge) (gh) (similar failure)
'Test'
trunk / linux-jammy-rocm-py3.10 / test (default, 2, 6, linux.rocm.gpu.gfx950.1) (gh) (similar failure)
test/inductor/test_gpu_cpp_wrapper.py::TestGpuWrapper::test_profiler_mark_wrapper_call_cuda_gpu_wrapper

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 1, 2, linux.2xlarge.amx, unstable) (gh) (#174929)
detectron2_maskrcnn_r_50_fpn

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot · 2026-03-05T18:42:13Z

This PR needs a `release notes:` label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Fixes #176608 Claude authored parts of this PR. ghstack-source-id: ec8d460 Pull-Request: #176623

guilhermeleobas · 2026-03-05T18:45:09Z

cc @vmoens

Lucaskabela

Thanks for the quick fix!

vmoens

LGTM thanks!

guilhermeleobas · 2026-03-06T03:07:59Z

@pytorchbot merge

pytorchmergebot · 2026-03-06T03:10:16Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2026-03-06T09:08:27Z

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

guilhermeleobas · 2026-03-06T16:20:15Z

@pytorchbot merge

pytorchmergebot · 2026-03-06T16:22:37Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Fixes #176608 Claude authored parts of this PR. ghstack-source-id: ec8d460 Pull-Request: #176623

…ache, wraps) (#176934) `WrapperUserFunctionVariable` now inherits from `BaseUserFunctionVariable` instead of `VariableTracker`, gaining the shared `var_getattr` implementation that handles `__name__`, `__qualname__`, `__doc__`, `__module__`, `__code__`, `__dict__`, `__annotations__`, and `__type_params__`. This fixes `functools.wraps` applied to `lru_cache`-wrapped functions at trace time — previously, accessing `__name__`, `__dict__`, etc. on the wrapper object would graph-break. Co-authored Claude Sonnet 4.6 Pull Request resolved: #176934 Approved by: https://github.com/Lucaskabela, https://github.com/williamwen42 ghstack dependencies: #176623

…#176623) Fixes pytorch#176608 Claude authored parts of this PR. Pull Request resolved: pytorch#176623 Approved by: https://github.com/Lucaskabela, https://github.com/vmoens

…ache, wraps) (pytorch#176934) `WrapperUserFunctionVariable` now inherits from `BaseUserFunctionVariable` instead of `VariableTracker`, gaining the shared `var_getattr` implementation that handles `__name__`, `__qualname__`, `__doc__`, `__module__`, `__code__`, `__dict__`, `__annotations__`, and `__type_params__`. This fixes `functools.wraps` applied to `lru_cache`-wrapped functions at trace time — previously, accessing `__name__`, `__dict__`, etc. on the wrapper object would graph-break. Co-authored Claude Sonnet 4.6 Pull Request resolved: pytorch#176934 Approved by: https://github.com/Lucaskabela, https://github.com/williamwen42 ghstack dependencies: pytorch#176623

Update

0cb6b4a

[ghstack-poisoned]

pytorch-bot bot added ciflow/inductor module: dynamo labels Mar 5, 2026

guilhermeleobas added a commit that referenced this pull request Mar 5, 2026

Fix self.__dict__.get() and property.fget in torch.compile

1bf2a58

Fixes #176608 Claude authored parts of this PR. ghstack-source-id: ec8d460 Pull-Request: #176623

guilhermeleobas requested a review from Lucaskabela March 5, 2026 18:45

guilhermeleobas marked this pull request as ready for review March 5, 2026 18:45

pytorchbot added the open source label Mar 5, 2026

guilhermeleobas added the topic: not user facing topic category label Mar 5, 2026

Lucaskabela approved these changes Mar 5, 2026

View reviewed changes

vmoens approved these changes Mar 5, 2026

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 6, 2026

guilhermeleobas linked an issue Mar 6, 2026 that may be closed by this pull request

[dynamo] Property getter using __dict__.get() returns stale value inside @torch.compiler.disable in nightlies #176608

Closed

pytorchmergebot added the merging label Mar 6, 2026

pytorchmergebot added the Merged label Mar 6, 2026

pytorchmergebot closed this in 71b64d4 Mar 6, 2026

pytorchmergebot removed the merging label Mar 6, 2026

guilhermeleobas added a commit that referenced this pull request Mar 9, 2026

Fix self.__dict__.get() and property.fget in torch.compile

e3d2bc9

Fixes #176608 Claude authored parts of this PR. ghstack-source-id: ec8d460 Pull-Request: #176623

github-actions bot deleted the gh/guilhermeleobas/307/head branch April 6, 2026 02:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix `self.dict.get()` and property.fget in torch.compile#176623

Fix `self.dict.get()` and property.fget in torch.compile#176623
guilhermeleobas wants to merge 1 commit intogh/guilhermeleobas/307/basefrom
gh/guilhermeleobas/307/head

guilhermeleobas commented Mar 5, 2026 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Mar 5, 2026 •

edited

Loading

Uh oh!

pytorch-bot bot commented Mar 5, 2026

Uh oh!

guilhermeleobas commented Mar 5, 2026

Uh oh!

Lucaskabela left a comment

Uh oh!

vmoens left a comment

Uh oh!

guilhermeleobas commented Mar 6, 2026

Uh oh!

pytorchmergebot commented Mar 6, 2026

Uh oh!

pytorchmergebot commented Mar 6, 2026

Uh oh!

guilhermeleobas commented Mar 6, 2026

Uh oh!

pytorchmergebot commented Mar 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

guilhermeleobas commented Mar 5, 2026 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/176623

✅ You can merge normally! (5 Unrelated Failures)

Uh oh!

pytorch-bot bot commented Mar 5, 2026

This PR needs a release notes: label

Uh oh!

guilhermeleobas commented Mar 5, 2026

Uh oh!

Lucaskabela left a comment

Choose a reason for hiding this comment

Uh oh!

vmoens left a comment

Choose a reason for hiding this comment

Uh oh!

guilhermeleobas commented Mar 6, 2026

Uh oh!

pytorchmergebot commented Mar 6, 2026

Merge started

Uh oh!

pytorchmergebot commented Mar 6, 2026

Uh oh!

guilhermeleobas commented Mar 6, 2026

Uh oh!

pytorchmergebot commented Mar 6, 2026

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

guilhermeleobas commented Mar 5, 2026 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Mar 5, 2026 •

edited

Loading

This PR needs a `release notes:` label