[DTensor] Add decomposition-based sharding propagation to strategy validator#174638
Closed
wconstab wants to merge 4 commits intogh/wconstab/527/basefrom
Closed
[DTensor] Add decomposition-based sharding propagation to strategy validator#174638wconstab wants to merge 4 commits intogh/wconstab/527/basefrom
wconstab wants to merge 4 commits intogh/wconstab/527/basefrom
Conversation
…lidator The validator previously only discovered sharding rules via `op_single_dim_strategy_funcs` and `op_strategy_funcs`. This adds a third fallback path that uses `DecompShardingStrategy` to discover rules for ops that have decompositions but no direct strategy registration. Extracts a shared `_extract_rules_from_op_strategy` helper to avoid duplicating the normalize/filter logic between the `op_strategy_funcs` and decomp paths. Authored with Claude. [ghstack-poisoned]
This was referenced Feb 9, 2026
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/174638
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 37 PendingAs of commit 1a189e8 with merge base f365425 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 9, 2026
wconstab
added a commit
that referenced
this pull request
Feb 9, 2026
…lidator The validator previously only discovered sharding rules via `op_single_dim_strategy_funcs` and `op_strategy_funcs`. This adds a third fallback path that uses `DecompShardingStrategy` to discover rules for ops that have decompositions but no direct strategy registration. Extracts a shared `_extract_rules_from_op_strategy` helper to avoid duplicating the normalize/filter logic between the `op_strategy_funcs` and decomp paths. Authored with Claude. ghstack-source-id: 37e8918 Pull Request resolved: #174638
…strategy validator" The validator previously only discovered sharding rules via `op_single_dim_strategy_funcs` and `op_strategy_funcs`. This adds a third fallback path that uses `DecompShardingStrategy` to discover rules for ops that have decompositions but no direct strategy registration. Extracts a shared `_extract_rules_from_op_strategy` helper to avoid duplicating the normalize/filter logic between the `op_strategy_funcs` and decomp paths. Authored with Claude. [ghstack-poisoned]
wconstab
added a commit
that referenced
this pull request
Feb 10, 2026
…lidator The validator previously only discovered sharding rules via `op_single_dim_strategy_funcs` and `op_strategy_funcs`. This adds a third fallback path that uses `DecompShardingStrategy` to discover rules for ops that have decompositions but no direct strategy registration. Extracts a shared `_extract_rules_from_op_strategy` helper to avoid duplicating the normalize/filter logic between the `op_strategy_funcs` and decomp paths. Authored with Claude. ghstack-source-id: 6c3a962 Pull Request resolved: #174638
…strategy validator" The validator previously only discovered sharding rules via `op_single_dim_strategy_funcs` and `op_strategy_funcs`. This adds a third fallback path that uses `DecompShardingStrategy` to discover rules for ops that have decompositions but no direct strategy registration. Extracts a shared `_extract_rules_from_op_strategy` helper to avoid duplicating the normalize/filter logic between the `op_strategy_funcs` and decomp paths. Authored with Claude. [ghstack-poisoned]
wconstab
added a commit
that referenced
this pull request
Feb 11, 2026
…lidator The validator previously only discovered sharding rules via `op_single_dim_strategy_funcs` and `op_strategy_funcs`. This adds a third fallback path that uses `DecompShardingStrategy` to discover rules for ops that have decompositions but no direct strategy registration. Extracts a shared `_extract_rules_from_op_strategy` helper to avoid duplicating the normalize/filter logic between the `op_strategy_funcs` and decomp paths. Authored with Claude. ghstack-source-id: cb81a66 Pull Request resolved: #174638
…strategy validator" The validator previously only discovered sharding rules via `op_single_dim_strategy_funcs` and `op_strategy_funcs`. This adds a third fallback path that uses `DecompShardingStrategy` to discover rules for ops that have decompositions but no direct strategy registration. Extracts a shared `_extract_rules_from_op_strategy` helper to avoid duplicating the normalize/filter logic between the `op_strategy_funcs` and decomp paths. Authored with Claude. [ghstack-poisoned]
wconstab
added a commit
that referenced
this pull request
Feb 11, 2026
…lidator The validator previously only discovered sharding rules via `op_single_dim_strategy_funcs` and `op_strategy_funcs`. This adds a third fallback path that uses `DecompShardingStrategy` to discover rules for ops that have decompositions but no direct strategy registration. Extracts a shared `_extract_rules_from_op_strategy` helper to avoid duplicating the normalize/filter logic between the `op_strategy_funcs` and decomp paths. Authored with Claude. ghstack-source-id: c7df5ee Pull Request resolved: #174638
Contributor
Author
|
squashed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The validator previously only discovered sharding rules via
op_single_dim_strategy_funcsandop_strategy_funcs. This adds athird fallback path that uses
DecompShardingStrategyto discover rulesfor ops that have decompositions but no direct strategy registration.
Extracts a shared
_extract_rules_from_op_strategyhelper to avoidduplicating the normalize/filter logic between the
op_strategy_funcsand decomp paths.
Authored with Claude.