[DTensor] Include Partial placements for scalar tensors in validator#174537
Closed
wconstab wants to merge 5 commits intogh/wconstab/524/basefrom
Closed
[DTensor] Include Partial placements for scalar tensors in validator#174537wconstab wants to merge 5 commits intogh/wconstab/524/basefrom
wconstab wants to merge 5 commits intogh/wconstab/524/basefrom
Conversation
The validator excluded Partial placements for 0-dim (scalar) tensors in both get_1d_input_placements_for_tensor and get_1d_output_placements_for_tensor. This meant the exhaustive sweep never tested Partial on scalars, so DTensor rules like P(max),P(max)-> P(max) for maximum with a scalar input were always classified as "incorrect" even though they are valid. Partial is meaningful for scalars: P(sum) on a scalar means each rank holds a partial value that sums to the full scalar. Authored with Claude. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/174537
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 36 PendingAs of commit 9987957 with merge base f365425 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Feb 8, 2026
… validator" The validator excluded Partial placements for 0-dim (scalar) tensors in both get_1d_input_placements_for_tensor and get_1d_output_placements_for_tensor. This meant the exhaustive sweep never tested Partial on scalars, so DTensor rules like P(max),P(max)-> P(max) for maximum with a scalar input were always classified as "incorrect" even though they are valid. Partial is meaningful for scalars: P(sum) on a scalar means each rank holds a partial value that sums to the full scalar. Authored with Claude. [ghstack-poisoned]
pianpwk
approved these changes
Feb 9, 2026
… validator" The validator excluded Partial placements for 0-dim (scalar) tensors in both get_1d_input_placements_for_tensor and get_1d_output_placements_for_tensor. This meant the exhaustive sweep never tested Partial on scalars, so DTensor rules like P(max),P(max)-> P(max) for maximum with a scalar input were always classified as "incorrect" even though they are valid. Partial is meaningful for scalars: P(sum) on a scalar means each rank holds a partial value that sums to the full scalar. Authored with Claude. [ghstack-poisoned]
… validator" The validator excluded Partial placements for 0-dim (scalar) tensors in both get_1d_input_placements_for_tensor and get_1d_output_placements_for_tensor. This meant the exhaustive sweep never tested Partial on scalars, so DTensor rules like P(max),P(max)-> P(max) for maximum with a scalar input were always classified as "incorrect" even though they are valid. Partial is meaningful for scalars: P(sum) on a scalar means each rank holds a partial value that sums to the full scalar. Authored with Claude. [ghstack-poisoned]
… validator" The validator excluded Partial placements for 0-dim (scalar) tensors in both get_1d_input_placements_for_tensor and get_1d_output_placements_for_tensor. This meant the exhaustive sweep never tested Partial on scalars, so DTensor rules like P(max),P(max)-> P(max) for maximum with a scalar input were always classified as "incorrect" even though they are valid. Partial is meaningful for scalars: P(sum) on a scalar means each rank holds a partial value that sums to the full scalar. Authored with Claude. [ghstack-poisoned]
Contributor
Author
|
squashed |
sandy-gags
pushed a commit
to sandy-gags/pytorch
that referenced
this pull request
Mar 12, 2026
The validator excluded Partial placements for 0-dim (scalar) tensors in both get_1d_input_placements_for_tensor and get_1d_output_placements_for_tensor. This meant the exhaustive sweep never tested Partial on scalars, so DTensor rules like P(max),P(max)-> P(max) for maximum with a scalar input were always classified as "incorrect" even though they are valid. Partial is meaningful for scalars: P(sum) on a scalar means each rank holds a partial value that sums to the full scalar. Authored with Claude. ghstack-source-id: e36351d Pull Request resolved: pytorch/pytorch#174537
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
The validator excluded Partial placements for 0-dim (scalar) tensors in
both get_1d_input_placements_for_tensor and
get_1d_output_placements_for_tensor. This meant the exhaustive sweep
never tested Partial on scalars, so DTensor rules like P(max),P(max)->
P(max) for maximum with a scalar input were always classified as
"incorrect" even though they are valid.
Partial is meaningful for scalars: P(sum) on a scalar means each rank
holds a partial value that sums to the full scalar.
Authored with Claude.