deprecate check_is_size and guard_size_oblivious (#167198)#169400
Closed
laithsakka wants to merge 1 commit intopytorch:mainfrom
Closed
deprecate check_is_size and guard_size_oblivious (#167198)#169400laithsakka wants to merge 1 commit intopytorch:mainfrom
laithsakka wants to merge 1 commit intopytorch:mainfrom
Conversation
|
@laithsakka has exported this pull request. If you are a Meta employee, you can view the originating Diff in D88186600. |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/169400
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit e1b9381 with merge base 7ea27ac ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
53aadd5 to
e19e43d
Compare
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
bobrenjc93
approved these changes
Dec 5, 2025
Collaborator
|
Do you want the warning category to be a DeprecatedWarning Category or a FutureWarning. Ie do you want to yell at people in IDEs opted into it or end users because it's about to be removed. If so change the kwarg for the decorator to reflect it |
e19e43d to
2d9e5d9
Compare
pytorch-bot bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 6, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
3bdb67d to
c9135ee
Compare
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
c9135ee to
13371c2
Compare
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
ebba9cf to
4b1d512
Compare
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
4b1d512 to
8b3bcd1
Compare
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
8b3bcd1 to
851806b
Compare
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
851806b to
36515c8
Compare
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
36515c8 to
8fd3e7f
Compare
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
8fd3e7f to
e1b9381
Compare
Contributor
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
hinriksnaer
pushed a commit
to hinriksnaer/pytorch
that referenced
this pull request
Jan 12, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600 Pull Request resolved: pytorch#169400 Approved by: https://github.com/bobrenjc93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: title
Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5
Differential Revision: D88186600
cc @ezyang @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @jataylo @Lucaskabela