deprecate check_is_size and guard_size_oblivious#167198
Closed
laithsakka wants to merge 7 commits intogh/laithsakka/323/basefrom
Closed
deprecate check_is_size and guard_size_oblivious#167198laithsakka wants to merge 7 commits intogh/laithsakka/323/basefrom
laithsakka wants to merge 7 commits intogh/laithsakka/323/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167198
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (4 Unrelated Failures)As of commit 54f7347 with merge base 7aa210d ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc ezyang EikanWang jgong5 wenzhe-nrv [ghstack-poisoned]
cc ezyang EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc ezyang EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
bobrenjc93
approved these changes
Nov 13, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable) Details for Dev Infra teamRaised by workflow job |
cc ezyang EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
@pytorchbot revert -m "synced with author, this breaks internal builds" -c ghfirst |
Collaborator
|
@pytorchbot successfully started a revert job. Check the current status here. |
pytorchmergebot
added a commit
that referenced
this pull request
Nov 17, 2025
This reverts commit f2e6f94. Reverted #167198 on behalf of https://github.com/yangw-dev due to synced with author, this breaks internal builds ([comment](#167198 (comment)))
Collaborator
|
@laithsakka your PR has been successfully reverted. |
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
Pull Request resolved: pytorch#167198 Approved by: https://github.com/bobrenjc93
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
)" This reverts commit 50bf1f0. Reverted pytorch#167198 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](pytorch#167198 (comment)))
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
Pull Request resolved: pytorch#167198 Approved by: https://github.com/bobrenjc93
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 2, 2025
Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
pytorch-bot bot
pushed a commit
that referenced
this pull request
Dec 5, 2025
Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
Contributor
Author
|
closing in favor of #169400 |
pytorch-bot bot
pushed a commit
that referenced
this pull request
Jan 6, 2026
Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 6, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
laithsakka
added a commit
to laithsakka/pytorch
that referenced
this pull request
Jan 7, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Reviewed By: svalentin, Mingming-Ding Differential Revision: D88186600
pytorchmergebot
pushed a commit
that referenced
this pull request
Jan 8, 2026
Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600 Pull Request resolved: #169400 Approved by: https://github.com/bobrenjc93
hinriksnaer
pushed a commit
to hinriksnaer/pytorch
that referenced
this pull request
Jan 12, 2026
…torch#169400) Summary: title Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/f2e6f94081c02704adf027fe0c81bf25726828f5 Differential Revision: D88186600 Pull Request resolved: pytorch#169400 Approved by: https://github.com/bobrenjc93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @ezyang @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela