Update numpy tests for python 3.11/3.12#168299
Closed
rtimpe wants to merge 1 commit intogh/rtimpe/31/basefrom
Closed
Update numpy tests for python 3.11/3.12#168299rtimpe wants to merge 1 commit intogh/rtimpe/31/basefrom
rtimpe wants to merge 1 commit intogh/rtimpe/31/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168299
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9ca90c9 with merge base 5b35cf1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
rtimpe
added a commit
that referenced
this pull request
Nov 20, 2025
This fixes the dynamo-unittest workflow. This test was fixed in #167619 but wasn't caught because these tests are skipped for numpy versions > 2.0 (meaning our CI for 3.13 doesn't run them). As a separate task, we should update all of these tests for recent numpy versions so we can start running them again. ghstack-source-id: 61eae6f Pull-Request: #168299
williamwen42
approved these changes
Nov 20, 2025
Member
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
This fixes the dynamo-unittest workflow. This test was fixed in #167619 but wasn't caught because these tests are skipped for numpy versions > 2.0 (meaning our CI for 3.13 doesn't run them). As a separate task, we should update all of these tests for recent numpy versions so we can start running them again. Pull Request resolved: #168299 Approved by: https://github.com/williamwen42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This fixes the dynamo-unittest workflow. This test was fixed in
#167619 but wasn't caught because these
tests are skipped for numpy versions > 2.0 (meaning our CI for 3.13 doesn't run
them). As a separate task, we should update all of these tests for recent numpy
versions so we can start running them again.