[dynamo] [3.14] Support np._CopyMode#167619
Closed
rtimpe wants to merge 3 commits intogh/rtimpe/25/basefrom
Closed
[dynamo] [3.14] Support np._CopyMode#167619rtimpe wants to merge 3 commits intogh/rtimpe/25/basefrom
rtimpe wants to merge 3 commits intogh/rtimpe/25/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167619
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c7f56ed with merge base 115016f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
williamwen42
approved these changes
Nov 12, 2025
test/test_numpy_interop.py
Outdated
|
|
||
| x = np.array([1, 2, 3]) | ||
| # Should run without throwing an exception | ||
| f(x) |
Member
There was a problem hiding this comment.
Check for expected value just for consistency?
Collaborator
|
Starting merge as part of PR stack under #167681 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 13, 2025
This is related to upgrading numpy versions, not 3.14 specifically. See numpy/numpy#27148 Pull Request resolved: #167681 Approved by: https://github.com/williamwen42 ghstack dependencies: #167619
Khanaksahu
pushed a commit
to Khanaksahu/pytorch
that referenced
this pull request
Nov 17, 2025
Upgrading scipy to 1.16 introduced errors related to the `copy` parameter of `np.array`. Add special handling for `np._CopyMode.IF_NEEDED`, which is not handled correctly, but matches the existing behavior when `copy=None`. ghstack-source-id: 9af0378 Pull-Request: pytorch/pytorch#167619
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
Upgrading scipy to 1.16 introduced errors related to the `copy` parameter of `np.array`. Add special handling for `np._CopyMode.IF_NEEDED`, which is not handled correctly, but matches the existing behavior when `copy=None`. Pull Request resolved: pytorch#167619 Approved by: https://github.com/williamwen42
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
This is related to upgrading numpy versions, not 3.14 specifically. See numpy/numpy#27148 Pull Request resolved: pytorch#167681 Approved by: https://github.com/williamwen42 ghstack dependencies: pytorch#167619
rtimpe
added a commit
that referenced
this pull request
Nov 20, 2025
This fixes the dynamo-unittest workflow. This test was fixed in #167619 but wasn't caught because these tests are skipped for numpy versions > 2.0 (meaning our CI for 3.13 doesn't run them). As a separate task, we should update all of these tests for recent numpy versions so we can start running them again. ghstack-source-id: 61eae6f Pull-Request: #168299
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 21, 2025
This fixes the dynamo-unittest workflow. This test was fixed in #167619 but wasn't caught because these tests are skipped for numpy versions > 2.0 (meaning our CI for 3.13 doesn't run them). As a separate task, we should update all of these tests for recent numpy versions so we can start running them again. Pull Request resolved: #168299 Approved by: https://github.com/williamwen42
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
This fixes the dynamo-unittest workflow. This test was fixed in #167619 but wasn't caught because these tests are skipped for numpy versions > 2.0 (meaning our CI for 3.13 doesn't run them). As a separate task, we should update all of these tests for recent numpy versions so we can start running them again. Pull Request resolved: #168299 Approved by: https://github.com/williamwen42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Upgrading scipy to 1.16 introduced errors related to the
copyparameter ofnp.array. Add special handling fornp._CopyMode.IF_NEEDED, which is nothandled correctly, but matches the existing behavior when
copy=None.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela