[DTensor] Refactor strategy/rule registration into dedicated module#168221
Closed
wconstab wants to merge 2 commits intogh/wconstab/463/basefrom
Closed
[DTensor] Refactor strategy/rule registration into dedicated module#168221wconstab wants to merge 2 commits intogh/wconstab/463/basefrom
wconstab wants to merge 2 commits intogh/wconstab/463/basefrom
Conversation
To avoid circular import issues: - utils.py used to include registration functions which import/depend on DTensor.sharding_propagator - I plan to use other utils from utils.py inside sharding_propagator.py [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168221
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 557fedc with merge base 6edf2aa ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ed module" To avoid circular import issues: - utils.py used to include registration functions which import/depend on DTensor.sharding_propagator - I plan to use other utils from utils.py inside sharding_propagator.py [ghstack-poisoned]
This was referenced Nov 19, 2025
wconstab
commented
Nov 22, 2025
| ) | ||
|
|
||
|
|
||
| # convenient wrapper to register sharding propagation rules |
Contributor
Author
There was a problem hiding this comment.
no code change, i promise. just moved from other file
Contributor
Author
|
@pytorchbot merge -I |
|
❌ 🤖 pytorchbot command failed: Try |
Contributor
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 2 checks: pull / linux-jammy-rocm-py3.10 / build, inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 1, 2, linux.2xlarge.amx) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
aditvenk
added a commit
to aditvenk/autoparallel
that referenced
this pull request
Nov 25, 2025
Changed in PyTorch as part of pytorch/pytorch#168221
xmfan
pushed a commit
to meta-pytorch/autoparallel
that referenced
this pull request
Nov 26, 2025
Changed in PyTorch as part of pytorch/pytorch#168221
JacobSzwejbka
pushed a commit
that referenced
this pull request
Dec 8, 2025
…168221) To avoid circular import issues: - utils.py used to include registration functions which import/depend on DTensor.sharding_propagator - I plan to use other utils from utils.py inside sharding_propagator.py Pull Request resolved: #168221 Approved by: https://github.com/albanD
tiendatngcs
pushed a commit
to tiendatngcs/pytorch-Dec25
that referenced
this pull request
Dec 10, 2025
To avoid circular import issues: - utils.py used to include registration functions which import/depend on DTensor.sharding_propagator - I plan to use other utils from utils.py inside sharding_propagator.py ghstack-source-id: e2087c8 Pull Request resolved: pytorch/pytorch#168221
wconstab
added a commit
that referenced
this pull request
Dec 16, 2025
wconstab
added a commit
that referenced
this pull request
Dec 16, 2025
wconstab
added a commit
that referenced
this pull request
Dec 17, 2025
wconstab
added a commit
that referenced
this pull request
Dec 17, 2025
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 17, 2025
…module (#168221)" (#170615) This reverts commit cb3754f. Reverting this change as it affects the import path of a publicly used API. Pull Request resolved: #170615 Approved by: https://github.com/wdvr, https://github.com/malfet
pytorchmergebot
added a commit
that referenced
this pull request
Dec 18, 2025
… module (#168221)" (#170615) This reverts commit c65f67b. Reverted #170615 on behalf of https://github.com/jeanschmidt due to Required to revert #170030 ([comment](#170615 (comment)))
weifengpy
pushed a commit
that referenced
this pull request
Dec 19, 2025
weifengpy
pushed a commit
that referenced
this pull request
Dec 19, 2025
pytorchmergebot
pushed a commit
that referenced
this pull request
Dec 19, 2025
…module (#168221)" (#170615) This reverts commit cb3754f. Reverting this change as it affects the import path of a publicly used API. Pull Request resolved: #170615 Approved by: https://github.com/wdvr, https://github.com/malfet
majing921201
pushed a commit
to majing921201/pytorch
that referenced
this pull request
Dec 19, 2025
… module (pytorch#168221)" (pytorch#170615) This reverts commit c65f67b. Reverted pytorch#170615 on behalf of https://github.com/jeanschmidt due to Required to revert pytorch#170030 ([comment](pytorch#170615 (comment)))
majing921201
pushed a commit
to majing921201/pytorch
that referenced
this pull request
Dec 19, 2025
…module (pytorch#168221)" (pytorch#170615) This reverts commit cb3754f. Reverting this change as it affects the import path of a publicly used API. Pull Request resolved: pytorch#170615 Approved by: https://github.com/wdvr, https://github.com/malfet
xgz2
pushed a commit
that referenced
this pull request
Dec 22, 2025
… module (#168221)" (#170615) This reverts commit c65f67b. Reverted #170615 on behalf of https://github.com/jeanschmidt due to Required to revert #170030 ([comment](#170615 (comment)))
xgz2
pushed a commit
that referenced
this pull request
Dec 22, 2025
…module (#168221)" (#170615) This reverts commit cb3754f. Reverting this change as it affects the import path of a publicly used API. Pull Request resolved: #170615 Approved by: https://github.com/wdvr, https://github.com/malfet
drizzlezyk
pushed a commit
to Ascend/pytorch
that referenced
this pull request
Jan 7, 2026
Co-authored-by: dilililiwhy<why.wuhuanyu@huawei.com> # message auto-generated for no-merge-commit merge: !28630 merge main_sync_20251202 into master TORCH MAIN SYNC : strategy/rule registration refactoring (DTensor) Created-by: dilililiwhy Commit-by: dilililiwhy Merged-by: ascend-robot Description: <!-- Thanks for sending a pull request! --> **What type of PR is this?** > Uncomment only one ` /kind <>` line, hit enter to put that in a new line, and remove leading whitespaces from that line: > > /kind bug > /kind task > /kind feature **What does this PR do / why do we need it**: 2.10.0.dev20251124 **Which issue(s) this PR fixes**: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes # **Special notes for your reviewers**: pytorch/pytorch#166264 pytorch/pytorch#167782 pytorch/pytorch#168221 See merge request: Ascend/pytorch!28630
krastogi-in
pushed a commit
to krastogi-in/pytorch
that referenced
this pull request
Jan 9, 2026
…module (pytorch#168221)" (pytorch#170615) This reverts commit cb3754f. Reverting this change as it affects the import path of a publicly used API. Pull Request resolved: pytorch#170615 Approved by: https://github.com/wdvr, https://github.com/malfet
krastogi-in
pushed a commit
to krastogi-in/pytorch
that referenced
this pull request
Jan 9, 2026
… module (pytorch#168221)" (pytorch#170615) This reverts commit c65f67b. Reverted pytorch#170615 on behalf of https://github.com/jeanschmidt due to Required to revert pytorch#170030 ([comment](pytorch#170615 (comment)))
krastogi-in
pushed a commit
to krastogi-in/pytorch
that referenced
this pull request
Jan 9, 2026
…module (pytorch#168221)" (pytorch#170615) This reverts commit cb3754f. Reverting this change as it affects the import path of a publicly used API. Pull Request resolved: pytorch#170615 Approved by: https://github.com/wdvr, https://github.com/malfet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
To avoid circular import issues:
DTensor.sharding_propagator