[DTensor] single-dim pointwise strategy#168115
Closed
wconstab wants to merge 23 commits intogh/wconstab/459/basefrom
Closed
[DTensor] single-dim pointwise strategy#168115wconstab wants to merge 23 commits intogh/wconstab/459/basefrom
wconstab wants to merge 23 commits intogh/wconstab/459/basefrom
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168115
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 6e1a7ad with merge base 74e112c ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following job failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Nov 18, 2025
[ghstack-poisoned]
[ghstack-poisoned]
wconstab
commented
Nov 19, 2025
| return single_mesh_dim_common_pointwise_strategy(op_schema.args_schema, linearity) | ||
|
|
||
| def single_mesh_dim_common_pointwise_strategy( | ||
| args_schema: Sequence[object], |
Contributor
Author
There was a problem hiding this comment.
should contain tensormeta not Opstrategy/DTensorSpec
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
tiendatngcs
pushed a commit
to tiendatngcs/pytorch-Dec25
that referenced
this pull request
Dec 10, 2025
ghstack-source-id: ecded22 Pull Request resolved: pytorch/pytorch#168115
tiendatngcs
pushed a commit
to tiendatngcs/pytorch-Dec25
that referenced
this pull request
Dec 10, 2025
ghstack-source-id: dd60d43 Pull Request resolved: pytorch/pytorch#168115
[ghstack-poisoned]
This was referenced Dec 11, 2025
Closed
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
wconstab
commented
Dec 19, 2025
| pointwise_strategy | ||
| ) | ||
|
|
||
| # register_single_dim_strategy( |
Contributor
Author
There was a problem hiding this comment.
purposefully not enabled yet. but I left the commented code here since I often want to switch it back on for testing
pianpwk
approved these changes
Dec 19, 2025
Contributor
Author
|
@pytorchbot merge -i |
Collaborator
Merge startedYour change will be merged while ignoring the following 1 checks: inductor / unit-test / inductor-pallas-cpu-test / test (inductor-pallas-cpu, 1, 1, linux.12xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
xgz2
pushed a commit
that referenced
this pull request
Dec 22, 2025
This PR adds a dummy version of a single-dim pointwise strategy, and it shouldn't be used yet for real but it is being used by unit tests in #170631 so it is useful to land. Pull Request resolved: #168115 Approved by: https://github.com/pianpwk Co-authored-by: Pian Pawakapan <pianpwk@meta.com>
krastogi-in
pushed a commit
to krastogi-in/pytorch
that referenced
this pull request
Jan 9, 2026
This PR adds a dummy version of a single-dim pointwise strategy, and it shouldn't be used yet for real but it is being used by unit tests in pytorch#170631 so it is useful to land. Pull Request resolved: pytorch#168115 Approved by: https://github.com/pianpwk Co-authored-by: Pian Pawakapan <pianpwk@meta.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This PR adds a dummy version of a single-dim pointwise strategy, and it shouldn't be used yet for real but it is being used by unit tests in #170631 so it is useful to land.