[OpenReg][Feat][Docs] Enrich OpenReg device management implementation and add focused documentation#165897
Closed
KarhouTam wants to merge 4 commits intopytorch:mainfrom
Closed
[OpenReg][Feat][Docs] Enrich OpenReg device management implementation and add focused documentation#165897KarhouTam wants to merge 4 commits intopytorch:mainfrom
KarhouTam wants to merge 4 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165897
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 901042c with merge base ce4f31f ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
Author
|
@pytorchbot label "module: openreg" |
38 tasks
79eb90b to
dd0677e
Compare
fffrog
reviewed
Oct 28, 2025
test/cpp_extensions/open_registration_extension/torch_openreg/csrc/runtime/OpenRegFunctions.h
Outdated
Show resolved
Hide resolved
fffrog
reviewed
Oct 29, 2025
test/cpp_extensions/open_registration_extension/torch_openreg/torch_openreg/openreg/__init__.py
Show resolved
Hide resolved
fffrog
reviewed
Oct 29, 2025
c6324fd to
46a0809
Compare
Contributor
Author
Contributor
Author
|
@pytorchbot label "ciflow/trunk" |
fffrog
reviewed
Nov 12, 2025
fffrog
approved these changes
Nov 12, 2025
Collaborator
fffrog
left a comment
There was a problem hiding this comment.
LGTM, thank you a lot.
Just some tiny nits.
…t device functions - Introduced device management documentation in `device.md`. - Updated `OpenRegFunctions.h` and `OpenRegFunctions.cpp` to use `DeviceIndex` and added error handling. - Implemented `check_device_index` function for validating device indices. - Enhanced Python bindings in `Module.cpp` for device management. - Added tests for invalid device index handling in `test_device.py`.
46a0809 to
0db9941
Compare
Contributor
Author
|
@pytorchbot label "ciflow/trunk" |
…rkers for SetDevice functions
Contributor
Author
|
@pytorchbot label "ciflow/trunk" |
Collaborator
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Silv3S
pushed a commit
to Silv3S/pytorch
that referenced
this pull request
Nov 18, 2025
… and add focused documentation (pytorch#165897) ## Summary This PR enriches OpenReg device management codes and adds focused documentation. ## Key Changes - Introduced device management documentation in `device.md`. - Updated `OpenRegFunctions.h` and `OpenRegFunctions.cpp` to use `DeviceIndex` and added error handling. - Implemented `check_device_index` function for validating device indices. - Enhanced Python bindings in `Module.cpp` for device management. - Added tests for invalid device index handling in `test_device.py`. Pull Request resolved: pytorch#165897 Approved by: https://github.com/fffrog
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR enriches OpenReg device management codes and adds focused documentation.
Key Changes
device.md.OpenRegFunctions.handOpenRegFunctions.cppto useDeviceIndexand added error handling.check_device_indexfunction for validating device indices.Module.cppfor device management.test_device.py.