[OpenReg][Feat][Docs] Enrich hook implementation and add focused documentation by KarhouTam · Pull Request #165980 · pytorch/pytorch

KarhouTam · 2025-10-21T08:45:44Z

Summary

This PR enriches the implementation of OpenRegHooks.h and adds focused documentation for OpenReg hooks.

Key Changes

A new document: docs/source/accelerator/hooks.md
New OpenReg hooks like isBuilt(), isAvailable() and so on...

pytorch-bot · 2025-10-21T08:45:48Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165980

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 56405e6 with merge base 0dac408 ():

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge, unstable) (gh) (#166072)
backends/xnnpack/test/recipes/test_xnnpack_recipes.py::TestXnnpackRecipes::test_int8_static_quant_recipe

This comment was automatically generated by Dr. CI and updates every 15 minutes.

KarhouTam · 2025-10-21T08:47:16Z

@pytorchbot label "module: openreg"

docs/source/accelerator/index.md

test/cpp_extensions/open_registration_extension/torch_openreg/csrc/runtime/OpenRegHooks.h

KarhouTam · 2025-11-12T01:12:37Z

@pytorchbot label "ciflow/trunk"

test/cpp_extensions/open_registration_extension/torch_openreg/csrc/runtime/OpenRegHooks.h

docs/source/accelerator/hooks.md

fffrog · 2025-11-13T03:28:40Z

Thank you for updating, it looks good to me.

KarhouTam · 2025-11-13T03:29:29Z

@pytorchbot merge

pytorchmergebot · 2025-11-13T03:31:37Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

KarhouTam · 2025-11-13T03:46:47Z

A lint job failed... Seems not my fault.

pytorchmergebot · 2025-11-13T06:02:18Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-noble-xpu-n-py3.10 / build

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

KarhouTam · 2025-11-13T06:24:00Z

@pytorchbot rebase

pytorchmergebot · 2025-11-13T06:25:30Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

…tation

Co-authored-by: Jiawei Li <ljw1101.vip@gmail.com>

…tter clarity and usability

…o high and low priority levels for better clarity and guidance for vendors.

pytorchmergebot · 2025-11-13T06:25:33Z

Successfully rebased openreg-hooks onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout openreg-hooks && git pull --rebase)

KarhouTam · 2025-11-13T06:26:31Z

@pytorchbot merge

pytorchmergebot · 2025-11-13T06:28:18Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

…mentation (pytorch#165980) ## Summary This PR enriches the implementation of `OpenRegHooks.h` and adds focused documentation for `OpenReg` hooks. ## Key Changes - A new document: `docs/source/accelerator/hooks.md` - New `OpenReg` hooks like `isBuilt()`, `isAvailable()` and so on... Pull Request resolved: pytorch#165980 Approved by: https://github.com/fffrog Co-authored-by: Jiawei Li <ljw1101.vip@gmail.com>

pytorch-bot bot added the topic: not user facing topic category label Oct 21, 2025

pytorchbot added the open source label Oct 21, 2025

pytorch-bot bot added the module: openreg label Oct 21, 2025

fffrog mentioned this pull request Oct 23, 2025

[Feat] Tracking for OpenReg Improvements #158917

Open

38 tasks

KarhouTam force-pushed the openreg-hooks branch from bbf7e2f to 11ead9a Compare October 25, 2025 03:33

fffrog reviewed Oct 29, 2025

View reviewed changes

docs/source/accelerator/index.md Outdated Show resolved Hide resolved

fffrog reviewed Oct 30, 2025

View reviewed changes

test/cpp_extensions/open_registration_extension/torch_openreg/csrc/runtime/OpenRegHooks.h Outdated Show resolved Hide resolved

KarhouTam force-pushed the openreg-hooks branch 2 times, most recently from 441529e to af53d8f Compare October 30, 2025 09:56

KarhouTam mentioned this pull request Oct 31, 2025

[OpenReg][Feat][Docs] Enrich OpenReg device management implementation and add focused documentation #165897

Closed

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 12, 2025

KarhouTam marked this pull request as ready for review November 12, 2025 08:30

fffrog reviewed Nov 12, 2025

View reviewed changes

test/cpp_extensions/open_registration_extension/torch_openreg/csrc/runtime/OpenRegHooks.h Show resolved Hide resolved

fffrog reviewed Nov 12, 2025

View reviewed changes

docs/source/accelerator/hooks.md Show resolved Hide resolved

fffrog reviewed Nov 12, 2025

View reviewed changes

docs/source/accelerator/hooks.md Outdated Show resolved Hide resolved

fffrog reviewed Nov 12, 2025

View reviewed changes

docs/source/accelerator/hooks.md Outdated Show resolved Hide resolved

soulitzer requested a review from albanD November 13, 2025 01:10

soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 13, 2025

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Nov 13, 2025

fffrog reviewed Nov 13, 2025

View reviewed changes

docs/source/accelerator/hooks.md Show resolved Hide resolved

fffrog approved these changes Nov 13, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 13, 2025

pytorchmergebot added the merging label Nov 13, 2025

pytorchmergebot removed the merging label Nov 13, 2025

KarhouTam and others added 5 commits November 13, 2025 06:25

Add Accelerator Hooks documentation and enrich OpenReg hooks implemen…

0bdce7b

…tation

Update docs/source/accelerator/index.md

fdccd1f

Co-authored-by: Jiawei Li <ljw1101.vip@gmail.com>

Enhance OpenReg hooks documentation and implementation details for be…

66ff674

…tter clarity and usability

Add init method to OpenRegHooksInterface for runtime initialization

1535d86

Enhance documentation for accelerator hooks by categorizing hooks int…

56405e6

…o high and low priority levels for better clarity and guidance for vendors.

pytorchmergebot force-pushed the openreg-hooks branch from 8f27f61 to 56405e6 Compare November 13, 2025 06:25

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Nov 13, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 13, 2025

pytorchmergebot added the merging label Nov 13, 2025

pytorchmergebot added the Merged label Nov 13, 2025

pytorchmergebot closed this in ce4f31f Nov 13, 2025

pytorchmergebot removed the merging label Nov 13, 2025

KarhouTam deleted the openreg-hooks branch November 14, 2025 12:33

Conversation

KarhouTam commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Key Changes

Uh oh!

pytorch-bot bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165980

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

KarhouTam commented Oct 21, 2025

Uh oh!

Uh oh!

Uh oh!

KarhouTam commented Nov 12, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fffrog commented Nov 13, 2025

Uh oh!

KarhouTam commented Nov 13, 2025

Uh oh!

pytorchmergebot commented Nov 13, 2025

Merge started

Uh oh!

KarhouTam commented Nov 13, 2025

Uh oh!

pytorchmergebot commented Nov 13, 2025

Merge failed

Uh oh!

KarhouTam commented Nov 13, 2025

Uh oh!

pytorchmergebot commented Nov 13, 2025

Uh oh!

pytorchmergebot commented Nov 13, 2025

Uh oh!

KarhouTam commented Nov 13, 2025

Uh oh!

pytorchmergebot commented Nov 13, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

KarhouTam commented Oct 21, 2025 •

edited

Loading

pytorch-bot bot commented Oct 21, 2025 •

edited

Loading