[PP] Customize pipeline's submod name#164037
[PP] Customize pipeline's submod name#164037kwen2501 wants to merge 3 commits intogh/kwen2501/266/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164037
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit cea5fb3 with merge base 8d81564 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| # TODO: what does split do with module invocations? does it move the modules | ||
| # into the submodules? | ||
| split = split_module(traced, mod, split_callback) # type: ignore[arg-type] | ||
| split = split_module(traced, mod, split_callback, partition_affix="pp") # type: ignore[arg-type] |
There was a problem hiding this comment.
not sure if we have tests validating the submod name after splitting, might be good to have. Can do it in a followup PR
There was a problem hiding this comment.
These are internal settings. And users are supposed to get submodules via:
pipe.get_stage_module(i).
If existing tests passed, we should be fine.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
|
@pytorchbot merge -f "previous merge timed out" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This reverts commit 704cd77. Reverted #164037 on behalf of https://github.com/yangw-dev due to internal build failed Buck build failed for this target, and is likely caused by your changes. ([comment](#164035 (comment)))
|
@pytorchbot successfully started a revert job. Check the current status here. |
Reverting PR 164037 failedReason: Comment with id 3357166994 not found Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "internal signal succeeded upon retry" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This reverts commit 704cd77. Reverted pytorch#164037 on behalf of https://github.com/yangw-dev due to internal build failed Buck build failed for this target, and is likely caused by your changes. ([comment](pytorch#164035 (comment)))
Changing PP submodules' name from `submod_i` to `submod_pp_i` to distinguish from the submodule created by HOP. Pull Request resolved: pytorch#164037 Approved by: https://github.com/H-Huang ghstack dependencies: pytorch#164045, pytorch#164035
ghstack-source-id: 817266f Pull-Request: pytorch/pytorch#164037
Stack from ghstack (oldest at bottom):
Changing PP submodules' name from
submod_itosubmod_pp_ito distinguish from the submodule created by HOP.cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci