[fx] Allow customization of submod name in split graph#164035
[fx] Allow customization of submod name in split graph#164035kwen2501 wants to merge 3 commits intogh/kwen2501/265/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164035
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 32 PendingAs of commit 572a163 with merge base 8d81564 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| keep_original_order: Optional[bool] = False, | ||
| keep_original_node_name: Optional[bool] = False, | ||
| keep_original_input_name: bool = True, | ||
| partition_affix: Optional[str] = None, |
There was a problem hiding this comment.
Consider making this kwarg only
There was a problem hiding this comment.
Why is this "affix" and not "prefix"?
There was a problem hiding this comment.
Because the eventual submod name will be submod_abc_i, where abc is the added argument here. I don't want to give user an illusion that their new submod starts with abc.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Changing PP submodules' name from `submod_i` to `submod_pp_i` to distinguish from the submodule created by HOP. Pull Request resolved: #164037 Approved by: https://github.com/H-Huang ghstack dependencies: #164045, #164035
|
@pytorchbot revert -m "internal build failed Buck build failed for this target, and is likely caused by your changes." -c ghfirst |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
Halting the revert as the revert comment has been edited. |
|
@pytorchbot revert -m "internal build failed Buck build failed for this target, and is likely caused by your changes." -c ghfirst |
|
the associated internal task D83479121 |
|
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 704cd77. Reverted #164037 on behalf of https://github.com/yangw-dev due to internal build failed Buck build failed for this target, and is likely caused by your changes. ([comment](#164035 (comment)))
…)" This reverts commit 615da7b. Reverted #164035 on behalf of https://github.com/yangw-dev due to internal build failed Buck build failed for this target, and is likely caused by your changes. ([comment](#164035 (comment)))
|
@kwen2501 your PR has been successfully reverted. |
|
@pytorchbot merge -f "internal signal succeeded upon retry" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Changing PP submodules' name from `submod_i` to `submod_pp_i` to distinguish from the submodule created by HOP. Pull Request resolved: #164037 Approved by: https://github.com/H-Huang ghstack dependencies: #164045, #164035
This reverts commit 704cd77. Reverted pytorch#164037 on behalf of https://github.com/yangw-dev due to internal build failed Buck build failed for this target, and is likely caused by your changes. ([comment](pytorch#164035 (comment)))
…ch#164035)" This reverts commit 615da7b. Reverted pytorch#164035 on behalf of https://github.com/yangw-dev due to internal build failed Buck build failed for this target, and is likely caused by your changes. ([comment](pytorch#164035 (comment)))
Fixes pytorch#164030: HOP and pipelining both name things submod_i by adding an optional argument `partition_affix` to `split_module` API. Pull Request resolved: pytorch#164035 Approved by: https://github.com/ezyang ghstack dependencies: pytorch#164045
Changing PP submodules' name from `submod_i` to `submod_pp_i` to distinguish from the submodule created by HOP. Pull Request resolved: pytorch#164037 Approved by: https://github.com/H-Huang ghstack dependencies: pytorch#164045, pytorch#164035
ghstack-source-id: 75c6902 Pull-Request: pytorch/pytorch#164035
Stack from ghstack (oldest at bottom):
Fixes #164030: HOP and pipelining both name things submod_i
by adding an optional argument
partition_affixtosplit_moduleAPI.cc @ezyang @EikanWang @jgong5 @wenzhe-nrv