Skip to content

[CP][BE] Correct an incorrect docstring#163131

Closed
fegin wants to merge 2 commits intogh/fegin/320/basefrom
gh/fegin/320/head
Closed

[CP][BE] Correct an incorrect docstring#163131
fegin wants to merge 2 commits intogh/fegin/320/basefrom
gh/fegin/320/head

Conversation

@fegin
Copy link
Contributor

@fegin fegin commented Sep 17, 2025 •
edited
Loading

@fegin
Update
efaf042 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Sep 17, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163131

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit c07d763 with merge base 7a0f933 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Sep 17, 2025
This was referenced Sep 17, 2025
Closed
Closed
Closed
Closed
Closed
@fegin fegin changed the title [CP] Correct an incorrect docstring [CP][BE] Correct an incorrect docstring Sep 17, 2025
@fegin fegin added the topic: not user facing topic category label Sep 17, 2025
@fegin fegin mentioned this pull request Sep 17, 2025
Closed
@fegin
Update
c07d763 
[ghstack-poisoned]
@fegin fegin mentioned this pull request Sep 18, 2025
Closed
@fegin
Copy link
Contributor Author

fegin commented Sep 19, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 19, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 19, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 19, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / test (default, 2, 3, macos-m1-stable)

Details for Dev Infra team Raised by workflow job

@fegin
Copy link
Contributor Author

fegin commented Sep 19, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 19, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Sep 20, 2025
@fegin @pytorchmergebot
[CP] Fix cuDNN CP LSE dimension bug (#163231)
d55c9d5 
We should only unsqueeze if necessary.

Fix #162743

Pull Request resolved: #163231
Approved by: https://github.com/eqy
ghstack dependencies: #162539, #162540, #162541, #163115, #163131
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@fegin @mansiag05
[CP][BE] Correct an incorrect docstring (pytorch#163131)
d148bd2 
Pull Request resolved: pytorch#163131
Approved by: https://github.com/tianyu-l, https://github.com/XilunWu
ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@fegin @mansiag05
[CP] Fix cuDNN CP LSE dimension bug (pytorch#163231)
b49fdb0 
We should only unsqueeze if necessary.

Fix pytorch#162743

Pull Request resolved: pytorch#163231
Approved by: https://github.com/eqy
ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115, pytorch#163131
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@fegin @cleonard530
[CP][BE] Correct an incorrect docstring (pytorch#163131)
0d0e820 
Pull Request resolved: pytorch#163131
Approved by: https://github.com/tianyu-l, https://github.com/XilunWu
ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
@fegin @cleonard530
[CP] Fix cuDNN CP LSE dimension bug (pytorch#163231)
74f16c2 
We should only unsqueeze if necessary.

Fix pytorch#162743

Pull Request resolved: pytorch#163231
Approved by: https://github.com/eqy
ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115, pytorch#163131
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fegin @dsashidh
[CP][BE] Correct an incorrect docstring (pytorch#163131)
cc3feee 
Pull Request resolved: pytorch#163131
Approved by: https://github.com/tianyu-l, https://github.com/XilunWu
ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@fegin @dsashidh
[CP] Fix cuDNN CP LSE dimension bug (pytorch#163231)
c49d1a8 
We should only unsqueeze if necessary.

Fix pytorch#162743

Pull Request resolved: pytorch#163231
Approved by: https://github.com/eqy
ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115, pytorch#163131
@github-actions github-actions bot deleted the gh/fegin/320/head branch October 20, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XilunWu XilunWu XilunWu approved these changes

@tianyu-l tianyu-l tianyu-l approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fegin @pytorchmergebot @XilunWu @tianyu-l