[CP][BE] Correct the names of some tests#162541
Closed
fegin wants to merge 7 commits intogh/fegin/317/basefrom
Closed
[CP][BE] Correct the names of some tests#162541fegin wants to merge 7 commits intogh/fegin/317/basefrom
fegin wants to merge 7 commits intogh/fegin/317/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162541
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit f5dbc5b with merge base 7a0f933 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 9, 2025
ezyang
approved these changes
Sep 10, 2025
Skylion007
approved these changes
Sep 10, 2025
This was referenced Sep 16, 2025
tianyu-l
approved these changes
Sep 17, 2025
XilunWu
approved these changes
Sep 18, 2025
Contributor
Author
|
@pytorchbot merge -f "the failing test is not related." |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 19, 2025
Pull Request resolved: #163131 Approved by: https://github.com/tianyu-l, https://github.com/XilunWu ghstack dependencies: #162539, #162540, #162541, #163115
pytorchmergebot
pushed a commit
that referenced
this pull request
Sep 20, 2025
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
We are not doing ring attention but only using allgather to do CP for Flex. Pull Request resolved: pytorch#162541 Approved by: https://github.com/ezyang, https://github.com/Skylion007, https://github.com/tianyu-l, https://github.com/XilunWu ghstack dependencies: pytorch#162539, pytorch#162540
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Summary: This PR is extracted from pytorch#162542, to make the original PR easier to review. This PR only contains cosmetic changes. Pull Request resolved: pytorch#163115 Approved by: https://github.com/tianyu-l ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Pull Request resolved: pytorch#163131 Approved by: https://github.com/tianyu-l, https://github.com/XilunWu ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
We should only unsqueeze if necessary. Fix pytorch#162743 Pull Request resolved: pytorch#163231 Approved by: https://github.com/eqy ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115, pytorch#163131
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
We are not doing ring attention but only using allgather to do CP for Flex. Pull Request resolved: pytorch#162541 Approved by: https://github.com/ezyang, https://github.com/Skylion007, https://github.com/tianyu-l, https://github.com/XilunWu ghstack dependencies: pytorch#162539, pytorch#162540
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
Summary: This PR is extracted from pytorch#162542, to make the original PR easier to review. This PR only contains cosmetic changes. Pull Request resolved: pytorch#163115 Approved by: https://github.com/tianyu-l ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
Pull Request resolved: pytorch#163131 Approved by: https://github.com/tianyu-l, https://github.com/XilunWu ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
We should only unsqueeze if necessary. Fix pytorch#162743 Pull Request resolved: pytorch#163231 Approved by: https://github.com/eqy ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115, pytorch#163131
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
We are not doing ring attention but only using allgather to do CP for Flex. Pull Request resolved: pytorch#162541 Approved by: https://github.com/ezyang, https://github.com/Skylion007, https://github.com/tianyu-l, https://github.com/XilunWu ghstack dependencies: pytorch#162539, pytorch#162540
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
Summary: This PR is extracted from pytorch#162542, to make the original PR easier to review. This PR only contains cosmetic changes. Pull Request resolved: pytorch#163115 Approved by: https://github.com/tianyu-l ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
Pull Request resolved: pytorch#163131 Approved by: https://github.com/tianyu-l, https://github.com/XilunWu ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
We should only unsqueeze if necessary. Fix pytorch#162743 Pull Request resolved: pytorch#163231 Approved by: https://github.com/eqy ghstack dependencies: pytorch#162539, pytorch#162540, pytorch#162541, pytorch#163115, pytorch#163131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
We are not doing ring attention but only using allgather to do CP for Flex.
cc @H-Huang @awgu @wanchaol @fduwjj @wz337 @wconstab @d4l3k @pragupta @ezyang @msaroufim @dcci