[ONNX] Remove private members from torch.onnx by justinchuby · Pull Request #161546 · pytorch/pytorch

justinchuby · 2025-08-26T21:42:47Z

Stack from ghstack (oldest at bottom):

Remove import of two functions

_run_symbolic_function
_run_symbolic_method

to the torch.onnx namespace.

Signed-off-by: Justin Chu justinchuby@users.noreply.github.com

[ghstack-poisoned]

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: cecd561 Pull Request resolved: #161546

pytorch-bot · 2025-08-26T21:42:53Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161546

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

ROCm MI2xx CI/CD workflows failing due to : download from https://api.github.com/repos/pytorch/pytorch timed out.

✅ No Failures

As of commit 56dd397 with merge base 378edb0 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: cecd561 Pull Request resolved: #161546 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

[ghstack-poisoned]

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 515fe2d Pull Request resolved: #161546 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

[ghstack-poisoned]

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: a0f4338 Pull Request resolved: #161546 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

[ghstack-poisoned]

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 62d1d78 Pull Request resolved: #161546 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

[ghstack-poisoned]

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: e7e01a7 Pull Request resolved: #161546 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

[ghstack-poisoned]

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: e98336a Pull Request resolved: #161546 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

[ghstack-poisoned]

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: 1bf0c12 Pull Request resolved: #161546 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

[ghstack-poisoned]

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> ghstack-source-id: ddf0f9c Pull Request resolved: #161546 Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

justinchuby · 2025-09-02T16:05:11Z

@pytorchbot merge

pytorchmergebot · 2025-09-02T16:06:53Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-09-02T16:12:42Z

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x b7eac6f1e71da39b64294920ea6fde0489095967 returned non-zero exit code 1

CONFLICT (modify/delete): test/onnx/test_verification.py deleted in b7eac6f1e71 ([ONNX] Remove unused logic from internal verification module) and modified in HEAD.  Version HEAD of test/onnx/test_verification.py left in tree.
CONFLICT (modify/delete): torch/onnx/_internal/torchscript_exporter/verification.py deleted in HEAD and modified in b7eac6f1e71 ([ONNX] Remove unused logic from internal verification module).  Version b7eac6f1e71 ([ONNX] Remove unused logic from internal verification module) of torch/onnx/_internal/torchscript_exporter/verification.py left in tree.
error: could not apply b7eac6f1e71... [ONNX] Remove unused logic from internal verification module
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"

Details for Dev Infra team

Raised by workflow job

justinchuby · 2025-09-02T16:23:32Z

@pytorchbot merge

pytorchmergebot · 2025-09-02T16:25:39Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Remove import of two functions - _run_symbolic_function - _run_symbolic_method to the `torch.onnx` namespace. Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com> Pull Request resolved: pytorch#161546 Approved by: https://github.com/titaiwangms ghstack dependencies: pytorch#161323, pytorch#161449

Update

832a4ef

[ghstack-poisoned]

justinchuby requested a review from titaiwangms as a code owner August 26, 2025 21:42

This was referenced Aug 26, 2025

[ONNX] Refactor torchscript based exporter #161323

Closed

[ONNX] Remove unused logic from internal verification module #161449

Closed

pytorch-bot Bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Aug 26, 2025

facebook-github-bot added the oncall: jit Add this issue/PR to JIT oncall triage queue label Aug 26, 2025

pytorchbot added the open source label Aug 26, 2025

Update

b43df30

[ghstack-poisoned]

Update

1945536

[ghstack-poisoned]

Update

c8b5e42

[ghstack-poisoned]

justinchuby added module: onnx Related to torch.onnx topic: not user facing topic category and removed oncall: jit Add this issue/PR to JIT oncall triage queue labels Aug 26, 2025

Update

93abbca

[ghstack-poisoned]

Update

95694df

[ghstack-poisoned]

Update

3f047d4

[ghstack-poisoned]

titaiwangms approved these changes Aug 28, 2025

View reviewed changes

Comment thread torch/csrc/jit/passes/onnx.cpp

Update

56dd397

[ghstack-poisoned]

justinchuby added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 29, 2025

pytorchmergebot added the merging label Sep 2, 2025

pytorchmergebot removed the merging label Sep 2, 2025

pytorchmergebot added the merging label Sep 2, 2025

pytorchmergebot added the Merged label Sep 2, 2025

pytorchmergebot closed this in f0c3911 Sep 2, 2025

pytorchmergebot removed the merging label Sep 2, 2025

github-actions Bot deleted the gh/justinchuby/115/head branch October 3, 2025 02:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ONNX] Remove private members from torch.onnx#161546

[ONNX] Remove private members from torch.onnx#161546
justinchuby wants to merge 8 commits intogh/justinchuby/115/basefrom
gh/justinchuby/115/head

justinchuby commented Aug 26, 2025 •

edited

Loading

Uh oh!

pytorch-bot Bot commented Aug 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

justinchuby commented Sep 2, 2025

Uh oh!

pytorchmergebot commented Sep 2, 2025

Uh oh!

pytorchmergebot commented Sep 2, 2025

Uh oh!

justinchuby commented Sep 2, 2025

Uh oh!

pytorchmergebot commented Sep 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

justinchuby commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot Bot commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161546

❗ 1 Active SEVs

✅ No Failures

Uh oh!

Uh oh!

justinchuby commented Sep 2, 2025

Uh oh!

pytorchmergebot commented Sep 2, 2025

Merge started

Uh oh!

pytorchmergebot commented Sep 2, 2025

Merge failed

Uh oh!

justinchuby commented Sep 2, 2025

Uh oh!

pytorchmergebot commented Sep 2, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

justinchuby commented Aug 26, 2025 •

edited

Loading

pytorch-bot Bot commented Aug 26, 2025 •

edited

Loading