Skip to content

[ONNX] Remove unused logic from internal verification module#161449

Closed
justinchuby wants to merge 15 commits intogh/justinchuby/114/basefrom
gh/justinchuby/114/head
Closed

[ONNX] Remove unused logic from internal verification module#161449
justinchuby wants to merge 15 commits intogh/justinchuby/114/basefrom
gh/justinchuby/114/head

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Aug 25, 2025 •
edited
Loading

@justinchuby
Update
f962fb0 
[ghstack-poisoned]
@justinchuby justinchuby mentioned this pull request Aug 25, 2025
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 25, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161449

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (1 Unrelated Failure)

As of commit 309a56e with merge base 378edb0 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added release notes: onnx torch.onnx related changes that should show up in the release notes labels Aug 25, 2025
justinchuby added a commit that referenced this pull request Aug 25, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
1f4cdaa 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 82e23a0
Pull Request resolved: #161449
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Aug 25, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
55a2729 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 82e23a0
Pull Request resolved: pytorch#161449
@justinchuby
Update
a354e85 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 25, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
fae16be 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 20b866e
Pull Request resolved: #161449
@justinchuby
Update
a851be2 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 25, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
81913c7 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: e0c6693
Pull Request resolved: #161449
@justinchuby
Update
9c8fd44 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 25, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
dad45ce 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 573a0a9
Pull Request resolved: #161449
@justinchuby
Update
5614a3b 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 26, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
0d21621 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: b8eb1f7
Pull Request resolved: #161449
@justinchuby
Update
c0eb3f5 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 26, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
11cf65d 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 64b0124
Pull Request resolved: #161449
@justinchuby
Update
2c6c91c 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 26, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
b93748a 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: eff90e2
Pull Request resolved: #161449
@justinchuby
Update
1e0682b 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 26, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
103c13f 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 1de47fe
Pull Request resolved: #161449
@justinchuby justinchuby added module: onnx Related to torch.onnx topic: not user facing topic category labels Aug 26, 2025
@justinchuby
Update
a14cdcc 
[ghstack-poisoned]
justinchuby added a commit that referenced this pull request Aug 26, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
48782c8 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: b8accf2
Pull Request resolved: #161449
@justinchuby justinchuby mentioned this pull request Aug 26, 2025
Closed
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Aug 26, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
fcb50b8 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: b8accf2
Pull Request resolved: pytorch#161449
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Aug 27, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
d1285e8 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 8e5129e
Pull Request resolved: pytorch#161449
@justinchuby
Update
59e3a18 
[ghstack-poisoned]
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Aug 27, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
0b626e2 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: d1cf6fc
Pull Request resolved: pytorch#161449
@justinchuby
Update
44bd5b2 
[ghstack-poisoned]
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Aug 27, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
1e568a3 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: 4d8210f
Pull Request resolved: pytorch#161449
titaiwangms
titaiwangms approved these changes Aug 28, 2025
View reviewed changes
Copy link
Collaborator

@titaiwangms titaiwangms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is bc breaking.

@justinchuby
Copy link
Collaborator Author

justinchuby commented Aug 29, 2025

This is bc breaking.

The first PR breaks BC. This PR does the clean up

@justinchuby
Update
309a56e 
[ghstack-poisoned]
@justinchuby justinchuby added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 29, 2025
justinchuby added a commit to justinchuby/pytorch that referenced this pull request Aug 29, 2025
@justinchuby
[ONNX] Remove unused logic from internal verification module
b7eac6f 
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

ghstack-source-id: fa72c2b
Pull Request resolved: pytorch#161449
@justinchuby
Copy link
Collaborator Author

justinchuby commented Sep 2, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 2, 2025

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 2, 2025

Starting merge as part of PR stack under #161546

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 2, 2025

Merge failed

Reason: Command git -C /home/runner/work/pytorch/pytorch cherry-pick -x b7eac6f1e71da39b64294920ea6fde0489095967 returned non-zero exit code 1

CONFLICT (modify/delete): test/onnx/test_verification.py deleted in b7eac6f1e71 ([ONNX] Remove unused logic from internal verification module) and modified in HEAD.  Version HEAD of test/onnx/test_verification.py left in tree.
CONFLICT (modify/delete): torch/onnx/_internal/torchscript_exporter/verification.py deleted in HEAD and modified in b7eac6f1e71 ([ONNX] Remove unused logic from internal verification module).  Version b7eac6f1e71 ([ONNX] Remove unused logic from internal verification module) of torch/onnx/_internal/torchscript_exporter/verification.py left in tree.
error: could not apply b7eac6f1e71... [ONNX] Remove unused logic from internal verification module
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

@justinchuby
Copy link
Collaborator Author

justinchuby commented Sep 2, 2025

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Sep 2, 2025

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / macos-py3-arm64 / test (mps, 1, 1, macos-m2-15)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Sep 2, 2025
@justinchuby @pytorchmergebot
[ONNX] Remove private members from torch.onnx (#161546)
f0c3911 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

Pull Request resolved: #161546
Approved by: https://github.com/titaiwangms
ghstack dependencies: #161323, #161449
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@justinchuby @markc-614
[ONNX] Remove unused logic from internal verification module (pytorch…
67de2eb 
…#161449)

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

Pull Request resolved: pytorch#161449
Approved by: https://github.com/xadupre, https://github.com/titaiwangms
ghstack dependencies: pytorch#161323
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@justinchuby @markc-614
[ONNX] Remove private members from torch.onnx (pytorch#161546)
819ba76 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

Pull Request resolved: pytorch#161546
Approved by: https://github.com/titaiwangms
ghstack dependencies: pytorch#161323, pytorch#161449
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@justinchuby @mansiag05
[ONNX] Remove unused logic from internal verification module (pytorch…
c4315b5 
…#161449)

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

Pull Request resolved: pytorch#161449
Approved by: https://github.com/xadupre, https://github.com/titaiwangms
ghstack dependencies: pytorch#161323
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
@justinchuby @mansiag05
[ONNX] Remove private members from torch.onnx (pytorch#161546)
658b41b 
Remove import of two functions

- _run_symbolic_function
- _run_symbolic_method

to the `torch.onnx` namespace.

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

Pull Request resolved: pytorch#161546
Approved by: https://github.com/titaiwangms
ghstack dependencies: pytorch#161323, pytorch#161449
@github-actions github-actions bot deleted the gh/justinchuby/114/head branch October 3, 2025 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@titaiwangms titaiwangms titaiwangms approved these changes

+1 more reviewer

@xadupre xadupre xadupre approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinchuby @pytorchmergebot @titaiwangms @xadupre @pytorchbot