Skip to content

Bump onnxscript to 0.4.0 in CI#161312

Closed
justinchuby wants to merge 3 commits intomainfrom
justinchu/onnx-apiv
Closed

Bump onnxscript to 0.4.0 in CI#161312
justinchuby wants to merge 3 commits intomainfrom
justinchu/onnx-apiv

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Aug 22, 2025 •
edited by pytorch-bot bot
Loading

Use onnxscript apis for torch 2.9.

cc @titaiwangms

@justinchuby
Bump onnxscript to 0.4.0 in CI
57cbd35 
Use apis for torch 2.9
@justinchuby justinchuby requested a review from jeffdaily as a code owner August 22, 2025 21:13
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161312

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 19 Pending

As of commit 23269c5 with merge base 3f1a97a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 22, 2025
@justinchuby justinchuby requested a review from malfet August 22, 2025 21:15
@justinchuby
Copy link
Collaborator Author

justinchuby commented Aug 22, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 22, 2025
@justinchuby justinchuby added the module: onnx Related to torch.onnx label Aug 22, 2025
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 22, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby justinchuby mentioned this pull request Aug 22, 2025
Closed
@justinchuby
Copy link
Collaborator Author

justinchuby commented Aug 22, 2025

@pytorchbot merge -f "onnx tests passed"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 22, 2025

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Aug 22, 2025

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby justinchuby deleted the justinchu/onnx-apiv branch August 23, 2025 00:10
pytorchmergebot pushed a commit that referenced this pull request Aug 23, 2025
@justinchuby @pytorchmergebot
[ONNX] Fix lower opset version support in dynamo=True (#161056)
36ac916 
After we switched to constructing the registry with the specified opset version in dynamo=True, support for opset<18 was broken because there would be no torchlib ops registered for these opsets. I updated the registry creation logic to always use opset 18 if the requested opset is lower, and use the version converter (as designed) to target those opsets.

This requires onnxscript>=0.4 (#161312)

Fixes onnx/onnx#7235

Pull Request resolved: #161056
Approved by: https://github.com/titaiwangms
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@justinchuby @markc-614
Bump onnxscript to 0.4.0 in CI (pytorch#161312)
1a9eec1 
Use onnxscript apis for torch 2.9.

Pull Request resolved: pytorch#161312
Approved by: https://github.com/titaiwangms, https://github.com/malfet
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@justinchuby @markc-614
[ONNX] Fix lower opset version support in dynamo=True (pytorch#161056)
d9da7c1 
After we switched to constructing the registry with the specified opset version in dynamo=True, support for opset<18 was broken because there would be no torchlib ops registered for these opsets. I updated the registry creation logic to always use opset 18 if the requested opset is lower, and use the version converter (as designed) to target those opsets.

This requires onnxscript>=0.4 (pytorch#161312)

Fixes onnx/onnx#7235

Pull Request resolved: pytorch#161056
Approved by: https://github.com/titaiwangms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@titaiwangms titaiwangms titaiwangms approved these changes

@jeffdaily jeffdaily Awaiting requested review from jeffdaily jeffdaily is a code owner

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@justinchuby @pytorchmergebot @malfet @titaiwangms @pytorchbot