[ONNX] Fix lower opset version support in dynamo=True by justinchuby · Pull Request #161056 · pytorch/pytorch

justinchuby · 2025-08-20T14:21:44Z

After we switched to constructing the registry with the specified opset version in dynamo=True, support for opset<18 was broken because there would be no torchlib ops registered for these opsets. I updated the registry creation logic to always use opset 18 if the requested opset is lower, and use the version converter (as designed) to target those opsets.

This requires onnxscript>=0.4 (#161312)

Fixes onnx/onnx#7235

cc @titaiwangms

pytorch-bot · 2025-08-20T14:21:47Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161056

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 171f3f0 with merge base d228a77 ():

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

pull / linux-jammy-py3.10-clang12 / test (dynamo_wrapped, 3, 3, lf.linux.2xlarge) (gh) (trunk failure)
test_jit.py::TestScript::test_static_method_on_module

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copilot

Pull Request Overview

This PR fixes support for ONNX opset versions lower than 18 when using dynamo=True by ensuring the torchlib registry is always constructed with opset 18 or higher, then relying on version conversion to target lower opsets.

Key changes:

Modified registry creation logic to use _constants.TORCHLIB_OPSET (18) when requested opset is lower
Added informational logging when falling back to higher opset version
Added test coverage for lower opset version support with opset 16

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
torch/onnx/_internal/exporter/_compat.py	Updated registry creation logic to handle lower opset versions and added logging
test/onnx/exporter/test_api.py	Added test model and test case to verify opset 16 support works correctly

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

test/onnx/exporter/test_api.py

titaiwangms

I wonder if we should consider supporting the opset_version < 18.

torch/onnx/_internal/exporter/_compat.py

justinchuby · 2025-08-20T15:49:40Z

I wonder if we should consider supporting the opset_version < 18.

We do that via version converter. Or do you mean implementing the ops directly? Even opset 18 is kind of old at this point though

torch/onnx/_internal/exporter/_compat.py

titaiwangms · 2025-08-20T15:53:11Z

I wonder if we should consider supporting the opset_version < 18.

We do that via version converter. Or do you mean implementing the ops directly? Even opset 18 is kind of old at this point though

I forget about how version converter does on converting opset to < 18. Does it only do its best? (It fails for attribute changed ops, for example, ReduceMean?)

justinchuby · 2025-08-20T16:06:22Z

I wonder if we should consider supporting the opset_version < 18.

We do that via version converter. Or do you mean implementing the ops directly? Even opset 18 is kind of old at this point though

I forget about how version converter does on converting opset to < 18. Does it only do its best? (It fails for attribute changed ops, for example, ReduceMean?)

I think so

justinchuby · 2025-08-23T00:09:26Z

@pytorchbot rebase

pytorchmergebot · 2025-08-23T00:10:57Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

pytorchmergebot · 2025-08-23T00:11:00Z

Successfully rebased justinchu/opset-version onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout justinchu/opset-version && git pull --rebase)

justinchuby · 2025-08-23T00:13:07Z

@pytorchbot merge

pytorchmergebot · 2025-08-23T00:14:55Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-08-23T00:41:27Z

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

pull / linux-jammy-py3.10-clang12-onnx / test (default, 2, 2, lf.linux.2xlarge)

Dig deeper by viewing the failures on hud

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

justinchuby · 2025-08-23T02:11:23Z

@pytorchbot merge

pytorchmergebot · 2025-08-23T02:13:06Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

pytorchmergebot · 2025-08-23T02:18:26Z

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team

Raised by workflow job

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

justinchuby · 2025-08-23T02:24:20Z

@pytorchbot merge

pytorchmergebot · 2025-08-23T02:26:00Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

After we switched to constructing the registry with the specified opset version in dynamo=True, support for opset<18 was broken because there would be no torchlib ops registered for these opsets. I updated the registry creation logic to always use opset 18 if the requested opset is lower, and use the version converter (as designed) to target those opsets. This requires onnxscript>=0.4 (pytorch#161312) Fixes onnx/onnx#7235 Pull Request resolved: pytorch#161056 Approved by: https://github.com/titaiwangms

justinchuby requested a review from titaiwangms as a code owner August 20, 2025 14:21

pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Aug 20, 2025

justinchuby requested a review from Copilot August 20, 2025 14:21

justinchuby added module: onnx Related to torch.onnx topic: bug fixes topic category labels Aug 20, 2025

Copilot AI reviewed Aug 20, 2025

View reviewed changes

test/onnx/exporter/test_api.py Outdated Show resolved Hide resolved

justinchuby changed the title ~~[ONNX] Fix lower version support in dynamo=True~~ [ONNX] Fix lower opset version support in dynamo=True Aug 20, 2025

pytorchbot added the open source label Aug 20, 2025

titaiwangms approved these changes Aug 20, 2025

View reviewed changes

torch/onnx/_internal/exporter/_compat.py Outdated Show resolved Hide resolved

justinchuby commented Aug 20, 2025

View reviewed changes

torch/onnx/_internal/exporter/_compat.py Outdated Show resolved Hide resolved

justinchuby commented Aug 20, 2025

View reviewed changes

torch/onnx/_internal/exporter/_compat.py Outdated Show resolved Hide resolved

pytorchmergebot force-pushed the justinchu/opset-version branch from 5973ac0 to de50d28 Compare August 23, 2025 00:11

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 23, 2025

pytorchmergebot added the merging label Aug 23, 2025

pytorchmergebot removed the merging label Aug 23, 2025

justinchuby added 4 commits August 22, 2025 19:10

[ONNX] Fix lower version support in dynamo=True

5fb1429

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

Tests

3a2e732

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

test

d130b9b

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

lint

5df8fb6

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

justinchuby force-pushed the justinchu/opset-version branch from de50d28 to 5df8fb6 Compare August 23, 2025 02:10

pytorchmergebot added the merging label Aug 23, 2025

justinchuby added 2 commits August 22, 2025 19:16

Update logger

be05294

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

msg

7f5d0aa

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

pytorchmergebot removed the merging label Aug 23, 2025

docs

171f3f0

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>

pytorchmergebot added the merging label Aug 23, 2025

pytorchmergebot added the Merged label Aug 23, 2025

pytorchmergebot closed this in 36ac916 Aug 23, 2025

pytorchmergebot removed the merging label Aug 23, 2025

justinchuby deleted the justinchu/opset-version branch August 23, 2025 13:46

Conversation

justinchuby commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161056

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

titaiwangms left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

justinchuby commented Aug 20, 2025

Uh oh!

Uh oh!

Uh oh!

titaiwangms commented Aug 20, 2025

Uh oh!

justinchuby commented Aug 20, 2025

Uh oh!

justinchuby commented Aug 23, 2025

Uh oh!

pytorchmergebot commented Aug 23, 2025

Uh oh!

pytorchmergebot commented Aug 23, 2025

Uh oh!

justinchuby commented Aug 23, 2025

Uh oh!

pytorchmergebot commented Aug 23, 2025

Merge started

Uh oh!

pytorchmergebot commented Aug 23, 2025

Merge failed

Uh oh!

justinchuby commented Aug 23, 2025

Uh oh!

pytorchmergebot commented Aug 23, 2025

Merge started

Uh oh!

pytorchmergebot commented Aug 23, 2025

Merge failed

Uh oh!

justinchuby commented Aug 23, 2025

Uh oh!

pytorchmergebot commented Aug 23, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

justinchuby commented Aug 20, 2025 •

edited

Loading

pytorch-bot bot commented Aug 20, 2025 •

edited

Loading