Skip to content

[BE] Enable test_index_put_accumulate_duplicate_indices on MPS#161201

Closed
malfet wants to merge 1 commit intogh/malfet/497/basefrom
gh/malfet/497/head
Closed

[BE] Enable test_index_put_accumulate_duplicate_indices on MPS#161201
malfet wants to merge 1 commit intogh/malfet/497/basefrom
gh/malfet/497/head

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Aug 21, 2025

Stack from ghstack (oldest at bottom):

By changing dtype to float if device is MPS

Note: for some reason test runs much longer on MPS than on CPU

% python ../test/test_indexing.py -v -k test_index_put_accumulate_duplicate_indices_mps
test_index_put_accumulate_duplicate_indices_mps (__main__.TestIndexingMPS.test_index_put_accumulate_duplicate_indices_mps) ... ok

----------------------------------------------------------------------
Ran 1 test in 9.139s

OK

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161201

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 34 Pending

As of commit 0938d45 with merge base 3e3e834 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 21, 2025
malfet added a commit that referenced this pull request Aug 21, 2025
By changing dtype to float if device is MPS

Note: for some reason test runs much longer on MPS than on CPU
```
% python ../test/test_indexing.py -v -k test_index_put_accumulate_duplicate_indices_mps
test_index_put_accumulate_duplicate_indices_mps (__main__.TestIndexingMPS.test_index_put_accumulate_duplicate_indices_mps) ... ok

----------------------------------------------------------------------
Ran 1 test in 9.139s

OK
```

ghstack-source-id: 980a237
Pull Request resolved: #161201
@malfet malfet requested a review from dcci August 21, 2025 21:28
@malfet malfet added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 21, 2025
@malfet
Copy link
Contributor Author

malfet commented Aug 21, 2025

@pytorchbot merge -f "Lint is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

wincent8 pushed a commit to wincent8/pytorch that referenced this pull request Aug 22, 2025
…orch#161201)

By changing dtype to float if device is MPS

Note: for some reason test runs much longer on MPS than on CPU
```
% python ../test/test_indexing.py -v -k test_index_put_accumulate_duplicate_indices_mps
test_index_put_accumulate_duplicate_indices_mps (__main__.TestIndexingMPS.test_index_put_accumulate_duplicate_indices_mps) ... ok

----------------------------------------------------------------------
Ran 1 test in 9.139s

OK
```
Pull Request resolved: pytorch#161201
Approved by: https://github.com/dcci
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
…orch#161201)

By changing dtype to float if device is MPS

Note: for some reason test runs much longer on MPS than on CPU
```
% python ../test/test_indexing.py -v -k test_index_put_accumulate_duplicate_indices_mps
test_index_put_accumulate_duplicate_indices_mps (__main__.TestIndexingMPS.test_index_put_accumulate_duplicate_indices_mps) ... ok

----------------------------------------------------------------------
Ran 1 test in 9.139s

OK
```
Pull Request resolved: pytorch#161201
Approved by: https://github.com/dcci
@github-actions github-actions bot deleted the gh/malfet/497/head branch September 21, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants