[MPS] Fix index_select for scalar_types#161206
Closed
malfet wants to merge 2 commits intogh/malfet/498/basefrom
Closed
[MPS] Fix index_select for scalar_types#161206malfet wants to merge 2 commits intogh/malfet/498/basefrom
malfet wants to merge 2 commits intogh/malfet/498/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161206
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 54baff4 with merge base cb57953 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
manuelcandales
approved these changes
Aug 22, 2025
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 22, 2025
By `squeezing the input` when copying into scalar tensor from a 1d one And enable `test_index_copy_scalars_mps` Fixes #160737 Pull Request resolved: #161267 Approved by: https://github.com/manuelcandales, https://github.com/Skylion007, https://github.com/dcci ghstack dependencies: #161206
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 23, 2025
By passing strides to strided variant of the tensor Fixes #160993 Pull Request resolved: #161333 Approved by: https://github.com/huydhn, https://github.com/wdvr ghstack dependencies: #161206, #161267
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
By copy-n-pasting logic from `index_select_out_cpu` (and `_cuda`), where essentially the resizing is done inside the op, which also fixes faulty logic for scalars Pull Request resolved: pytorch#161206 Approved by: https://github.com/manuelcandales
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
By `squeezing the input` when copying into scalar tensor from a 1d one And enable `test_index_copy_scalars_mps` Fixes pytorch#160737 Pull Request resolved: pytorch#161267 Approved by: https://github.com/manuelcandales, https://github.com/Skylion007, https://github.com/dcci ghstack dependencies: pytorch#161206
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
By passing strides to strided variant of the tensor Fixes pytorch#160993 Pull Request resolved: pytorch#161333 Approved by: https://github.com/huydhn, https://github.com/wdvr ghstack dependencies: pytorch#161206, pytorch#161267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
index_copyfor scalars #161267By copy-n-pasting logic from
index_select_out_cpu(and_cuda), where essentially the resizing is done inside the op, which also fixes faulty logic for scalars