Skip to content

Back out "Refactor CUDAAllocatorConfig to reuse AcceleratorAllocatorConfig (#150312)"#161002

Closed
joshuuuasu wants to merge 1 commit intopytorch:mainfrom
joshuuuasu:export-D80553588
Closed

Back out "Refactor CUDAAllocatorConfig to reuse AcceleratorAllocatorConfig (#150312)"#161002
joshuuuasu wants to merge 1 commit intopytorch:mainfrom
joshuuuasu:export-D80553588

Conversation

@joshuuuasu
Copy link
Contributor

Summary: reverting this diff since it caused S551328. Please see D80217492 for dertails.

Test Plan:
NA

Rollback Plan:

Differential Revision: D80553588

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 19, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161002

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

⏳ No Failures, 50 Pending

As of commit 574040d with merge base 30384ab (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80553588

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 19, 2025
pytorch-bot bot pushed a commit that referenced this pull request Aug 20, 2025
…onfig (#150312)" (#161002)

Summary:

reverting this diff since it caused S551328. Please see D80217492 for dertails.

Test Plan:
NA

Rollback Plan:

Reviewed By: sayitmemory, jingsh

Differential Revision: D80553588
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80553588

…onfig (pytorch#150312)" (pytorch#161002)

Summary:
Pull Request resolved: pytorch#161002

reverting this diff since it caused S551328. Please see D80217492 for dertails.

Test Plan:
NA

Rollback Plan:

Reviewed By: sayitmemory, jingsh

Differential Revision: D80553588
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D80553588

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@seemethere
Copy link
Member

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 21, 2025
@seemethere
Copy link
Member

@pytorchbot merge -c ghfirst -f"this is already backed out"

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -c ghfirst

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@seemethere
Copy link
Member

@pytorchbot merge -c ghfirst -f "this is already backed out"

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 21, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -c ghfirst

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@izaitsevfb
Copy link
Contributor

@pytorchbot merge -f "this is already backed out"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: Approvers from one of the following sets are needed:

  • superuser (pytorch/metamates)
  • Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
  • Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)
Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@izaitsevfb
Copy link
Contributor

@pytorchbot merge -f "this is already backed out"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@amdfaa
Copy link
Contributor

amdfaa commented Aug 27, 2025

@atalman
Copy link
Contributor

atalman commented Aug 27, 2025

@amdfaa I will try to revert #156165 and #156175 which is part of the same stack

@guangyey
Copy link
Collaborator

@pytorchbot revert -c ghfirst -m "This PR breaks CI TestCudaMallocAsync::test_allocator_settings"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Aug 27, 2025
…locatorConfig (#150312)" (#161002)"

This reverts commit a03cc53.

Reverted #161002 on behalf of https://github.com/guangyey due to This PR breaks CI TestCudaMallocAsync::test_allocator_settings ([comment](#161002 (comment)))
@pytorchmergebot
Copy link
Collaborator

@joshuuuasu your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Aug 27, 2025
@guangyey
Copy link
Collaborator

@joshuuuasu @izaitsevfb I will revert this PR first to make the current CI pass. And then I will prepare a PR to help revert the stack of #156175

@izaitsevfb
Copy link
Contributor

@joshuuuasu @izaitsevfb I will revert this PR first to make the current CI pass. And then I will prepare a PR to help revert the stack of #156175

@guangyey, thanks! please coordinate the efforts with @atalman in the slack.

@facebook-github-bot
Copy link
Contributor

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check

Details for Dev Infra team Raised by workflow job

@malfet malfet closed this Aug 27, 2025
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
…onfig (pytorch#150312)" (pytorch#161002)

Summary: reverting this diff since it caused S551328. Please see D80217492 for dertails.

Test Plan:
NA

Rollback Plan:

Differential Revision: D80553588

Pull Request resolved: pytorch#161002
Approved by: https://github.com/jingsh, https://github.com/izaitsevfb
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
…locatorConfig (pytorch#150312)" (pytorch#161002)"

This reverts commit a03cc53.

Reverted pytorch#161002 on behalf of https://github.com/guangyey due to This PR breaks CI TestCudaMallocAsync::test_allocator_settings ([comment](pytorch#161002 (comment)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged Reverted topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants