Back out "Refactor CUDAAllocatorConfig to reuse AcceleratorAllocatorConfig (#150312)"#161002
Back out "Refactor CUDAAllocatorConfig to reuse AcceleratorAllocatorConfig (#150312)"#161002joshuuuasu wants to merge 1 commit intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161002
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 50 PendingAs of commit 574040d with merge base 30384ab ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D80553588 |
0771f30 to
93c4980
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80553588 |
…onfig (pytorch#150312)" (pytorch#161002) Summary: Pull Request resolved: pytorch#161002 reverting this diff since it caused S551328. Please see D80217492 for dertails. Test Plan: NA Rollback Plan: Reviewed By: sayitmemory, jingsh Differential Revision: D80553588
|
This pull request was exported from Phabricator. Differential Revision: D80553588 |
93c4980 to
574040d
Compare
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot label "topic: not user facing" |
|
@pytorchbot merge -c ghfirst -f"this is already backed out" |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -c ghfirst -f "this is already backed out" |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -f "this is already backed out" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Approvers from one of the following sets are needed:
|
|
@pytorchbot merge -f "this is already backed out" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
This PR is causing failures for both rocm and cuda. See the following link: |
|
@pytorchbot revert -c ghfirst -m "This PR breaks CI TestCudaMallocAsync::test_allocator_settings" |
|
@pytorchbot successfully started a revert job. Check the current status here. |
…locatorConfig (#150312)" (#161002)" This reverts commit a03cc53. Reverted #161002 on behalf of https://github.com/guangyey due to This PR breaks CI TestCudaMallocAsync::test_allocator_settings ([comment](#161002 (comment)))
|
@joshuuuasu your PR has been successfully reverted. |
|
@joshuuuasu @izaitsevfb I will revert this PR first to make the current CI pass. And then I will prepare a PR to help revert the stack of #156175 |
@guangyey, thanks! please coordinate the efforts with @atalman in the slack. |
|
@pytorchbot merge -i (Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally) |
Merge startedYour change will be merged while ignoring the following 0 checks: Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check Details for Dev Infra teamRaised by workflow job |
…onfig (pytorch#150312)" (pytorch#161002) Summary: reverting this diff since it caused S551328. Please see D80217492 for dertails. Test Plan: NA Rollback Plan: Differential Revision: D80553588 Pull Request resolved: pytorch#161002 Approved by: https://github.com/jingsh, https://github.com/izaitsevfb
…locatorConfig (pytorch#150312)" (pytorch#161002)" This reverts commit a03cc53. Reverted pytorch#161002 on behalf of https://github.com/guangyey due to This PR breaks CI TestCudaMallocAsync::test_allocator_settings ([comment](pytorch#161002 (comment)))
Summary: reverting this diff since it caused S551328. Please see D80217492 for dertails.
Test Plan:
NA
Rollback Plan:
Differential Revision: D80553588