Deprecate overleap functions in CUDAAllocatorConfig, use AcceleratorAllocatorConfig instead#156165
Closed
guangyey wants to merge 75 commits intogh/guangyey/158/basefrom
Closed
Deprecate overleap functions in CUDAAllocatorConfig, use AcceleratorAllocatorConfig instead#156165guangyey wants to merge 75 commits intogh/guangyey/158/basefrom
guangyey wants to merge 75 commits intogh/guangyey/158/basefrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/156165
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ You can merge normally! (2 Unrelated Failures)As of commit c0f06ff with merge base bb67660 ( UNSTABLE - The following jobs are marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jun 17, 2025
guangyey
commented
Jun 17, 2025
c10/cuda/CUDACachingAllocator.cpp
Outdated
| using namespace c10::CachingDeviceAllocator; | ||
|
|
||
| // Included here as this is externally used in CUDAAllocatorConfig | ||
| const size_t kLargeBuffer = |
Collaborator
Author
There was a problem hiding this comment.
already move to AllocatorConfig.h
Collaborator
|
Starting merge as part of PR stack under #156175 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Jul 30, 2025
# Motivation This PR moves the implementation of `torch.cuda.memory._set_allocator_settings` to `torch._C._accelerator_setAllocatorSettings`. Since the original API was intended as a temporary/internal utility, I am not exposing the new function as a public API. Pull Request resolved: #156175 Approved by: https://github.com/albanD ghstack dependencies: #149601, #157908, #150312, #156165
pytorchmergebot
added a commit
that referenced
this pull request
Aug 1, 2025
…leratorAllocatorConfig instead (#156165)" This reverts commit 1fc010a. Reverted #156165 on behalf of https://github.com/guangyey due to Static initialization order issue impact the downstream repo ([comment](#150312 (comment)))
Collaborator
yangw-dev
pushed a commit
that referenced
this pull request
Aug 1, 2025
# Motivation This PR moves the implementation of `torch.cuda.memory._set_allocator_settings` to `torch._C._accelerator_setAllocatorSettings`. Since the original API was intended as a temporary/internal utility, I am not exposing the new function as a public API. Pull Request resolved: #156175 Approved by: https://github.com/albanD ghstack dependencies: #149601, #157908, #150312, #156165
yangw-dev
pushed a commit
that referenced
this pull request
Aug 1, 2025
…leratorAllocatorConfig instead (#156165)" This reverts commit 1fc010a. Reverted #156165 on behalf of https://github.com/guangyey due to Static initialization order issue impact the downstream repo ([comment](#150312 (comment)))
Collaborator
|
Starting merge as part of PR stack under #156175 |
3 similar comments
Collaborator
|
Starting merge as part of PR stack under #156175 |
Collaborator
|
Starting merge as part of PR stack under #156175 |
Collaborator
|
Starting merge as part of PR stack under #156175 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 5, 2025
# Motivation This PR moves the implementation of `torch.cuda.memory._set_allocator_settings` to `torch._C._accelerator_setAllocatorSettings`. Since the original API was intended as a temporary/internal utility, I am not exposing the new function as a public API. Pull Request resolved: #156175 Approved by: https://github.com/albanD ghstack dependencies: #159629, #150312, #156165
joshuuuasu
added a commit
to joshuuuasu/pytorch
that referenced
this pull request
Aug 19, 2025
…celeratorAllocatorConfig instead (pytorch#156165)" Summary: reverting this diff since it caused S551328. Please see D80217492 for dertails. Test Plan: NA Rollback Plan: Differential Revision: D80553314
This was referenced Aug 27, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k