[BE] Move indexing tests to test_indexing#160994
Closed
malfet wants to merge 6 commits intogh/malfet/495/basefrom
Closed
[BE] Move indexing tests to test_indexing#160994malfet wants to merge 6 commits intogh/malfet/495/basefrom
malfet wants to merge 6 commits intogh/malfet/495/basefrom
Conversation
Which enables them on MPS device [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160994
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e7ba96b with merge base 114813c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
manuelcandales
approved these changes
Aug 19, 2025
Which enables them on MPS device - xfail all `test_index_reduce` on MPS, as op is not implemented - xfail all `test_index_copy` on MPS due to the silent correctness problems, see #160993 [ghstack-poisoned]
Which enables them on MPS device - xfail all `test_index_reduce` on MPS, as op is not implemented - xfail all `test_index_copy` on MPS due to the silent correctness problems, see #160993 [ghstack-poisoned]
Which enables them on MPS device - xfail all `test_index_reduce` on MPS, as op is not implemented - xfail all `test_index_copy` on MPS due to the silent correctness problems, see #160993 [ghstack-poisoned]
Which enables them on MPS device - xfail all `test_index_reduce` on MPS, as op is not implemented - xfail all `test_index_copy` on MPS due to the silent correctness problems, see #160993 [ghstack-poisoned]
Which enables them on MPS device - xfail all `test_index_reduce` on MPS, as op is not implemented - xfail all `test_index_copy` on MPS due to the silent correctness problems, see #160993 [ghstack-poisoned]
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Which enables them on MPS device - xfail all `test_index_reduce` on MPS, as op is not implemented - xfail all `test_index_copy` on MPS due to the silent correctness problems, see pytorch#160993 - Fixed hard crash in `index_fill` and replaced `skipIfMPS` with `expectedFailueMPS` - Created issue for the lack of deterministic algorithms for MPS backend Pull Request resolved: pytorch#160994 Approved by: https://github.com/manuelcandales ghstack dependencies: pytorch#160850, pytorch#160889, pytorch#160926
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Which enables them on MPS device
test_index_reduceon MPS, as op is not implementedtest_index_copyon MPS due to the silent correctness problems, see test_index_copy fails on MPS with correctness issues #160993index_filland replacedskipIfMPSwithexpectedFailueMPS